diff mbox

[v2,2/2] tpm/st33zp24/spi: Add missing device table for spi phy.

Message ID 1427047988-18132-3-git-send-email-christophe-h.ricard@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Christophe Ricard March 22, 2015, 6:13 p.m. UTC 
MODULE_DEVICE_TABLE is missing in spi phy in case CONFIG_OF is not set.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
---
 drivers/char/tpm/st33zp24/spi.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Jason Gunthorpe March 23, 2015, 7:10 p.m. UTC | #1 
On Sun, Mar 22, 2015 at 07:13:08PM +0100, Christophe Ricard wrote:
> MODULE_DEVICE_TABLE is missing in spi phy in case CONFIG_OF is not set.

Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
 
> Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
>  drivers/char/tpm/st33zp24/spi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
> index 7f4a5a4..f0184a1 100644
> +++ b/drivers/char/tpm/st33zp24/spi.c
> @@ -362,6 +362,12 @@ static int tpm_st33_spi_remove(struct spi_device *dev)
>  	return st33zp24_remove(chip);
>  }
>  
> +static const struct spi_device_id st33zp24_spi_id[] = {
> +	{TPM_ST33_SPI, 0},
> +	{}
> +};
> +MODULE_DEVICE_TABLE(spi, st33zp24_spi_id);
> +
>  #ifdef CONFIG_OF
>  static const struct of_device_id of_st33zp24_spi_match[] = {
>  	{ .compatible = "st,st33zp24-spi", },
> @@ -382,6 +388,7 @@ static struct spi_driver tpm_st33_spi_driver = {
>  	},
>  	.probe = tpm_st33_spi_probe,
>  	.remove = tpm_st33_spi_remove,
> +	.id_table = st33zp24_spi_id,
>  };
>  
>  module_spi_driver(tpm_st33_spi_driver);
diff mbox

Patch

diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
index 7f4a5a4..f0184a1 100644
--- a/drivers/char/tpm/st33zp24/spi.c
+++ b/drivers/char/tpm/st33zp24/spi.c
@@ -362,6 +362,12 @@  static int tpm_st33_spi_remove(struct spi_device *dev)
 	return st33zp24_remove(chip);
 }
 
+static const struct spi_device_id st33zp24_spi_id[] = {
+	{TPM_ST33_SPI, 0},
+	{}
+};
+MODULE_DEVICE_TABLE(spi, st33zp24_spi_id);
+
 #ifdef CONFIG_OF
 static const struct of_device_id of_st33zp24_spi_match[] = {
 	{ .compatible = "st,st33zp24-spi", },
@@ -382,6 +388,7 @@  static struct spi_driver tpm_st33_spi_driver = {
 	},
 	.probe = tpm_st33_spi_probe,
 	.remove = tpm_st33_spi_remove,
+	.id_table = st33zp24_spi_id,
 };
 
 module_spi_driver(tpm_st33_spi_driver);