| Message ID | 1427236200-18625-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 24, 2015 at 10:30:00PM +0000, Srinivas Kandagatla wrote: > + /* regmap_get_reg_stride(): Report the register address stride > + * > + * Report the register address stride, mainly intended to for use by > + * generic infrastructure built on top of regmap. > + */ > +int regmap_get_reg_stride(struct regmap *map) Please fix the indentation for the comment block and add kerneldoc for the argument. This is an exported function so it should also be /** not /*
On 24/03/15 22:37, Mark Brown wrote: > On Tue, Mar 24, 2015 at 10:30:00PM +0000, Srinivas Kandagatla wrote: > >> + /* regmap_get_reg_stride(): Report the register address stride >> + * >> + * Report the register address stride, mainly intended to for use by >> + * generic infrastructure built on top of regmap. >> + */ >> +int regmap_get_reg_stride(struct regmap *map) > > Please fix the indentation for the comment block and add kerneldoc for > the argument. This is an exported function so it should also be /** not > /* > My bad.. I will fix it in next version.
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 6fd234b..44d3d94 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2628,6 +2628,17 @@ int regmap_get_max_register(struct regmap *map) } EXPORT_SYMBOL_GPL(regmap_get_max_register); + /* regmap_get_reg_stride(): Report the register address stride + * + * Report the register address stride, mainly intended to for use by + * generic infrastructure built on top of regmap. + */ +int regmap_get_reg_stride(struct regmap *map) +{ + return map->reg_stride; +} +EXPORT_SYMBOL_GPL(regmap_get_reg_stride); + int regmap_parse_val(struct regmap *map, const void *buf, unsigned int *val) { diff --git a/include/linux/regmap.h b/include/linux/regmap.h index c46dbf3..b58067c 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -434,6 +434,7 @@ int regmap_update_bits_check_async(struct regmap *map, unsigned int reg, bool *change); int regmap_get_val_bytes(struct regmap *map); int regmap_get_max_register(struct regmap *map); +int regmap_get_reg_stride(struct regmap *map); int regmap_async_complete(struct regmap *map); bool regmap_can_raw_write(struct regmap *map); @@ -683,6 +684,12 @@ static inline int regmap_get_max_register(struct regmap *map) return -EINVAL; } +static inline int regmap_get_reg_stride(struct regmap *map) +{ + WARN_ONCE(1, "regmap API is disabled"); + return -EINVAL; +} + static inline int regcache_sync(struct regmap *map) { WARN_ONCE(1, "regmap API is disabled");
This patch introduces regmap_get_reg_stride() function which would be used by the infrastructures like eeprom framework built on top of regmap. Mostly this function would be used for sanity checks on inputs within such infrastructure. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/base/regmap/regmap.c | 11 +++++++++++ include/linux/regmap.h | 7 +++++++ 2 files changed, 18 insertions(+)