| Message ID | 1427704134-30699-6-git-send-email-qca_vkondrat@qca.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes: > Firmware "board" file name has changed from wil6210.board > to wil6210.brd by the FW generation tools. > > Reflect this in the driver. > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> > --- > drivers/net/wireless/ath/wil6210/wil6210.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wil6210/wil6210.h b/drivers/net/wireless/ath/wil6210/wil6210.h > index f4681e3..abb2080 100644 > --- a/drivers/net/wireless/ath/wil6210/wil6210.h > +++ b/drivers/net/wireless/ath/wil6210/wil6210.h > @@ -33,7 +33,7 @@ extern bool debug_fw; > > #define WIL_NAME "wil6210" > #define WIL_FW_NAME "wil6210.fw" /* code */ > -#define WIL_FW2_NAME "wil6210.board" /* board & radio parameters */ > +#define WIL_FW2_NAME "wil6210.brd" /* board & radio parameters */ I consider the firmware file names as part of stable user space interface (older user space need to work with newer kernel etc) and this change breaks that.
On Monday, March 30, 2015 12:38:08 PM Kalle Valo wrote: > Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes: > > > Firmware "board" file name has changed from wil6210.board > > to wil6210.brd by the FW generation tools. > > > > Reflect this in the driver. > > > > -#define WIL_FW2_NAME "wil6210.board" /* board & radio parameters */ > > +#define WIL_FW2_NAME "wil6210.brd" /* board & radio parameters */ > > I consider the firmware file names as part of stable user space > interface (older user space need to work with newer kernel etc) and this > change breaks that. > Hardware was not released to the public yet; no one besides developers in the lab should be affected by this. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes: > On Monday, March 30, 2015 12:38:08 PM Kalle Valo wrote: >> Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes: >> >> > Firmware "board" file name has changed from wil6210.board >> > to wil6210.brd by the FW generation tools. >> > >> > Reflect this in the driver. >> > > >> > -#define WIL_FW2_NAME "wil6210.board" /* board & radio parameters */ >> > +#define WIL_FW2_NAME "wil6210.brd" /* board & radio parameters */ >> >> I consider the firmware file names as part of stable user space >> interface (older user space need to work with newer kernel etc) and this >> change breaks that. > > Hardware was not released to the public yet; no one besides developers > in the lab should be affected by this. Actually that doesn't matter as it's common to run few years old kernels, especially in the embedded world. So no matter what, this breaks compatibility with user space and without any real benefit whatsoever. Now will anyone hit this in practise I don't know. I guess this change is ok for now as wil6210 hw is not that common, but in the future please be careful with this.
diff --git a/drivers/net/wireless/ath/wil6210/wil6210.h b/drivers/net/wireless/ath/wil6210/wil6210.h index f4681e3..abb2080 100644 --- a/drivers/net/wireless/ath/wil6210/wil6210.h +++ b/drivers/net/wireless/ath/wil6210/wil6210.h @@ -33,7 +33,7 @@ extern bool debug_fw; #define WIL_NAME "wil6210" #define WIL_FW_NAME "wil6210.fw" /* code */ -#define WIL_FW2_NAME "wil6210.board" /* board & radio parameters */ +#define WIL_FW2_NAME "wil6210.brd" /* board & radio parameters */ #define WIL_MAX_BUS_REQUEST_KBPS 800000 /* ~6.1Gbps */
Firmware "board" file name has changed from wil6210.board to wil6210.brd by the FW generation tools. Reflect this in the driver. Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> --- drivers/net/wireless/ath/wil6210/wil6210.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)