| Message ID | 1426938462-884-6-git-send-email-madcatxster@devoid-pointer.net (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Sat, 21 Mar 2015, Michal Malý wrote: > The original warning message was highly misleading. This warning can be > triggered only if a device is flagged to be handled by hid-lg4ff in > hid-lg but hid-lg4ff lacks support for such device. > > Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net> > --- > drivers/hid/hid-lg4ff.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c > index d1d5d45..a2f47ee 100644 > --- a/drivers/hid/hid-lg4ff.c > +++ b/drivers/hid/hid-lg4ff.c > @@ -1021,8 +1021,7 @@ int lg4ff_init(struct hid_device *hid) > } > > if (i == ARRAY_SIZE(lg4ff_devices)) { > - hid_err(hid, "Device is not supported by lg4ff driver. If you think it should be, consider reporting a bug to" > - "LKML, Simon Wood <simon@mungewell.org> or Michal Maly <madcatxster@gmail.com>\n"); > + hid_err(hid, "This device is flagged to be handled by the lg4ff module but this module does not know how to handle it. Please report this as a bug to LKML, Simon Wood <simon@mungewell.org> or Michal Maly <madcatxster@devoid-pointer.net>\n"); Could you please split this so that we don't have this ugly overly long line, and resend this patch as v2? Thanks.
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index d1d5d45..a2f47ee 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -1021,8 +1021,7 @@ int lg4ff_init(struct hid_device *hid) } if (i == ARRAY_SIZE(lg4ff_devices)) { - hid_err(hid, "Device is not supported by lg4ff driver. If you think it should be, consider reporting a bug to" - "LKML, Simon Wood <simon@mungewell.org> or Michal Maly <madcatxster@gmail.com>\n"); + hid_err(hid, "This device is flagged to be handled by the lg4ff module but this module does not know how to handle it. Please report this as a bug to LKML, Simon Wood <simon@mungewell.org> or Michal Maly <madcatxster@devoid-pointer.net>\n"); return -1; }
The original warning message was highly misleading. This warning can be triggered only if a device is flagged to be handled by hid-lg4ff in hid-lg but hid-lg4ff lacks support for such device. Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net> --- drivers/hid/hid-lg4ff.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)