| Message ID | 1428669293-11165-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/10/15 05:34, Srinivas Kandagatla wrote: > From: Nicolas Dechesne <nicolas.dechesne@linaro.org> > > This patch adds USB OTG support on USB1 for Compulab QS-600 Board. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > [Srinivas Kandagatla: fixed up regulators and status properties] > Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > index fc69931..d353694 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -101,6 +101,14 @@ > }; > }; > > + /* OTG */ > + usb1_phy:phy@12500000 { Space after that ':' please. > + status = "okay"; > + vddcx-supply = <&pm8921_s3>; > + v3p3-supply = <&pm8921_l3>; > + v1p8-supply = <&pm8921_l4>; > + }; > + > usb3_phy:phy@12520000 { > status = "okay"; > vddcx-supply = <&pm8921_s3>; > @@ -115,6 +123,15 @@ > v1p8-supply = <&pm8921_l23>; > }; > > + gadget1:gadget@12500000 { > + status = "ok"; > + }; > + > + /* OTG */ > + usb1: usb@12500000 { This one is good. > + status = "ok"; > + }; > + > usb3: usb@12520000 { > status = "okay"; > };
On 10/04/15 18:26, Stephen Boyd wrote: > On 04/10/15 05:34, Srinivas Kandagatla wrote: >> From: Nicolas Dechesne <nicolas.dechesne@linaro.org> >> >> This patch adds USB OTG support on USB1 for Compulab QS-600 Board. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> [Srinivas Kandagatla: fixed up regulators and status properties] >> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org> >> --- >> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> index fc69931..d353694 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts >> @@ -101,6 +101,14 @@ >> }; >> }; >> >> + /* OTG */ >> + usb1_phy:phy@12500000 { > > Space after that ':' please. > Yep, I will fix it in next version. >> + status = "okay"; >> + vddcx-supply = <&pm8921_s3>; >> + v3p3-supply = <&pm8921_l3>; >> + v1p8-supply = <&pm8921_l4>; >> + }; >> + >> usb3_phy:phy@12520000 { >> status = "okay"; >> vddcx-supply = <&pm8921_s3>; >> @@ -115,6 +123,15 @@ >> v1p8-supply = <&pm8921_l23>; >> }; >> >> + gadget1:gadget@12500000 { >> + status = "ok"; >> + }; >> + >> + /* OTG */ >> + usb1: usb@12500000 { > > This one is good. > >> + status = "ok"; >> + }; >> + >> usb3: usb@12520000 { >> status = "okay"; >> }; > >
diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts index fc69931..d353694 100644 --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts @@ -101,6 +101,14 @@ }; }; + /* OTG */ + usb1_phy:phy@12500000 { + status = "okay"; + vddcx-supply = <&pm8921_s3>; + v3p3-supply = <&pm8921_l3>; + v1p8-supply = <&pm8921_l4>; + }; + usb3_phy:phy@12520000 { status = "okay"; vddcx-supply = <&pm8921_s3>; @@ -115,6 +123,15 @@ v1p8-supply = <&pm8921_l23>; }; + gadget1:gadget@12500000 { + status = "ok"; + }; + + /* OTG */ + usb1: usb@12500000 { + status = "ok"; + }; + usb3: usb@12520000 { status = "okay"; };