| Message ID | 20150411012111.GA64853@snb (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 04/11/2015 03:21 AM, kbuild test robot wrote: > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Ack, these should all be static: Acked-by: Hans de Goede <hdegoede@redhat.com> Dmitry, can you please merge this one ? Regards, Hans > --- > alps.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index ad741c0..3ef93ff 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse) > alps_process_touchpad_packet_v7(psmouse); > } > > -unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) > +static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) > { > unsigned char pkt_id = SS4_PACKET_ID_IDLE; > > @@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse, > return 0; > } > > -int alps_update_device_area_ss4_v2(unsigned char otp[][4], > +static int alps_update_device_area_ss4_v2(unsigned char otp[][4], > struct alps_data *priv) > { > int num_x_electrode; > @@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4], > return 0; > } > > -int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) > +static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) > { > > unsigned char is_btnless; > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Apr 11, 2015 at 08:32:10AM +0200, Hans de Goede wrote: > Hi, > > On 04/11/2015 03:21 AM, kbuild test robot wrote: > > > >Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Ack, these should all be static: > > Acked-by: Hans de Goede <hdegoede@redhat.com> > > Dmitry, can you please merge this one ? Yep, applied, thank you. > > Regards, > > Hans > > >--- > > alps.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > >index ad741c0..3ef93ff 100644 > >--- a/drivers/input/mouse/alps.c > >+++ b/drivers/input/mouse/alps.c > >@@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse) > > alps_process_touchpad_packet_v7(psmouse); > > } > > > >-unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) > >+static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) > > { > > unsigned char pkt_id = SS4_PACKET_ID_IDLE; > > > >@@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse, > > return 0; > > } > > > >-int alps_update_device_area_ss4_v2(unsigned char otp[][4], > >+static int alps_update_device_area_ss4_v2(unsigned char otp[][4], > > struct alps_data *priv) > > { > > int num_x_electrode; > >@@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4], > > return 0; > > } > > > >-int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) > >+static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) > > { > > > > unsigned char is_btnless; > >
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index ad741c0..3ef93ff 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse) alps_process_touchpad_packet_v7(psmouse); } -unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) +static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte) { unsigned char pkt_id = SS4_PACKET_ID_IDLE; @@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse, return 0; } -int alps_update_device_area_ss4_v2(unsigned char otp[][4], +static int alps_update_device_area_ss4_v2(unsigned char otp[][4], struct alps_data *priv) { int num_x_electrode; @@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4], return 0; } -int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) +static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv) { unsigned char is_btnless;
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- alps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html