| Message ID | 1429091364-31939-1-git-send-email-Minghuan.Lian@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Minghuan Lian, On Wed, Apr 15, 2015 at 05:49:22PM +0800, Minghuan Lian wrote: > The default page size of ITS table has been changed to 64KB, > but for some platforms the real size of allocate memory which > calculated by DEVBITS of register GITS_TYPER may smaller than > default size. In this case, psz must be decreased, otherwise, > the wrong page number will cause kernel hang. > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > --- > drivers/irqchip/irq-gic-v3-its.c | 3 +++ > 1 file changed, 3 insertions(+) Please run scripts/get_maintainer.pl on your patches before sending. This needs to be sent to myself and Thomas Gleixner for review. The merge window just opened, so nothing new is being added to the tree currently. Go ahead and resend after a few days. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015-04-15 12:51, Jason Cooper wrote: > Minghuan Lian, > > On Wed, Apr 15, 2015 at 05:49:22PM +0800, Minghuan Lian wrote: >> The default page size of ITS table has been changed to 64KB, >> but for some platforms the real size of allocate memory which >> calculated by DEVBITS of register GITS_TYPER may smaller than >> default size. In this case, psz must be decreased, otherwise, >> the wrong page number will cause kernel hang. >> >> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> >> --- >> drivers/irqchip/irq-gic-v3-its.c | 3 +++ >> 1 file changed, 3 insertions(+) > > Please run scripts/get_maintainer.pl on your patches before sending. > This > needs to be sent to myself and Thomas Gleixner for review. Please also CC me on anything that touches GICv3 or the ITS code. Thanks, M.
On Wed, 15 Apr 2015 17:49:22 +0800 Minghuan Lian <Minghuan.Lian@freescale.com> wrote: [adding Jason and Thomas to the party, since they shoud be cc'd the first place] > The default page size of ITS table has been changed to 64KB, > but for some platforms the real size of allocate memory which > calculated by DEVBITS of register GITS_TYPER may smaller than > default size. In this case, psz must be decreased, otherwise, > the wrong page number will cause kernel hang. > > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> > --- > drivers/irqchip/irq-gic-v3-its.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 596b0a9..d0374a6 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -844,6 +844,9 @@ static int its_alloc_tables(struct its_node *its) > > its->tables[i] = base; > > + while (alloc_size < psz) > + psz = psz >> 1; > + > retry_baser: > val = (virt_to_phys(base) | > (type << GITS_BASER_TYPE_SHIFT) | This doesn't make sense to me. psz is the page size that your HW supports, not necessarily something that you can actually change as you wish (some, if not most, ITSs only support one page size). Also, you now have to psz go via unsupported page sizes (like 32K and 8K), and you may end up programming junk in the registers. Good job! ;-) So making it vary to accommodate your allocation size is slightly doomed. If your allocation is smaller than your ITS page size, it is the allocation that has to be bumped up, not the page size that has to be reduced. So overall, this is a NAK. Please come up with a better fix. Thanks, M.
SGkgTWFyYywNCg0KT0ssIEkgd2lsbCBmb2xsb3cgeW91ciBjb21tZW50Lg0KDQpUaGFua3MsDQpN aW5naHVhbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1hcmMgWnlu Z2llciBbbWFpbHRvOm1hcmMuenluZ2llckBhcm0uY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIEFw cmlsIDE1LCAyMDE1IDEwOjE3IFBNDQo+IFRvOiBKYXNvbiBDb29wZXI7IExpYW4gTWluZ2h1YW4t QjMxOTM5DQo+IENjOiBBcm5kIEJlcmdtYW5uOyBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnOyBI dSBNaW5na2FpLUIyMTI4NDsgWmFuZw0KPiBSb3ktUjYxOTExOyBZb2RlciBTdHVhcnQtQjA4MjQ4 OyBXb29kIFNjb3R0LUIwNzQyMTsgQmpvcm4gSGVsZ2FhczsgbGludXgtDQo+IGFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBpcnFjaGlwL2dpY3Yz LWl0czogRGVjcmVhc2UgcGFnZSBzaXplIHdoZW4gbmVlZGVkDQo+IA0KPiBPbiAyMDE1LTA0LTE1 IDEyOjUxLCBKYXNvbiBDb29wZXIgd3JvdGU6DQo+ID4gTWluZ2h1YW4gTGlhbiwNCj4gPg0KPiA+ IE9uIFdlZCwgQXByIDE1LCAyMDE1IGF0IDA1OjQ5OjIyUE0gKzA4MDAsIE1pbmdodWFuIExpYW4g d3JvdGU6DQo+ID4+IFRoZSBkZWZhdWx0IHBhZ2Ugc2l6ZSBvZiBJVFMgdGFibGUgaGFzIGJlZW4g Y2hhbmdlZCB0byA2NEtCLCBidXQgZm9yDQo+ID4+IHNvbWUgcGxhdGZvcm1zIHRoZSByZWFsIHNp emUgb2YgYWxsb2NhdGUgbWVtb3J5IHdoaWNoIGNhbGN1bGF0ZWQgYnkNCj4gPj4gREVWQklUUyBv ZiByZWdpc3RlciBHSVRTX1RZUEVSIG1heSBzbWFsbGVyIHRoYW4gZGVmYXVsdCBzaXplLiBJbiB0 aGlzDQo+ID4+IGNhc2UsIHBzeiBtdXN0IGJlIGRlY3JlYXNlZCwgb3RoZXJ3aXNlLCB0aGUgd3Jv bmcgcGFnZSBudW1iZXIgd2lsbA0KPiA+PiBjYXVzZSBrZXJuZWwgaGFuZy4NCj4gPj4NCj4gPj4g U2lnbmVkLW9mZi1ieTogTWluZ2h1YW4gTGlhbiA8TWluZ2h1YW4uTGlhbkBmcmVlc2NhbGUuY29t Pg0KPiA+PiAtLS0NCj4gPj4gIGRyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jIHwgMyAr KysNCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IFBsZWFz ZSBydW4gc2NyaXB0cy9nZXRfbWFpbnRhaW5lci5wbCBvbiB5b3VyIHBhdGNoZXMgYmVmb3JlIHNl bmRpbmcuDQo+ID4gVGhpcw0KPiA+IG5lZWRzIHRvIGJlIHNlbnQgdG8gbXlzZWxmIGFuZCBUaG9t YXMgR2xlaXhuZXIgZm9yIHJldmlldy4NCj4gDQo+IFBsZWFzZSBhbHNvIENDIG1lIG9uIGFueXRo aW5nIHRoYXQgdG91Y2hlcyBHSUN2MyBvciB0aGUgSVRTIGNvZGUuDQo+IA0KPiBUaGFua3MsDQo+ IA0KPiAgICAgICAgICBNLg0KPiAtLQ0KPiBGYXN0LCBjaGVhcCwgcmVsaWFibGUuIFBpY2sgdHdv Lg0K -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 596b0a9..d0374a6 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -844,6 +844,9 @@ static int its_alloc_tables(struct its_node *its) its->tables[i] = base; + while (alloc_size < psz) + psz = psz >> 1; + retry_baser: val = (virt_to_phys(base) | (type << GITS_BASER_TYPE_SHIFT) |
The default page size of ITS table has been changed to 64KB, but for some platforms the real size of allocate memory which calculated by DEVBITS of register GITS_TYPER may smaller than default size. In this case, psz must be decreased, otherwise, the wrong page number will cause kernel hang. Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com> --- drivers/irqchip/irq-gic-v3-its.c | 3 +++ 1 file changed, 3 insertions(+)