| Message ID | 063d443cc0ddc5db271cdaa6649443eb699736d0.1427471526.git.agruenba@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 27, 2015 at 05:50:00PM +0100, Andreas Gruenbacher wrote: > The enum nfs4_acl_whotype is only used in nfs4d's internal nfs4 acl > representation. No longer expose it to user space. I'll go ahead and apply that now. --b. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> > --- > include/linux/nfs4.h | 7 +++++++ > include/uapi/linux/nfs4.h | 7 ------- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h > index ed43cb7..32201c2 100644 > --- a/include/linux/nfs4.h > +++ b/include/linux/nfs4.h > @@ -16,6 +16,13 @@ > #include <linux/uidgid.h> > #include <uapi/linux/nfs4.h> > > +enum nfs4_acl_whotype { > + NFS4_ACL_WHO_NAMED = 0, > + NFS4_ACL_WHO_OWNER, > + NFS4_ACL_WHO_GROUP, > + NFS4_ACL_WHO_EVERYONE, > +}; > + > struct nfs4_ace { > uint32_t type; > uint32_t flag; > diff --git a/include/uapi/linux/nfs4.h b/include/uapi/linux/nfs4.h > index 35f5f4c..adc0aff 100644 > --- a/include/uapi/linux/nfs4.h > +++ b/include/uapi/linux/nfs4.h > @@ -162,13 +162,6 @@ > */ > #define NFS4_MAX_BACK_CHANNEL_OPS 2 > > -enum nfs4_acl_whotype { > - NFS4_ACL_WHO_NAMED = 0, > - NFS4_ACL_WHO_OWNER, > - NFS4_ACL_WHO_GROUP, > - NFS4_ACL_WHO_EVERYONE, > -}; > - > #endif /* _UAPI_LINUX_NFS4_H */ > > /* > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-04-20 20:57 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>: > On Fri, Mar 27, 2015 at 05:50:00PM +0100, Andreas Gruenbacher wrote: >> The enum nfs4_acl_whotype is only used in nfs4d's internal nfs4 acl >> representation. No longer expose it to user space. > > I'll go ahead and apply that now. There's other very low-hanging fruit for nfsd as well: nfsd: Checking for acl support does not require fetching any acls https://git.kernel.org/cgit/linux/kernel/git/agruen/linux-richacl.git/commit/?h=richacl-2015-04-24&id=b3a09e6f1071ea01de64aa3071cb533e79fb4b18 nfsd: Remove dead declarations https://git.kernel.org/cgit/linux/kernel/git/agruen/linux-richacl.git/commit/?h=richacl-2015-04-24&id=e6e2fa620584c6e2375572191fff7337a902805a And for nfs: nfs: Remove unused xdr page offsets in getacl/setacl arguments https://git.kernel.org/cgit/linux/kernel/git/agruen/linux-richacl.git/commit/?h=richacl-2015-04-24&id=082664972e957e6585c059865a397185ba7d5c88 Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h index ed43cb7..32201c2 100644 --- a/include/linux/nfs4.h +++ b/include/linux/nfs4.h @@ -16,6 +16,13 @@ #include <linux/uidgid.h> #include <uapi/linux/nfs4.h> +enum nfs4_acl_whotype { + NFS4_ACL_WHO_NAMED = 0, + NFS4_ACL_WHO_OWNER, + NFS4_ACL_WHO_GROUP, + NFS4_ACL_WHO_EVERYONE, +}; + struct nfs4_ace { uint32_t type; uint32_t flag; diff --git a/include/uapi/linux/nfs4.h b/include/uapi/linux/nfs4.h index 35f5f4c..adc0aff 100644 --- a/include/uapi/linux/nfs4.h +++ b/include/uapi/linux/nfs4.h @@ -162,13 +162,6 @@ */ #define NFS4_MAX_BACK_CHANNEL_OPS 2 -enum nfs4_acl_whotype { - NFS4_ACL_WHO_NAMED = 0, - NFS4_ACL_WHO_OWNER, - NFS4_ACL_WHO_GROUP, - NFS4_ACL_WHO_EVERYONE, -}; - #endif /* _UAPI_LINUX_NFS4_H */ /*
The enum nfs4_acl_whotype is only used in nfs4d's internal nfs4 acl representation. No longer expose it to user space. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> --- include/linux/nfs4.h | 7 +++++++ include/uapi/linux/nfs4.h | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-)