| Message ID | 1429020304-31045-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Fabio, > Fabio Estevam <fabio.estevam@freescale.com> hat am 14. April 2015 um 16:05 > geschrieben: > > > On imx23-olinuxino the LED turns on when level logic high is aplied to > GPIO2_1. > > Fix the gpios property accordingly. > > Reported-by: Stefan Wahren <stefan.wahren@i2se.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Tested-by: Stefan Wahren <stefan.wahren@i2se.com> I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment? Thanks Stefan
Hi Stefan, On Tue, Apr 14, 2015 at 2:51 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote: > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> > > I did my tests only with iMX233-Olinuxino Maxi. How about your test equipment? Thanks for testing. Unfortunately, I don't have access to my mx23 olinuxino board and could not test it. I have looked in all schematics (maxi, micro, mini and nano) and all of them require logic level high to turn on the LED. Regards, Fabio Estevam
On Tue, Apr 14, 2015 at 11:05:04AM -0300, Fabio Estevam wrote: > On imx23-olinuxino the LED turns on when level logic high is aplied to > GPIO2_1. > > Fix the gpios property accordingly. > > Reported-by: Stefan Wahren <stefan.wahren@i2se.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts index 7e6eef2..839a3b9 100644 --- a/arch/arm/boot/dts/imx23-olinuxino.dts +++ b/arch/arm/boot/dts/imx23-olinuxino.dts @@ -12,6 +12,7 @@ */ /dts-v1/; +#include <dt-bindings/gpio/gpio.h> #include "imx23.dtsi" / { @@ -122,7 +123,7 @@ user { label = "green"; - gpios = <&gpio2 1 1>; + gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; }; }; };
On imx23-olinuxino the LED turns on when level logic high is aplied to GPIO2_1. Fix the gpios property accordingly. Reported-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- arch/arm/boot/dts/imx23-olinuxino.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)