| Message ID | 1430239529-15726-1-git-send-email-valentinrothberg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote: > The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not > been defined in Kconfig since the very first Git commit. Actually, this goes back to a patch titled "1759/1: Add ARM925 support, updated" that landed in v2.6.4. When cleaning up ancient cruft like this it's fun, at least I think it is, and possibly even informative, to have a Linux history repository at hand. Feel free to prod me for details how to create such a repository. Paul Bolle
On Tue, Apr 28, 2015 at 9:24 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote: >> The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not >> been defined in Kconfig since the very first Git commit. > > Actually, this goes back to a patch titled "1759/1: Add ARM925 support, > updated" that landed in v2.6.4. > > When cleaning up ancient cruft like this it's fun, at least I think it > is, and possibly even informative, to have a Linux history repository at > hand. Feel free to prod me for details how to create such a repository. Thanks! I just wanted to point out that this code hasn't been touched since I was at high school : ) Do you link the repositories or do you have a separate history repo? Thanks, Valentin > Paul Bolle >
On Tue, 2015-04-28 at 21:36 +0200, Valentin Rothberg wrote: > Thanks! I just wanted to point out that this code hasn't been touched > since I was at high school : ) (Yes, fine, do rub it in.) Sure, for all practical purposes, v2.6.12-rc2 means: very, very long ago. But I would be applaud if someone managed to outdo my reference to v1.3.82 in commit e5a7286b5f1b ("x86, boot: Remove ancient, unconditionally #ifdef'd out dead code"). > Do you link the repositories or do you have a separate history repo? I started with https://archive.org/details/git-history-of-linux . Its main drawback is that you have to the add tags for ancient releases yourself. And that turned out to be quite time consuming. Thanks, Paul Bolle
diff --git a/arch/arm/mm/proc-arm925.S b/arch/arm/mm/proc-arm925.S index ede8c54ab4aa..32a47cc19076 100644 --- a/arch/arm/mm/proc-arm925.S +++ b/arch/arm/mm/proc-arm925.S @@ -441,9 +441,6 @@ ENTRY(cpu_arm925_set_pte_ext) .type __arm925_setup, #function __arm925_setup: mov r0, #0 -#if defined(CONFIG_CPU_ICACHE_STREAMING_DISABLE) - orr r0,r0,#1 << 7 -#endif /* Transparent on, D-cache clean & flush mode. See NOTE2 above */ orr r0,r0,#1 << 1 @ transparent mode on
The block could never be compiled; CPU_ICACHE_STREAMING_DISABLE has not been defined in Kconfig since the very first Git commit. Hence, we can safely remove the entire block. Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> --- There is a similar looking option 'CPU_ICACHE_DISABLE'. However, I decided to remove the entire block since it could not be compiled for such a long time. I detected this issue with scripts/checkkconfigsymbols.py --- arch/arm/mm/proc-arm925.S | 3 --- 1 file changed, 3 deletions(-)