| Message ID | 1430490978-1091-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ian,
On Sat, May 2, 2015 at 12:36 AM, Ian Jackson <ian.jackson@eu.citrix.com> wrote:
> SATA controllers support SATA disks. The kernel should be able to
Do you mean SAS controllers?
Thanks,
Julian Calaby writes ("Re: [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default"):
> On Sat, May 2, 2015 at 12:36 AM, Ian Jackson <ian.jackson@eu.citrix.com> wrote:
> > SATA controllers support SATA disks. The kernel should be able to
>
> Do you mean SAS controllers?
Yes, sorry. Do you want me to resubmit with a fixed commit message ?
Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-05-01 at 15:36 +0100, Ian Jackson wrote: > SATA controllers support SATA disks. The kernel should be able to > drive these, by default. It should not silently (apart from a > debugging-only printk) ignore them. To be honest, this is a bit pointless: no distribution takes the kernel defaults anyway so changing it achieves nothing. The original thought behind doing this is that libata was huge and is pulled in by the sata code whether its actually used or not. Certain configurations might not want this. However, I think we can all agree that the major SAS user is enterprise and for them, kernel size isn't usually a huge worry. Even for enterprise, the predominant configuration seems to be SAS expanders with SATA drives, so they can't turn it off anyway. Therefore a more useful question might be: is it time to remove the option entirely? James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig index 9dafe64..16258b0 100644 --- a/drivers/scsi/libsas/Kconfig +++ b/drivers/scsi/libsas/Kconfig @@ -34,6 +34,7 @@ config SCSI_SAS_ATA bool "ATA support for libsas (requires libata)" depends on SCSI_SAS_LIBSAS depends on ATA = y || ATA = SCSI_SAS_LIBSAS + default y help Builds in ATA support into libsas. Will necessitate the loading of libata along with libsas.
SATA controllers support SATA disks. The kernel should be able to drive these, by default. It should not silently (apart from a debugging-only printk) ignore them. Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> CC: James Bottomley <James.Bottomley@suse.de> CC: Donald D Dugger <donald.d.dugger@intel.com> CC: Pawel Baldysiak <pawel.baldysiak@intel.com> CC: Lukasz Dorau <lukasz.dorau@intel.com> CC: Artur Paszkiewicz <artur.paszkiewicz@intel.com> CC: Ian Campbell <ian.campbell@citrix.com> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com> CC: David Vrabel <david.vrabel@citrix.com> --- drivers/scsi/libsas/Kconfig | 1 + 1 file changed, 1 insertion(+)