| Message ID | 1428079429-4252-6-git-send-email-b.zolnierkie@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>: > From: Thomas Abraham <thomas.ab@samsung.com> > > The new CPU clock type allows the use of generic CPUfreq driver. > Switch Exynos4210 to using generic cpufreq driver. > > Changes by Bartlomiej: > - removed non-Exynos4210 support for now > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Kukjin Kim <kgene.kim@samsung.com> > Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> I know this is an old patch, it looks good. Just a minor nit below. > --- > arch/arm/mach-exynos/exynos.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index bcde0dd..4e13de5 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -197,6 +197,25 @@ static void __init exynos_init_irq(void) > exynos_map_pmu(); > } > > +static const struct of_device_id exynos_cpufreq_matches[] = { > + { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, > + { /* sentinel */ } > +}; > + > +static void __init exynos_cpufreq_init(void) > +{ > + struct device_node *root = of_find_node_by_path("/"); > + const struct of_device_id *match; > + > + match = of_match_node(exynos_cpufreq_matches, root); > + if (!match) { > + platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); > + return; > + } > + > + platform_device_register_simple(match->data, -1, NULL, 0); How about something like: const char *cpufreq_dev)name = "exynos-cpufreq"; if (match) cpufreq_dev_name = match->data; platform_device_register_simple(cpufreq_dev_name -1, NULL, 0); Less returns and one call to platform_device_register_simple(). Best regards, Krzysztof > +} > + > static void __init exynos_dt_machine_init(void) > { > /* > @@ -218,7 +237,7 @@ static void __init exynos_dt_machine_init(void) > of_machine_is_compatible("samsung,exynos5250")) > platform_device_register(&exynos_cpuidle); > > - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); > + exynos_cpufreq_init(); > > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On 03-04-15, 18:43, Bartlomiej Zolnierkiewicz wrote: > From: Thomas Abraham <thomas.ab@samsung.com> > > The new CPU clock type allows the use of generic CPUfreq driver. > Switch Exynos4210 to using generic cpufreq driver. > > Changes by Bartlomiej: > - removed non-Exynos4210 support for now > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Kukjin Kim <kgene.kim@samsung.com> > Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > arch/arm/mach-exynos/exynos.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index bcde0dd..4e13de5 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -197,6 +197,25 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } +static const struct of_device_id exynos_cpufreq_matches[] = { + { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, + { /* sentinel */ } +}; + +static void __init exynos_cpufreq_init(void) +{ + struct device_node *root = of_find_node_by_path("/"); + const struct of_device_id *match; + + match = of_match_node(exynos_cpufreq_matches, root); + if (!match) { + platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); + return; + } + + platform_device_register_simple(match->data, -1, NULL, 0); +} + static void __init exynos_dt_machine_init(void) { /* @@ -218,7 +237,7 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(&exynos_cpuidle); - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); + exynos_cpufreq_init(); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); }