diff mbox

ASoC: fsl_ssi: No need call of_device_is_available()

Message ID 1431051856-22476-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit ff9174d57a8239c5a21d2a0c7e00dddd54953f6c
Headers show

Commit Message

Fabio Estevam May 8, 2015, 2:24 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

The comment and the call to of_device_is_available() are not really
needed.

It is the expected behaviour to probe only the ssi nodes that are
enabled in the device tree.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/fsl/fsl_ssi.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Timur Tabi May 8, 2015, 3:16 a.m. UTC | #1 
Fabio Estevam wrote:
> The comment and the call to of_device_is_available() are not really
> needed.
>
> It is the expected behaviour to probe only the ssi nodes that are
> enabled in the device tree.
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>

Acked-by: Timur Tabi <timur@tabi.org>
Mark Brown May 8, 2015, 11:05 a.m. UTC | #2 
On Thu, May 07, 2015 at 11:24:16PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The comment and the call to of_device_is_available() are not really
> needed.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 0d48804..c7647e0 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1292,13 +1292,6 @@  static int fsl_ssi_probe(struct platform_device *pdev)
 	void __iomem *iomem;
 	char name[64];
 
-	/* SSIs that are not connected on the board should have a
-	 *      status = "disabled"
-	 * property in their device tree nodes.
-	 */
-	if (!of_device_is_available(np))
-		return -ENODEV;
-
 	of_id = of_match_device(fsl_ssi_ids, &pdev->dev);
 	if (!of_id || !of_id->data)
 		return -EINVAL;