SMP not working on Odroid XU3

Commit Message

Peter Chubb May 14, 2015, 3:07 a.m. UTC

Hi,
	Is there any info on the web at present as to what's supposed
	to work and what doesn't in the upstream kernel?

	I'm currently seeing only two out of eight processors come up
	at boot time using the samsung-linux tree, both A7s.  All
	eight come up in HYP mode using the Hardkernel linux tree.

	There's one obvious error in arch/arm/mach-exynos/firmware.c -- the
	address in the samsung,secure-firmware node isn't saved
	anywhere or used anywhere.  Instead the SMC communication area
	is taken from the samsung,exynos4210-sysram-ns node.  But
	fixing that doesn't help.

	Here's how I `fixed' it, but there's something else wrong.

index 0c62156..1df5b5a 100644
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Krzysztof Kozlowski May 14, 2015, 4:50 a.m. UTC | #1

2015-05-14 12:07 GMT+09:00 Peter Chubb <[e-mail]>:
> Hi,
>         Is there any info on the web at present as to what's supposed
>         to work and what doesn't in the upstream kernel?

I think there isn't.

>         I'm currently seeing only two out of eight processors come up
>         at boot time using the samsung-linux tree, both A7s.  All
>         eight come up in HYP mode using the Hardkernel linux tree.

That is strange, I would expect the opposite - six out of eight should
come up on current next and mainline.

>
>         There's one obvious error in arch/arm/mach-exynos/firmware.c -- the
>         address in the samsung,secure-firmware node isn't saved
>         anywhere or used anywhere.  Instead the SMC communication area
>         is taken from the samsung,exynos4210-sysram-ns node.

exynos5420.dtsi and sysram-ns.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -31,10 +31,11 @@ 
        };
 
        firmware@02073000 {
-               compatible = "samsung,secure-firmware";
+               compatible = "samsung,exynos4210-sysram-ns", "samsung,secure-firmware";
                reg = <0x02073000 0x1000>;
        };
 

	
-- 
Dr Peter Chubb				        peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA