| Message ID | 1426671298-2012-1-git-send-email-r.schwebel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Liviu, On Wed, Mar 18, 2015 at 10:34:58AM +0100, Robert Schwebel wrote: > Without this property, we get this boot warning: > > "L2C: device tree omits to specify unified cache" > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + > 1 file changed, 1 insertion(+) > > Changes since v1: > * fix typo in patch description > > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca9.dts b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > index 23662b5..a411274 100644 > --- a/arch/arm/boot/dts/vexpress-v2p-ca9.dts > +++ b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > @@ -170,6 +170,7 @@ > compatible = "arm,pl310-cache"; > reg = <0x1e00a000 0x1000>; > interrupts = <0 43 4>; > + cache-unified; > cache-level = <2>; > arm,data-latency = <1 1 1>; > arm,tag-latency = <1 1 1>; > -- > 2.1.4 Gentle ping, this patch didn't make it into 4.1-rc1. rsc
On Wed, Apr 29, 2015 at 08:12:28PM +0100, Robert Schwebel wrote: > Hi Liviu, > > On Wed, Mar 18, 2015 at 10:34:58AM +0100, Robert Schwebel wrote: > > Without this property, we get this boot warning: > > > > "L2C: device tree omits to specify unified cache" > > > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > arch/arm/boot/dts/vexpress-v2p-ca9.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > Changes since v1: > > * fix typo in patch description > > > > diff --git a/arch/arm/boot/dts/vexpress-v2p-ca9.dts b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > > index 23662b5..a411274 100644 > > --- a/arch/arm/boot/dts/vexpress-v2p-ca9.dts > > +++ b/arch/arm/boot/dts/vexpress-v2p-ca9.dts > > @@ -170,6 +170,7 @@ > > compatible = "arm,pl310-cache"; > > reg = <0x1e00a000 0x1000>; > > interrupts = <0 43 4>; > > + cache-unified; > > cache-level = <2>; > > arm,data-latency = <1 1 1>; > > arm,tag-latency = <1 1 1>; > > -- > > 2.1.4 > > Gentle ping, this patch didn't make it into 4.1-rc1. Sorry Robert, this fell through the cracks. VExpress gets very few patches in general and we're new to this :( Arnd/Olof, can we add this and Sudeep's patch for Juno into one of the later 4.1-rc pull requests? Best regards, Liviu > > rsc > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
Hi Liviu, On Thu, Apr 30, 2015 at 12:08:53PM +0100, Liviu Dudau wrote: > Sorry Robert, this fell through the cracks. VExpress gets very few > patches in general and we're new to this :( Thanks for the help! I still see these errors with 4.1-rc1: [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e0000 [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e1000 [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog@100e5000 [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/sysctl@01000 [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/wdt@0f000 Do you have an idea what might go wrong? rsc
On Thu, Apr 30, 2015 at 02:30:11PM +0100, Robert Schwebel wrote: > Hi Liviu, > > On Thu, Apr 30, 2015 at 12:08:53PM +0100, Liviu Dudau wrote: > > Sorry Robert, this fell through the cracks. VExpress gets very few > > patches in general and we're new to this :( > > Thanks for the help! > > I still see these errors with 4.1-rc1: > > [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link > [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e0000 > [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e1000 > [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog@100e5000 > [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/sysctl@01000 > [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/wdt@0f000 > > Do you have an idea what might go wrong? No, not yet. I will give it a go on my TC2 board. Best regards, Liviu > > rsc > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >
On 30/04/15 14:30, Robert Schwebel wrote: > Hi Liviu, > > On Thu, Apr 30, 2015 at 12:08:53PM +0100, Liviu Dudau wrote: >> Sorry Robert, this fell through the cracks. VExpress gets very few >> patches in general and we're new to this :( > > Thanks for the help! > > I still see these errors with 4.1-rc1: > > [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link I see above errors even on my Vexpress TC2, but > [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e0000 > [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e1000 > [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog@100e5000 > [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/sysctl@01000 > [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/wdt@0f000 > .. not theses ones > Do you have an idea what might go wrong? > I will give it a spin on my CA9 coretile. Regards,Sudeep
On Thu, Apr 30, 2015 at 02:50:14PM +0100, Sudeep Holla wrote: > >[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > >[ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > >[ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > >[ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > >[ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > >[ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link > > I see above errors even on my Vexpress TC2, but > > >[ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e0000 > >[ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e1000 > >[ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog@100e5000 > >[ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/sysctl@01000 > >[ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/wdt@0f000 > > > .. not theses ones > > >Do you have an idea what might go wrong? > > > > I will give it a spin on my CA9 coretile. I'm testing on qemu (and not even the latest one), so this might be a reason. rsc
On 30/04/15 15:11, Robert Schwebel wrote: > On Thu, Apr 30, 2015 at 02:50:14PM +0100, Sudeep Holla wrote: >>> [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 >>> [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 >>> [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link >>> [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link >>> [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link >>> [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link >> >> I see above errors even on my Vexpress TC2, but >> >>> [ 0.426298] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e0000 >>> [ 0.426799] of_amba_device_create(): amba_device_add() failed (-19) for /memory-controller@100e1000 >>> [ 0.427099] of_amba_device_create(): amba_device_add() failed (-19) for /watchdog@100e5000 >>> [ 0.433206] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/sysctl@01000 >>> [ 0.438165] of_amba_device_create(): amba_device_add() failed (-19) for /smb/motherboard/iofpga@7,00000000/wdt@0f000 >>> >> .. not theses ones >> >>> Do you have an idea what might go wrong? >>> >> >> I will give it a spin on my CA9 coretile. > > I'm testing on qemu (and not even the latest one), so this might be a > reason. OK, I tried on my CA9 coretile and don't see these errors on it either. However the "... creating of_node link" is present on both and I will look at that issue. Regards, Sudeep
On 30/04/15 14:30, Robert Schwebel wrote: > Hi Liviu, > > On Thu, Apr 30, 2015 at 12:08:53PM +0100, Liviu Dudau wrote: >> Sorry Robert, this fell through the cracks. VExpress gets very few >> patches in general and we're new to this :( > > Thanks for the help! > > I still see these errors with 4.1-rc1: > > [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link OK, I was able to debug this, it boils down to initcall ordering. Both of_init where the firmware sysfs is initialized and vexpress_sysreg_init are at same core_initcall level. Needs some thinking and more time to fix this. Regards, Sudeep
Hi Sudeep, On Thu, Apr 30, 2015 at 06:45:10PM +0100, Sudeep Holla wrote: > >I still see these errors with 4.1-rc1: > > > >[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > >[ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > >[ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > >[ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > >[ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > >[ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link > > OK, I was able to debug this, it boils down to initcall ordering. > Both of_init where the firmware sysfs is initialized and > vexpress_sysreg_init are at same core_initcall level. Needs some > thinking and more time to fix this. Did you find out something in the meantime? I just tested 4.1-rc3 and the issues are still confirmed. Thanks, rsc
On 16/05/15 21:13, Robert Schwebel wrote: > Hi Sudeep, > > On Thu, Apr 30, 2015 at 06:45:10PM +0100, Sudeep Holla wrote: >>> I still see these errors with 4.1-rc1: >>> >>> [ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 >>> [ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 >>> [ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link >>> [ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link >>> [ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link >>> [ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link >> >> OK, I was able to debug this, it boils down to initcall ordering. >> Both of_init where the firmware sysfs is initialized and >> vexpress_sysreg_init are at same core_initcall level. Needs some >> thinking and more time to fix this. > > Did you find out something in the meantime? > I just tested 4.1-rc3 and the issues are still confirmed. > Ah sorry, forgot to include you or your Reported-by(will fix that if/when I have to repost a newer version) I posted the patch but not yet pulled in mainline yet [1] Regards, Sudeep [1] https://lkml.org/lkml/2015/5/14/360
Hi Sundeep, On Sat, May 16, 2015 at 10:13:01PM +0200, Robert Schwebel wrote: > On Thu, Apr 30, 2015 at 06:45:10PM +0100, Sudeep Holla wrote: > > >I still see these errors with 4.1-rc1: > > > > > >[ 0.000000] L2C: platform modifies aux control register: 0x02020000 -> 0x02420000 > > >[ 0.000000] L2C: DT/platform modifies aux control register: 0x02020000 -> 0x02420000 > > >[ 0.268626] platform 10000000.sysreg: Error -2 creating of_node link > > >[ 0.271997] platform basic-mmio-gpio.1.auto: Error -2 creating of_node link > > >[ 0.272266] platform basic-mmio-gpio.2.auto: Error -2 creating of_node link > > >[ 0.272681] platform basic-mmio-gpio.3.auto: Error -2 creating of_node link > > > > OK, I was able to debug this, it boils down to initcall ordering. > > Both of_init where the firmware sysfs is initialized and > > vexpress_sysreg_init are at same core_initcall level. Needs some > > thinking and more time to fix this. > > Did you find out something in the meantime? > I just tested 4.1-rc3 and the issues are still confirmed. Gentle ping ... rsc
On Thu, May 21, 2015 at 02:26:44PM +0200, Robert Schwebel wrote: > > Did you find out something in the meantime? > > I just tested 4.1-rc3 and the issues are still confirmed. > > Gentle ping ... Sorry, missed the other mail and found it in the mean time :) rsc
diff --git a/arch/arm/boot/dts/vexpress-v2p-ca9.dts b/arch/arm/boot/dts/vexpress-v2p-ca9.dts index 23662b5..a411274 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca9.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca9.dts @@ -170,6 +170,7 @@ compatible = "arm,pl310-cache"; reg = <0x1e00a000 0x1000>; interrupts = <0 43 4>; + cache-unified; cache-level = <2>; arm,data-latency = <1 1 1>; arm,tag-latency = <1 1 1>;