| Message ID | 1432192565-11811-1-git-send-email-liwang@ubuntukylin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 21, 2015 at 10:16 AM, Li Wang <liwang@ubuntukylin.com> wrote: > From: Min Chen <minchen@ubuntukylin.com> > > Signed-off-by: Min Chen <minchen@ubuntukylin.com> > Reviewed-by: Li Wang <liwang@ubuntukylin.com> > --- > doc/man/8/rbd.rst | 1 + > src/rbd.cc | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/doc/man/8/rbd.rst b/doc/man/8/rbd.rst > index 4552951..3fb747f 100644 > --- a/doc/man/8/rbd.rst > +++ b/doc/man/8/rbd.rst > @@ -430,6 +430,7 @@ the running kernel. > > * ro - Map the image read-only. Equivalent to --read-only. > > +* ro - Map the image with copy-on-read turned on. Need to change the name of the option, ro -> cor. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Updated at https://github.com/ceph/ceph/pull/4735, thanks for the comments On 2015/5/21 17:12, Ilya Dryomov wrote: > On Thu, May 21, 2015 at 10:16 AM, Li Wang <liwang@ubuntukylin.com> wrote: >> From: Min Chen <minchen@ubuntukylin.com> >> >> Signed-off-by: Min Chen <minchen@ubuntukylin.com> >> Reviewed-by: Li Wang <liwang@ubuntukylin.com> >> --- >> doc/man/8/rbd.rst | 1 + >> src/rbd.cc | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/doc/man/8/rbd.rst b/doc/man/8/rbd.rst >> index 4552951..3fb747f 100644 >> --- a/doc/man/8/rbd.rst >> +++ b/doc/man/8/rbd.rst >> @@ -430,6 +430,7 @@ the running kernel. >> >> * ro - Map the image read-only. Equivalent to --read-only. >> >> +* ro - Map the image with copy-on-read turned on. > > Need to change the name of the option, ro -> cor. > > Thanks, > > Ilya > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/doc/man/8/rbd.rst b/doc/man/8/rbd.rst index 4552951..3fb747f 100644 --- a/doc/man/8/rbd.rst +++ b/doc/man/8/rbd.rst @@ -430,6 +430,7 @@ the running kernel. * ro - Map the image read-only. Equivalent to --read-only. +* ro - Map the image with copy-on-read turned on. Examples ======== diff --git a/src/rbd.cc b/src/rbd.cc index 4355c4f..fdc35ba 100644 --- a/src/rbd.cc +++ b/src/rbd.cc @@ -2545,6 +2545,8 @@ static int parse_map_options(char *options) return 1; } else if (!strcmp(this_char, "rw") || !strcmp(this_char, "ro")) { put_map_option("rw", this_char); + } else if (!strcmp(this_char, "cor")) { + put_map_option("cor", this_char); } else { cerr << "rbd: unknown map option '" << this_char << "'" << std::endl; return 1;