| Message ID | 1432216352-8016-1-git-send-email-hanjun.guo@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: > list_head "list" in struct acpi_prt_entry was used to connect > _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: > Don't cache _PRT, and don't associate them with bus numbers), > the list head for _PRT entries was removed, but left "list" in > struct acpi_prt_entry which is useless and stale, remove it now. Please use the canonical commit reference format, i.e., 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them with bus numbers") > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > CC: Yinghai Lu <yinghai@kernel.org> > CC: Yijing Wang <wangyijing@huawei.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/acpi/pci_irq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c > index b1def41..03e4b6c 100644 > --- a/drivers/acpi/pci_irq.c > +++ b/drivers/acpi/pci_irq.c > @@ -44,7 +44,6 @@ > ACPI_MODULE_NAME("pci_irq"); > > struct acpi_prt_entry { > - struct list_head list; > struct acpi_pci_id id; > u8 pin; > acpi_handle link; > -- > 1.7.12.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015?05?21? 23:10, Bjorn Helgaas wrote: > On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >> list_head "list" in struct acpi_prt_entry was used to connect >> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: >> Don't cache _PRT, and don't associate them with bus numbers), >> the list head for _PRT entries was removed, but left "list" in >> struct acpi_prt_entry which is useless and stale, remove it now. > > Please use the canonical commit reference format, i.e., > > 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them > with bus numbers") OK, now I know what is a canonical commit reference format :) > >> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> >> CC: Yinghai Lu <yinghai@kernel.org> >> CC: Yijing Wang <wangyijing@huawei.com> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> Thanks, will update the change log soon. Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: > On 2015?05?21? 23:10, Bjorn Helgaas wrote: >> >> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >>> >>> list_head "list" in struct acpi_prt_entry was used to connect >>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: >>> Don't cache _PRT, and don't associate them with bus numbers), >>> the list head for _PRT entries was removed, but left "list" in >>> struct acpi_prt_entry which is useless and stale, remove it now. >> >> >> Please use the canonical commit reference format, i.e., >> >> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them >> with bus numbers") > > > OK, now I know what is a canonical commit reference format :) Yeah, it'd be nice if that were better documented. checkpatch complains about it (d311cd44545f ("checkpatch: add test for commit id formatting style in commit log")), but unfortunately I don't think it's mentioned anywhere in Documentation/ Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 21, 2015 at 10:21 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >> On 2015?05?21? 23:10, Bjorn Helgaas wrote: >>> >>> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >>>> >>>> list_head "list" in struct acpi_prt_entry was used to connect >>>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: >>>> Don't cache _PRT, and don't associate them with bus numbers), >>>> the list head for _PRT entries was removed, but left "list" in >>>> struct acpi_prt_entry which is useless and stale, remove it now. >>> >>> >>> Please use the canonical commit reference format, i.e., >>> >>> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them >>> with bus numbers") >> >> >> OK, now I know what is a canonical commit reference format :) > > Yeah, it'd be nice if that were better documented. checkpatch > complains about it (d311cd44545f ("checkpatch: add test for commit id > formatting style in commit log")), but unfortunately I don't think > it's mentioned anywhere in Documentation/ I guess it actually *is* mentioned: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n171, but it's a little bit wishy-washy. I'll propose a tweak. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015?05?21? 23:53, Bjorn Helgaas wrote: > On Thu, May 21, 2015 at 10:21 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >>> On 2015?05?21? 23:10, Bjorn Helgaas wrote: >>>> >>>> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >>>>> >>>>> list_head "list" in struct acpi_prt_entry was used to connect >>>>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: >>>>> Don't cache _PRT, and don't associate them with bus numbers), >>>>> the list head for _PRT entries was removed, but left "list" in >>>>> struct acpi_prt_entry which is useless and stale, remove it now. >>>> >>>> >>>> Please use the canonical commit reference format, i.e., >>>> >>>> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them >>>> with bus numbers") >>> >>> >>> OK, now I know what is a canonical commit reference format :) >> >> Yeah, it'd be nice if that were better documented. checkpatch >> complains about it (d311cd44545f ("checkpatch: add test for commit id >> formatting style in commit log")), but unfortunately I don't think >> it's mentioned anywhere in Documentation/ > > I guess it actually *is* mentioned: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n171, > but it's a little bit wishy-washy. I'll propose a tweak. Thanks for the guidance :) Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c index b1def41..03e4b6c 100644 --- a/drivers/acpi/pci_irq.c +++ b/drivers/acpi/pci_irq.c @@ -44,7 +44,6 @@ ACPI_MODULE_NAME("pci_irq"); struct acpi_prt_entry { - struct list_head list; struct acpi_pci_id id; u8 pin; acpi_handle link;
list_head "list" in struct acpi_prt_entry was used to connect _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: Don't cache _PRT, and don't associate them with bus numbers), the list head for _PRT entries was removed, but left "list" in struct acpi_prt_entry which is useless and stale, remove it now. Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> CC: Yinghai Lu <yinghai@kernel.org> CC: Yijing Wang <wangyijing@huawei.com> --- drivers/acpi/pci_irq.c | 1 - 1 file changed, 1 deletion(-)