| Message ID | CAOhdH0uf7Kj2noz4vnuLo_06W2HZ4Xwh_Bm5vKC71VHfeswD_Q@mail.gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
Fredrik Fornwall <fredrik@fornwall.net> wrote: > In mkbuiltins LC_COLLATE is set, but since "The value of the LC_ALL > environment variable has precedence over any of the other environment > variables starting with LC_" > (http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html), this > has no effect when LC_ALL is set. > > This breaks when having e.g. LC_ALL=en_US.UTF-8 during make, which > causes the test case > dash -c : > to fail, probably due to broken ordering in builtins.c. The patch > corrects that by setting LC_ALL instead of LC_COLLATE. This causes any errors printed by sort to come out in English. Please fix this by simply setting LC_ALL to empty alongside LC_COLLATE=C. Thanks,
On 05/21/2015 10:25 PM, Herbert Xu wrote: > Fredrik Fornwall <fredrik@fornwall.net> wrote: >> In mkbuiltins LC_COLLATE is set, but since "The value of the LC_ALL >> environment variable has precedence over any of the other environment >> variables starting with LC_" >> (http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html), this >> has no effect when LC_ALL is set. >> >> This breaks when having e.g. LC_ALL=en_US.UTF-8 during make, which >> causes the test case >> dash -c : >> to fail, probably due to broken ordering in builtins.c. The patch >> corrects that by setting LC_ALL instead of LC_COLLATE. > > This causes any errors printed by sort to come out in English. Why do you care whether any errors printed by sort are in the "C" locale (in English) rather than localized? Ideally, there won't be any sort errors in the first place, because this tool is run on controlled input as part of the build process. > > Please fix this by simply setting LC_ALL to empty alongside > LC_COLLATE=C. Setting LC_ALL has the nice property that LC_COLLATE and LC_CTYPE are guaranteed to be compatible; if you just set LC_COLLATE but leave LC_CTYPE unchanged and unset LC_ALL, it is possible to attempt a collation that assumes one character set while still living in a ctype that assumes another, and get garbled results.
On Thu, May 21, 2015 at 10:40:19PM -0600, Eric Blake wrote: > > Why do you care whether any errors printed by sort are in the "C" locale > (in English) rather than localized? Ideally, there won't be any sort > errors in the first place, because this tool is run on controlled input > as part of the build process. Your /tmp could be full or sort could be out of memory. > Setting LC_ALL has the nice property that LC_COLLATE and LC_CTYPE are > guaranteed to be compatible; if you just set LC_COLLATE but leave > LC_CTYPE unchanged and unset LC_ALL, it is possible to attempt a > collation that assumes one character set while still living in a ctype > that assumes another, and get garbled results. Show me an actual pair of values for these two that produce incorrect results for mkbuiltins and I'll happily change both. Cheers,
On 05/21/2015 10:45 PM, Herbert Xu wrote: >> Setting LC_ALL has the nice property that LC_COLLATE and LC_CTYPE are >> guaranteed to be compatible; if you just set LC_COLLATE but leave >> LC_CTYPE unchanged and unset LC_ALL, it is possible to attempt a >> collation that assumes one character set while still living in a ctype >> that assumes another, and get garbled results. > > Show me an actual pair of values for these two that produce > incorrect results for mkbuiltins and I'll happily change both. 'sort -b' uses isspace() to determine which characters to strip. There are locales with a larger set of characters where isspace() returns true than for the LC_CTYPE=C locale. Suppose that I can find a single-byte locale where isblank('\xff') is true. If that is the case, then the input '\xffa\nb\n' will sort differently for 'LC_ALL=C sort -b' (output 'b\n'\xffa\n') than for 'LANG=C LC_CTYPE=$locale' (output '\xffa\nb\n') because the change in CTYPE changes whether the \xff is ignored as a blank or included as part of the name being sorted. However, the man pages for 'locale(1)' and 'localedef(1)' did not make it obvious for me how to perform a search that would easily find such a locale, so I'm open to suggestions on how to prove my point via more than just analysis. And there's still the point that mkbuiltins is being run on controlled input, where you are sticking only to a subset of characters that happen to be portable (that is, you are unlikely to be tripped up by a locale where \xff is a blank, since you are not using \xff in your input).
diff -u -r ../dash-0.5.8/src/mkbuiltins ./src/mkbuiltins --- ../dash-0.5.8/src/mkbuiltins 2014-09-28 04:19:32.000000000 -0400 +++ ./src/mkbuiltins 2015-05-17 19:08:00.076452891 -0400 @@ -78,7 +78,7 @@ if ($i ~ /^-/) line = $(++i) "\t" line print line - }}' $temp | LC_COLLATE=C sort -k 1,1 | tee $temp2 | awk '{ + }}' $temp | LC_ALL=C sort -k 1,1 | tee $temp2 | awk '{ opt = "" if (NF > 2) { opt = substr($2, 2) @@ -97,7 +97,7 @@ */ ! -sed 's/ -[a-z]*//' $temp2 | nl -b a -v 0 | LC_COLLATE=C sort -u -k 3,3 | +sed 's/ -[a-z]*//' $temp2 | nl -b a -v 0 | LC_ALL=C sort -u -k 3,3 | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ | awk '{ printf "#define %s (builtincmd + %d)\n", $3, $1}' printf '\n#define NUMBUILTINS %d\n' $(wc -l < $temp2)
In mkbuiltins LC_COLLATE is set, but since "The value of the LC_ALL environment variable has precedence over any of the other environment variables starting with LC_" (http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html), this has no effect when LC_ALL is set. This breaks when having e.g. LC_ALL=en_US.UTF-8 during make, which causes the test case dash -c : to fail, probably due to broken ordering in builtins.c. The patch corrects that by setting LC_ALL instead of LC_COLLATE. Fredrik $ diff -u -r ../dash-0.5.8/ . -- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html