| Message ID | 1431736512-23161-2-git-send-email-terry.junge@plantronics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Fri, 15 May 2015, Terry Junge wrote: > Althought the general rule of thumb is to not add any new default-to-on > options for things that are not crucial core infrastructure of the kernel, > the hid-plantronics driver prevents hid-input from mapping unknown > Plantronics vendor unique usages to random mouse events. > > The result of this default mapping of unknown usages is that unexpected > mouse or touchpad events can occur or be blocked when buttons are pressed > on some Plantronics devices. Having this driver available as a module > will prevent this core mapping. Still, can only happen on system with the particular device connected. Therefore it's expected that the kernel will have support for that device built-in. We're not putting 'default y' in kernel for non-core drivers. Thanks,
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index cc4c664..6bfcafb 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -632,6 +632,7 @@ config HID_PICOLCD_CIR config HID_PLANTRONICS tristate "Plantronics USB HID Driver" + default m depends on HID ---help--- Provides HID support for Plantronics USB audio devices.
Althought the general rule of thumb is to not add any new default-to-on options for things that are not crucial core infrastructure of the kernel, the hid-plantronics driver prevents hid-input from mapping unknown Plantronics vendor unique usages to random mouse events. The result of this default mapping of unknown usages is that unexpected mouse or touchpad events can occur or be blocked when buttons are pressed on some Plantronics devices. Having this driver available as a module will prevent this core mapping. Patched against git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git with part 1 of this patch set applied. Signed-off-by: Terry Junge <terry.junge@plantronics.com> --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 1.9.1