| Message ID | 1430296712-10287-4-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze: > Add SROM device node for exynos4. Subject prefix: "ARM: dts:" > > CC: Rob Herring <robh+dt@kernel.org> > CC: Mark Rutland <mark.rutland@arm.com> > CC: Ian Campbell <ijc+devicetree@hellion.org.uk> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 77ea547..48490ea 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -76,6 +76,11 @@ > reg = <0x10000000 0x100>; > }; > > + sromc@12570000 { > + compatible = "samsung,exynos-srom"; > + reg = <0x12570000 0x100>; There are 5 registers, so size of 0x100 seems to be bigger than needed. Maybe limit it to actual length? Best regards, Krzysztof
Hi, On Wednesday 27 May 2015 05:32 PM, Krzysztof Kozlowski wrote: > W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze: >> Add SROM device node for exynos4. > > Subject prefix: "ARM: dts:" > Ok. >> >> CC: Rob Herring <robh+dt@kernel.org> >> CC: Mark Rutland <mark.rutland@arm.com> >> CC: Ian Campbell <ijc+devicetree@hellion.org.uk> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 77ea547..48490ea 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -76,6 +76,11 @@ >> reg = <0x10000000 0x100>; >> }; >> >> + sromc@12570000 { >> + compatible = "samsung,exynos-srom"; >> + reg = <0x12570000 0x100>; > > There are 5 registers, so size of 0x100 seems to be bigger than needed. > Maybe limit it to actual length? > Yes, we do not need size of 0x100. Will take care in next version. Thanks, Pankaj Dubey > Best regards, > Krzysztof >
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 77ea547..48490ea 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -76,6 +76,11 @@ reg = <0x10000000 0x100>; }; + sromc@12570000 { + compatible = "samsung,exynos-srom"; + reg = <0x12570000 0x100>; + }; + mipi_phy: video-phy@10020710 { compatible = "samsung,s5pv210-mipi-video-phy"; reg = <0x10020710 8>;
Add SROM device node for exynos4. CC: Rob Herring <robh+dt@kernel.org> CC: Mark Rutland <mark.rutland@arm.com> CC: Ian Campbell <ijc+devicetree@hellion.org.uk> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 5 +++++ 1 file changed, 5 insertions(+)