diff mbox

[4/6] ARM: dts; pxa: add embedded pxa camera capture interface

Message ID 1433624953-28165-4-git-send-email-robert.jarzmik@free.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Jarzmik June 6, 2015, 9:09 p.m. UTC
The pxa27x SoCs have an embedded camera host controller. Add the
description to the family description.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Sergei Shtylyov June 6, 2015, 10:07 p.m. UTC | #1
Hello.

On 06/07/2015 12:09 AM, Robert Jarzmik wrote:

> The pxa27x SoCs have an embedded camera host controller. Add the
> description to the family description.

> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>   arch/arm/boot/dts/pxa27x.dtsi | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)

> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
> index 506db86..9ebfd7f 100644
> --- a/arch/arm/boot/dts/pxa27x.dtsi
> +++ b/arch/arm/boot/dts/pxa27x.dtsi
> @@ -77,6 +77,23 @@
>   			clocks = <&clks CLK_KEYPAD>;
>   			status = "disabled";
>   		};
> +
> +		pxa_camera: pxa_camera@50000000 {

    The ePAPR standard has something to say about the node naming:
"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model." So I'd suggest "video@50000000" 
instead...

[...]

WBR, Sergei
Robert Jarzmik June 8, 2015, 5:23 p.m. UTC | #2
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:

>> +		pxa_camera: pxa_camera@50000000 {
>
>    The ePAPR standard has something to say about the node naming:
> "The name of a node should be somewhat generic, reflecting the function of the
> device and not its precise programming model." So I'd suggest "video@50000000"
> instead...
Okay, I understand. As "video" could stand for a video decoder/encoder, or the
display device, I'd rather go for "imaging" or "camera-host", or something like
that if I find an already used named in other dts files.

Cheers.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
index 506db86..9ebfd7f 100644
--- a/arch/arm/boot/dts/pxa27x.dtsi
+++ b/arch/arm/boot/dts/pxa27x.dtsi
@@ -77,6 +77,23 @@ 
 			clocks = <&clks CLK_KEYPAD>;
 			status = "disabled";
 		};
+
+		pxa_camera: pxa_camera@50000000 {
+			compatible = "marvell,pxa270-qci";
+			reg = <0x50000000 0x1000>;
+			interrupts = <33>;
+			dmas = <&pdma 68 0	/* Y channel */
+				&pdma 69 0	/* U channel */
+				&pdma 70 0>;	/* V channel */
+			dma-names = "CI_Y", "CI_U", "CI_V";
+
+			clocks = <&clks CLK_CAMERA>;
+			clock-names = "ciclk";
+			clock-frequency = <5000000>;
+			clock-output-names = "qci_mclk";
+
+			status = "disabled";
+		};
 	};
 
 	clocks {