| Message ID | 1433865223-15310-1-git-send-email-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>-----Original Message----- >From: Colin King [mailto:colin.king@canonical.com] >Sent: Tuesday, June 09, 2015 9:24 PM >To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley; >megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org >Cc: linux-kernel@vger.kernel.org >Subject: [PATCH] megaraid_sas: insert missing space in kernel message > >From: Colin Ian King <colin.king@canonical.com> > >The printk format specifier string is missing a space between the %p format >specifier and the "on the defer" text. Minor fix, add the missing space. > >Signed-off-by: Colin Ian King <colin.king@canonical.com> >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index 890637f..4889ef6 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct >megasas_instance *instance) > cmd = instance->cmd_list[i]; > if (cmd->sync_cmd == 1 || cmd->scmd) { > printk(KERN_NOTICE "megasas: moving >cmd[%d]:%p:%d:%p" >- "on the defer queue as internal\n", >+ " on the defer queue as internal\n", > defer_index, cmd, cmd->sync_cmd, cmd- >>scmd); > > if (!list_empty(&cmd->list)) { Acked-by: Sumit Saxena <sumit.saxena@avagotech.com> >-- >2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 09, 2015 at 04:53:43PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The printk format specifier string is missing a space between > the %p format specifier and the "on the defer" text. Minor fix, > add the missing space. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 890637f..4889ef6 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) > cmd = instance->cmd_list[i]; > if (cmd->sync_cmd == 1 || cmd->scmd) { > printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p" > - "on the defer queue as internal\n", > + " on the defer queue as internal\n", > defer_index, cmd, cmd->sync_cmd, cmd->scmd); > > if (!list_empty(&cmd->list)) { > -- > 2.1.4 > Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 890637f..4889ef6 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) cmd = instance->cmd_list[i]; if (cmd->sync_cmd == 1 || cmd->scmd) { printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p" - "on the defer queue as internal\n", + " on the defer queue as internal\n", defer_index, cmd, cmd->sync_cmd, cmd->scmd); if (!list_empty(&cmd->list)) {