diff mbox

[v2,1/3] drm/exynos: remove to call mixer_wait_for_vblank

Message ID 1434097636-10709-1-git-send-email-jy0922.shim@samsung.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Joonyoung Shim June 12, 2015, 8:27 a.m. UTC
The reason waiting vblank is to be power gated and disabled clocks after
dma operation is completed. The dma operation is stopped already before
be power gated and clocks are disabled when mixer is disabled by commit
381be025ac1a6("drm/exynos: stop mixer before gating clocks during
poweroff"). Don't need to wait vblank anymore.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_mixer.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Gustavo Padovan June 15, 2015, 8:39 p.m. UTC | #1
Hi Joonyoung,

2015-06-12 Joonyoung Shim <jy0922.shim@samsung.com>:

> The reason waiting vblank is to be power gated and disabled clocks after
> dma operation is completed. The dma operation is stopped already before
> be power gated and clocks are disabled when mixer is disabled by commit
> 381be025ac1a6("drm/exynos: stop mixer before gating clocks during
> poweroff"). Don't need to wait vblank anymore.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index 6bab717..f93f038 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -1010,7 +1010,6 @@  static void mixer_window_suspend(struct mixer_context *ctx)
 		plane->resume = plane->enabled;
 		mixer_win_disable(ctx->crtc, i);
 	}
-	mixer_wait_for_vblank(ctx->crtc);
 }
 
 static void mixer_window_resume(struct mixer_context *ctx)