diff mbox

wireless: Add ifname to STOP_AP event.

Message ID 1433974625-327-1-git-send-email-greearb@candelatech.com (mailing list archive)
State Changes Requested
Delegated to: Johannes Berg
Headers show

Commit Message

Ben Greear June 10, 2015, 10:17 p.m. UTC 
From: Ben Greear <greearb@candelatech.com>

In case user-space wants to know the name of the
device, this will save a name lookup by index, and
in case where kernel manages to fully delete the
interface before user-space can determine the name,
this will ensure user-space has proper name.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 net/wireless/nl80211.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Johannes Berg June 17, 2015, 9:14 a.m. UTC | #1 
On Wed, 2015-06-10 at 15:17 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> In case user-space wants to know the name of the
> device, this will save a name lookup by index, and
> in case where kernel manages to fully delete the
> interface before user-space can determine the name,
> this will ensure user-space has proper name.

None of this reasoning is specific to the STOP_AP event, and I'd hate us
adding it one by one...

I still think there isn't all that much reason to have it (if userspace
really needs the names so badly it could also subscribe to the rtnetlink
and keep a table of index/names!), but I could get behind a refactoring
of all these places (I count at least 10 events that include the wdev
id) to combine the four lines in the patch below into a single helper.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 736c474..ba73def 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -12992,6 +12992,7 @@  void nl80211_send_ap_stopped(struct wireless_dev *wdev)
 		goto out;
 
 	if (nla_put_u32(msg, NL80211_ATTR_WIPHY, rdev->wiphy_idx) ||
+	    nla_put_string(msg, NL80211_ATTR_IFNAME, wdev->netdev->name) ||
 	    nla_put_u32(msg, NL80211_ATTR_IFINDEX, wdev->netdev->ifindex) ||
 	    nla_put_u64(msg, NL80211_ATTR_WDEV, wdev_id(wdev)))
 		goto out;