[4/6] ARM: dts: Exynos4210: add CPU OPP and regulator supply property

Commit Message

Bartlomiej Zolnierkiewicz April 3, 2015, 4:43 p.m. UTC

From: Thomas Abraham <[e-mail]>

For Exynos4210 platforms, add CPU operating points and CPU
regulator supply properties for migrating from Exynos specific
cpufreq driver to using generic cpufreq driver.

Changes by Bartlomiej:
- removed Exynos5250 and Exynos5420 support for now

Cc: Kukjin Kim <[e-mail]>
Cc: Doug Anderson <[e-mail]>
Cc: Javier Martinez Canillas <[e-mail]>
Cc: Andreas Faerber <[e-mail]>
Cc: Sachin Kamat <[e-mail]>
Cc: Andreas Farber <[e-mail]>
Cc: Javier Martinez Canillas <[e-mail]>
Signed-off-by: Thomas Abraham <[e-mail]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
---
 arch/arm/boot/dts/exynos4210-origen.dts         |    4 ++++
 arch/arm/boot/dts/exynos4210-trats.dts          |    4 ++++
 arch/arm/boot/dts/exynos4210-universal_c210.dts |    4 ++++
 arch/arm/boot/dts/exynos4210.dtsi               |   12 ++++++++++++
 4 files changed, 24 insertions(+)

Comments

Krzysztof Kozlowski May 8, 2015, 12:18 a.m. UTC | #1

2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> From: Thomas Abraham <[e-mail]>
>
> For Exynos4210 platforms, add CPU operating points and CPU
> regulator supply properties for migrating from Exynos specific
> cpufreq driver to using generic cpufreq driver.
>
> Changes by Bartlomiej:
> - removed Exynos5250 and Exynos5420 support for now
>
> Cc: Kukjin Kim <[e-mail]>
> Cc: Doug Anderson <[e-mail]>
> Cc: Javier Martinez Canillas <[e-mail]>
> Cc: Andreas Faerber <[e-mail]>
> Cc: Sachin Kamat <[e-mail]>
> Cc: Andreas Farber <[e-mail]>
> Cc: Javier Martinez Canillas <[e-mail]>
> Signed-off-by: Thomas Abraham <[e-mail]>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>

Acked-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Krzysztof Kozlowski June 22, 2015, 12:31 a.m. UTC | #2

2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>> From: Thomas Abraham <[e-mail]>
>>
>> For Exynos4210 platforms, add CPU operating points and CPU
>> regulator supply properties for migrating from Exynos specific
>> cpufreq driver to using generic cpufreq driver.
>>
>> Changes by Bartlomiej:
>> - removed Exynos5250 and Exynos5420 support for now
>>
>> Cc: Kukjin Kim <[e-mail]>
>> Cc: Doug Anderson <[e-mail]>
>> Cc: Javier Martinez Canillas <[e-mail]>
>> Cc: Andreas Faerber <[e-mail]>
>> Cc: Sachin Kamat <[e-mail]>
>> Cc: Andreas Farber <[e-mail]>
>> Cc: Javier Martinez Canillas <[e-mail]>
>> Signed-off-by: Thomas Abraham <[e-mail]>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>
> Acked-by: Krzysztof Kozlowski <[e-mail]>

Rebased and applied to my tree, I'll sent it later to Kukjin unless he
picks it by himself from LKML.

Best regards,
Krzysztof

[e-mail] June 22, 2015, 1:38 a.m. UTC | #3

Krzysztof Kozlowski wrote:
> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> > 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >> From: Thomas Abraham <[e-mail]>
> >>
> >> For Exynos4210 platforms, add CPU operating points and CPU
> >> regulator supply properties for migrating from Exynos specific
> >> cpufreq driver to using generic cpufreq driver.
> >>
> >> Changes by Bartlomiej:
> >> - removed Exynos5250 and Exynos5420 support for now
> >>
> >> Cc: Kukjin Kim <[e-mail]>
> >> Cc: Doug Anderson <[e-mail]>
> >> Cc: Javier Martinez Canillas <[e-mail]>
> >> Cc: Andreas Faerber <[e-mail]>
> >> Cc: Sachin Kamat <[e-mail]>
> >> Cc: Andreas Farber <[e-mail]>
> >> Cc: Javier Martinez Canillas <[e-mail]>
> >> Signed-off-by: Thomas Abraham <[e-mail]>
> >> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> >
> > Acked-by: Krzysztof Kozlowski <[e-mail]>
> 
> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> picks it by himself from LKML.
> 
Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
v4.2-rc1 after v4.2-rc1 release.

Thanks,
Kukjin

Krzysztof Kozlowski June 22, 2015, 1:42 a.m. UTC | #4

On 22.06.2015 10:38, Kukjin Kim wrote:
> Krzysztof Kozlowski wrote:
>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>>>> From: Thomas Abraham <[e-mail]>
>>>>
>>>> For Exynos4210 platforms, add CPU operating points and CPU
>>>> regulator supply properties for migrating from Exynos specific
>>>> cpufreq driver to using generic cpufreq driver.
>>>>
>>>> Changes by Bartlomiej:
>>>> - removed Exynos5250 and Exynos5420 support for now
>>>>
>>>> Cc: Kukjin Kim <[e-mail]>
>>>> Cc: Doug Anderson <[e-mail]>
>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>> Cc: Andreas Faerber <[e-mail]>
>>>> Cc: Sachin Kamat <[e-mail]>
>>>> Cc: Andreas Farber <[e-mail]>
>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>>>
>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>>
>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>> picks it by himself from LKML.
>>
> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> v4.2-rc1 after v4.2-rc1 release.

You mean it is for v4.3, not v4.2?

Best regards,
Krzysztof

[e-mail] June 22, 2015, 1:46 a.m. UTC | #5

Krzysztof Kozlowski wrote:
> 
> On 22.06.2015 10:38, Kukjin Kim wrote:
> > Krzysztof Kozlowski wrote:
> >> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> >>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >>>> From: Thomas Abraham <[e-mail]>
> >>>>
> >>>> For Exynos4210 platforms, add CPU operating points and CPU
> >>>> regulator supply properties for migrating from Exynos specific
> >>>> cpufreq driver to using generic cpufreq driver.
> >>>>
> >>>> Changes by Bartlomiej:
> >>>> - removed Exynos5250 and Exynos5420 support for now
> >>>>
> >>>> Cc: Kukjin Kim <[e-mail]>
> >>>> Cc: Doug Anderson <[e-mail]>
> >>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>> Cc: Andreas Faerber <[e-mail]>
> >>>> Cc: Sachin Kamat <[e-mail]>
> >>>> Cc: Andreas Farber <[e-mail]>
> >>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>> Signed-off-by: Thomas Abraham <[e-mail]>
> >>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> >>>
> >>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> >>
> >> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> >> picks it by himself from LKML.
> >>
> > Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> > v4.2-rc1 after v4.2-rc1 release.
> 
> You mean it is for v4.3, not v4.2?
> 
Oops, yes v4.3.

Thanks for the correction.
Kukjin

Michael Turquette June 22, 2015, 3:04 p.m. UTC | #6

Quoting Kukjin Kim (2015-06-21 18:46:26)
> Krzysztof Kozlowski wrote:
> > 
> > On 22.06.2015 10:38, Kukjin Kim wrote:
> > > Krzysztof Kozlowski wrote:
> > >> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> > >>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> > >>>> From: Thomas Abraham <[e-mail]>
> > >>>>
> > >>>> For Exynos4210 platforms, add CPU operating points and CPU
> > >>>> regulator supply properties for migrating from Exynos specific
> > >>>> cpufreq driver to using generic cpufreq driver.
> > >>>>
> > >>>> Changes by Bartlomiej:
> > >>>> - removed Exynos5250 and Exynos5420 support for now
> > >>>>
> > >>>> Cc: Kukjin Kim <[e-mail]>
> > >>>> Cc: Doug Anderson <[e-mail]>
> > >>>> Cc: Javier Martinez Canillas <[e-mail]>
> > >>>> Cc: Andreas Faerber <[e-mail]>
> > >>>> Cc: Sachin Kamat <[e-mail]>
> > >>>> Cc: Andreas Farber <[e-mail]>
> > >>>> Cc: Javier Martinez Canillas <[e-mail]>
> > >>>> Signed-off-by: Thomas Abraham <[e-mail]>
> > >>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> > >>>
> > >>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> > >>
> > >> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> > >> picks it by himself from LKML.
> > >>
> > > Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> > > v4.2-rc1 after v4.2-rc1 release.
> > 
> > You mean it is for v4.3, not v4.2?
> > 
> Oops, yes v4.3.
> 
> Thanks for the correction.

Kukjin & Krzysztof,

I'm confused on this point. I was planning to take patches 1, 2, 3, 5
and 6 towards 4.2 (e.g. in the pull request that I'll send out this
week).

Is patch 4 going out for 4.2 or 4.3?

Regards,
Mike

> Kukjin
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> Please read the FAQ at  http://www.tux.org/lkml/

Krzysztof Kozlowski June 22, 2015, 11:46 p.m. UTC | #7

On 23.06.2015 00:04, Michael Turquette wrote:
> Quoting Kukjin Kim (2015-06-21 18:46:26)
>> Krzysztof Kozlowski wrote:
>>>
>>> On 22.06.2015 10:38, Kukjin Kim wrote:
>>>> Krzysztof Kozlowski wrote:
>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>>>>>>> From: Thomas Abraham <[e-mail]>
>>>>>>>
>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
>>>>>>> regulator supply properties for migrating from Exynos specific
>>>>>>> cpufreq driver to using generic cpufreq driver.
>>>>>>>
>>>>>>> Changes by Bartlomiej:
>>>>>>> - removed Exynos5250 and Exynos5420 support for now
>>>>>>>
>>>>>>> Cc: Kukjin Kim <[e-mail]>
>>>>>>> Cc: Doug Anderson <[e-mail]>
>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>> Cc: Andreas Faerber <[e-mail]>
>>>>>>> Cc: Sachin Kamat <[e-mail]>
>>>>>>> Cc: Andreas Farber <[e-mail]>
>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>>>>>>
>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>>>>>
>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>>>>> picks it by himself from LKML.
>>>>>
>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
>>>> v4.2-rc1 after v4.2-rc1 release.
>>>
>>> You mean it is for v4.3, not v4.2?
>>>
>> Oops, yes v4.3.
>>
>> Thanks for the correction.
> 
> Kukjin & Krzysztof,
> 
> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
> week).
> 
> Is patch 4 going out for 4.2 or 4.3?

It is quite late for sending pull request to arm-soc for 4.2.
For example SoCFPGA pull request from last week was rejected:
http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980

If you want to take it for 4.2 then I am fine with it but this will
cause some easy but annoying conflicts. There aren't difficult - just
most of nodes in board DTS changed their place.

Example of resolution (target file after merge, with cpu nodes reordered
alphabetically):
https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd

Best regards,
Krzysztof

Krzysztof Kozlowski June 23, 2015, 12:24 a.m. UTC | #8

On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
> On 23.06.2015 00:04, Michael Turquette wrote:
>> Quoting Kukjin Kim (2015-06-21 18:46:26)
>>> Krzysztof Kozlowski wrote:
>>>>
>>>> On 22.06.2015 10:38, Kukjin Kim wrote:
>>>>> Krzysztof Kozlowski wrote:
>>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>>>>>>>> From: Thomas Abraham <[e-mail]>
>>>>>>>>
>>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
>>>>>>>> regulator supply properties for migrating from Exynos specific
>>>>>>>> cpufreq driver to using generic cpufreq driver.
>>>>>>>>
>>>>>>>> Changes by Bartlomiej:
>>>>>>>> - removed Exynos5250 and Exynos5420 support for now
>>>>>>>>
>>>>>>>> Cc: Kukjin Kim <[e-mail]>
>>>>>>>> Cc: Doug Anderson <[e-mail]>
>>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>>> Cc: Andreas Faerber <[e-mail]>
>>>>>>>> Cc: Sachin Kamat <[e-mail]>
>>>>>>>> Cc: Andreas Farber <[e-mail]>
>>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>>>>>>>
>>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>>>>>>
>>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>>>>>> picks it by himself from LKML.
>>>>>>
>>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
>>>>> v4.2-rc1 after v4.2-rc1 release.
>>>>
>>>> You mean it is for v4.3, not v4.2?
>>>>
>>> Oops, yes v4.3.
>>>
>>> Thanks for the correction.
>>
>> Kukjin & Krzysztof,
>>
>> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
>> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
>> week).
>>
>> Is patch 4 going out for 4.2 or 4.3?
> 
> It is quite late for sending pull request to arm-soc for 4.2.
> For example SoCFPGA pull request from last week was rejected:
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980

Oh, that was wrong link. Here it is:
http://www.spinics.net/lists/arm-kernel/msg425911.html

> If you want to take it for 4.2 then I am fine with it but this will
> cause some easy but annoying conflicts. There aren't difficult - just
> most of nodes in board DTS changed their place.
> 
> Example of resolution (target file after merge, with cpu nodes reordered
> alphabetically):
> https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd

Best regards,
Krzysztof

Bartlomiej Zolnierkiewicz June 24, 2015, 2:25 p.m. UTC | #9

Hi,

On Tuesday, June 23, 2015 08:46:33 AM Krzysztof Kozlowski wrote:
> On 23.06.2015 00:04, Michael Turquette wrote:
> > Quoting Kukjin Kim (2015-06-21 18:46:26)
> >> Krzysztof Kozlowski wrote:
> >>>
> >>> On 22.06.2015 10:38, Kukjin Kim wrote:
> >>>> Krzysztof Kozlowski wrote:
> >>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> >>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >>>>>>> From: Thomas Abraham <[e-mail]>
> >>>>>>>
> >>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
> >>>>>>> regulator supply properties for migrating from Exynos specific
> >>>>>>> cpufreq driver to using generic cpufreq driver.
> >>>>>>>
> >>>>>>> Changes by Bartlomiej:
> >>>>>>> - removed Exynos5250 and Exynos5420 support for now
> >>>>>>>
> >>>>>>> Cc: Kukjin Kim <[e-mail]>
> >>>>>>> Cc: Doug Anderson <[e-mail]>
> >>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>>>>> Cc: Andreas Faerber <[e-mail]>
> >>>>>>> Cc: Sachin Kamat <[e-mail]>
> >>>>>>> Cc: Andreas Farber <[e-mail]>
> >>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
> >>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> >>>>>>
> >>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> >>>>>
> >>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> >>>>> picks it by himself from LKML.
> >>>>>
> >>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> >>>> v4.2-rc1 after v4.2-rc1 release.
> >>>
> >>> You mean it is for v4.3, not v4.2?
> >>>
> >> Oops, yes v4.3.
> >>
> >> Thanks for the correction.
> > 
> > Kukjin & Krzysztof,
> > 
> > I'm confused on this point. I was planning to take patches 1, 2, 3, 5
> > and 6 towards 4.2 (e.g. in the pull request that I'll send out this
> > week).
> > 
> > Is patch 4 going out for 4.2 or 4.3?
> 
> It is quite late for sending pull request to arm-soc for 4.2.
> For example SoCFPGA pull request from last week was rejected:
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
> 
> If you want to take it for 4.2 then I am fine with it but this will
> cause some easy but annoying conflicts. There aren't difficult - just
> most of nodes in board DTS changed their place.

Taking all patches together would be a preferred solution from my POV.

It would also be great if it could happen in v4.2 (all code changes are
practically limited to our Exynos4210 platform so I hope that it should
be fine) as it would be easier to work on Exynos4x12, Exynos5250 and
Exynos542x/5800 patch series.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> Example of resolution (target file after merge, with cpu nodes reordered
> alphabetically):
> https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
> 
> Best regards,
> Krzysztof

Bartlomiej Zolnierkiewicz July 13, 2015, 11:02 a.m. UTC | #10

Hi,

On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
> > On 23.06.2015 00:04, Michael Turquette wrote:
> >> Quoting Kukjin Kim (2015-06-21 18:46:26)
> >>> Krzysztof Kozlowski wrote:
> >>>>
> >>>> On 22.06.2015 10:38, Kukjin Kim wrote:
> >>>>> Krzysztof Kozlowski wrote:
> >>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> >>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >>>>>>>> From: Thomas Abraham <[e-mail]>
> >>>>>>>>
> >>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
> >>>>>>>> regulator supply properties for migrating from Exynos specific
> >>>>>>>> cpufreq driver to using generic cpufreq driver.
> >>>>>>>>
> >>>>>>>> Changes by Bartlomiej:
> >>>>>>>> - removed Exynos5250 and Exynos5420 support for now
> >>>>>>>>
> >>>>>>>> Cc: Kukjin Kim <[e-mail]>
> >>>>>>>> Cc: Doug Anderson <[e-mail]>
> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>>>>>> Cc: Andreas Faerber <[e-mail]>
> >>>>>>>> Cc: Sachin Kamat <[e-mail]>
> >>>>>>>> Cc: Andreas Farber <[e-mail]>
> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
> >>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> >>>>>>>
> >>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> >>>>>>
> >>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> >>>>>> picks it by himself from LKML.
> >>>>>>
> >>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> >>>>> v4.2-rc1 after v4.2-rc1 release.
> >>>>
> >>>> You mean it is for v4.3, not v4.2?
> >>>>
> >>> Oops, yes v4.3.
> >>>
> >>> Thanks for the correction.
> >>
> >> Kukjin & Krzysztof,
> >>
> >> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
> >> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
> >> week).
> >>
> >> Is patch 4 going out for 4.2 or 4.3?
> > 
> > It is quite late for sending pull request to arm-soc for 4.2.
> > For example SoCFPGA pull request from last week was rejected:
> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
> 
> Oh, that was wrong link. Here it is:
> http://www.spinics.net/lists/arm-kernel/msg425911.html
> 
> > If you want to take it for 4.2 then I am fine with it but this will
> > cause some easy but annoying conflicts. There aren't difficult - just
> > most of nodes in board DTS changed their place.
> > 
> > Example of resolution (target file after merge, with cpu nodes reordered
> > alphabetically):
> > https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd

This patch is needed for v4.2 as other changes has been already
merged.

Krzysztof/Kukjin, could you please take care of it?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Krzysztof Kozlowski July 13, 2015, 11:10 a.m. UTC | #11

2015-07-13 20:02 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>
> Hi,
>
> On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
>> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
>> > On 23.06.2015 00:04, Michael Turquette wrote:
>> >> Quoting Kukjin Kim (2015-06-21 18:46:26)
>> >>> Krzysztof Kozlowski wrote:
>> >>>>
>> >>>> On 22.06.2015 10:38, Kukjin Kim wrote:
>> >>>>> Krzysztof Kozlowski wrote:
>> >>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>> >>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>> >>>>>>>> From: Thomas Abraham <[e-mail]>
>> >>>>>>>>
>> >>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
>> >>>>>>>> regulator supply properties for migrating from Exynos specific
>> >>>>>>>> cpufreq driver to using generic cpufreq driver.
>> >>>>>>>>
>> >>>>>>>> Changes by Bartlomiej:
>> >>>>>>>> - removed Exynos5250 and Exynos5420 support for now
>> >>>>>>>>
>> >>>>>>>> Cc: Kukjin Kim <[e-mail]>
>> >>>>>>>> Cc: Doug Anderson <[e-mail]>
>> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>> >>>>>>>> Cc: Andreas Faerber <[e-mail]>
>> >>>>>>>> Cc: Sachin Kamat <[e-mail]>
>> >>>>>>>> Cc: Andreas Farber <[e-mail]>
>> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>> >>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>> >>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>> >>>>>>>
>> >>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>> >>>>>>
>> >>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>> >>>>>> picks it by himself from LKML.
>> >>>>>>
>> >>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
>> >>>>> v4.2-rc1 after v4.2-rc1 release.
>> >>>>
>> >>>> You mean it is for v4.3, not v4.2?
>> >>>>
>> >>> Oops, yes v4.3.
>> >>>
>> >>> Thanks for the correction.
>> >>
>> >> Kukjin & Krzysztof,
>> >>
>> >> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
>> >> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
>> >> week).
>> >>
>> >> Is patch 4 going out for 4.2 or 4.3?
>> >
>> > It is quite late for sending pull request to arm-soc for 4.2.
>> > For example SoCFPGA pull request from last week was rejected:
>> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
>>
>> Oh, that was wrong link. Here it is:
>> http://www.spinics.net/lists/arm-kernel/msg425911.html
>>
>> > If you want to take it for 4.2 then I am fine with it but this will
>> > cause some easy but annoying conflicts. There aren't difficult - just
>> > most of nodes in board DTS changed their place.
>> >
>> > Example of resolution (target file after merge, with cpu nodes reordered
>> > alphabetically):
>> > https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
>
> This patch is needed for v4.2 as other changes has been already
> merged.
>
> Krzysztof/Kukjin, could you please take care of it?

Of course! It is already in my queue. I'll send it later to Kukjin for
4.3 (unless he picks it also).

BTW for other patchsets you still need acks from Samsung clock
maintainers. Did you poke Sylwester or Tomasz about it?

Best regards,
Krzysztof

Bartlomiej Zolnierkiewicz July 13, 2015, 11:20 a.m. UTC | #12

On Monday, July 13, 2015 08:10:21 PM Krzysztof Kozlowski wrote:
> 2015-07-13 20:02 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >
> > Hi,
> >
> > On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
> >> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
> >> > On 23.06.2015 00:04, Michael Turquette wrote:
> >> >> Quoting Kukjin Kim (2015-06-21 18:46:26)
> >> >>> Krzysztof Kozlowski wrote:
> >> >>>>
> >> >>>> On 22.06.2015 10:38, Kukjin Kim wrote:
> >> >>>>> Krzysztof Kozlowski wrote:
> >> >>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> >> >>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> >> >>>>>>>> From: Thomas Abraham <[e-mail]>
> >> >>>>>>>>
> >> >>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
> >> >>>>>>>> regulator supply properties for migrating from Exynos specific
> >> >>>>>>>> cpufreq driver to using generic cpufreq driver.
> >> >>>>>>>>
> >> >>>>>>>> Changes by Bartlomiej:
> >> >>>>>>>> - removed Exynos5250 and Exynos5420 support for now
> >> >>>>>>>>
> >> >>>>>>>> Cc: Kukjin Kim <[e-mail]>
> >> >>>>>>>> Cc: Doug Anderson <[e-mail]>
> >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >> >>>>>>>> Cc: Andreas Faerber <[e-mail]>
> >> >>>>>>>> Cc: Sachin Kamat <[e-mail]>
> >> >>>>>>>> Cc: Andreas Farber <[e-mail]>
> >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> >> >>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
> >> >>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> >> >>>>>>>
> >> >>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> >> >>>>>>
> >> >>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> >> >>>>>> picks it by himself from LKML.
> >> >>>>>>
> >> >>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> >> >>>>> v4.2-rc1 after v4.2-rc1 release.
> >> >>>>
> >> >>>> You mean it is for v4.3, not v4.2?
> >> >>>>
> >> >>> Oops, yes v4.3.
> >> >>>
> >> >>> Thanks for the correction.
> >> >>
> >> >> Kukjin & Krzysztof,
> >> >>
> >> >> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
> >> >> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
> >> >> week).
> >> >>
> >> >> Is patch 4 going out for 4.2 or 4.3?
> >> >
> >> > It is quite late for sending pull request to arm-soc for 4.2.
> >> > For example SoCFPGA pull request from last week was rejected:
> >> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
> >>
> >> Oh, that was wrong link. Here it is:
> >> http://www.spinics.net/lists/arm-kernel/msg425911.html
> >>
> >> > If you want to take it for 4.2 then I am fine with it but this will
> >> > cause some easy but annoying conflicts. There aren't difficult - just
> >> > most of nodes in board DTS changed their place.
> >> >
> >> > Example of resolution (target file after merge, with cpu nodes reordered
> >> > alphabetically):
> >> > https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
> >
> > This patch is needed for v4.2 as other changes has been already
> > merged.
> >
> > Krzysztof/Kukjin, could you please take care of it?
> 
> Of course! It is already in my queue. I'll send it later to Kukjin for
> 4.3 (unless he picks it also).

It is in your queue for v4.3 but the patch is needed for v4.2,
without it cpufreq support will not work for Exynos4210 platforms.

> BTW for other patchsets you still need acks from Samsung clock
> maintainers. Did you poke Sylwester or Tomasz about it?

Sylwester, please review/ack Samsung specific clock changes in
Exynos5250 cpufreq and Exynos4x12 cpufreq patch series.

Patch series:

* [PATCH v3 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
  (http://lkml.org/lkml/2015/7/1/311)

* [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
  (http://lkml.org/lkml/2015/7/9/419)

Samsung clock specific changes:

* [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data
  and instantiate cpu clock
  (http://lkml.org/lkml/2015/7/1/313)

* [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data
  and instantiate cpu clock
  (http://lkml.org/lkml/2015/7/9/424)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Krzysztof Kozlowski July 13, 2015, 11:50 a.m. UTC | #13

2015-07-13 20:20 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> On Monday, July 13, 2015 08:10:21 PM Krzysztof Kozlowski wrote:
>> 2015-07-13 20:02 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>> >
>> > Hi,
>> >
>> > On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
>> >> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
>> >> > On 23.06.2015 00:04, Michael Turquette wrote:
>> >> >> Quoting Kukjin Kim (2015-06-21 18:46:26)
>> >> >>> Krzysztof Kozlowski wrote:
>> >> >>>>
>> >> >>>> On 22.06.2015 10:38, Kukjin Kim wrote:
>> >> >>>>> Krzysztof Kozlowski wrote:
>> >> >>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>> >> >>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>> >> >>>>>>>> From: Thomas Abraham <[e-mail]>
>> >> >>>>>>>>
>> >> >>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
>> >> >>>>>>>> regulator supply properties for migrating from Exynos specific
>> >> >>>>>>>> cpufreq driver to using generic cpufreq driver.
>> >> >>>>>>>>
>> >> >>>>>>>> Changes by Bartlomiej:
>> >> >>>>>>>> - removed Exynos5250 and Exynos5420 support for now
>> >> >>>>>>>>
>> >> >>>>>>>> Cc: Kukjin Kim <[e-mail]>
>> >> >>>>>>>> Cc: Doug Anderson <[e-mail]>
>> >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>> >> >>>>>>>> Cc: Andreas Faerber <[e-mail]>
>> >> >>>>>>>> Cc: Sachin Kamat <[e-mail]>
>> >> >>>>>>>> Cc: Andreas Farber <[e-mail]>
>> >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>> >> >>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>> >> >>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>> >> >>>>>>>
>> >> >>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>> >> >>>>>>
>> >> >>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>> >> >>>>>> picks it by himself from LKML.
>> >> >>>>>>
>> >> >>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
>> >> >>>>> v4.2-rc1 after v4.2-rc1 release.
>> >> >>>>
>> >> >>>> You mean it is for v4.3, not v4.2?
>> >> >>>>
>> >> >>> Oops, yes v4.3.
>> >> >>>
>> >> >>> Thanks for the correction.
>> >> >>
>> >> >> Kukjin & Krzysztof,
>> >> >>
>> >> >> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
>> >> >> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
>> >> >> week).
>> >> >>
>> >> >> Is patch 4 going out for 4.2 or 4.3?
>> >> >
>> >> > It is quite late for sending pull request to arm-soc for 4.2.
>> >> > For example SoCFPGA pull request from last week was rejected:
>> >> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
>> >>
>> >> Oh, that was wrong link. Here it is:
>> >> http://www.spinics.net/lists/arm-kernel/msg425911.html
>> >>
>> >> > If you want to take it for 4.2 then I am fine with it but this will
>> >> > cause some easy but annoying conflicts. There aren't difficult - just
>> >> > most of nodes in board DTS changed their place.
>> >> >
>> >> > Example of resolution (target file after merge, with cpu nodes reordered
>> >> > alphabetically):
>> >> > https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
>> >
>> > This patch is needed for v4.2 as other changes has been already
>> > merged.
>> >
>> > Krzysztof/Kukjin, could you please take care of it?
>>
>> Of course! It is already in my queue. I'll send it later to Kukjin for
>> 4.3 (unless he picks it also).
>
> It is in your queue for v4.3 but the patch is needed for v4.2,
> without it cpufreq support will not work for Exynos4210 platforms.

Hmm... it makes sense to push it during this rc-cycle to bring back
crippled feature.

Best regards,
Krzysztof

Bartlomiej Zolnierkiewicz July 13, 2015, 2:27 p.m. UTC | #14

On Monday, July 13, 2015 01:20:41 PM Bartlomiej Zolnierkiewicz wrote:
> On Monday, July 13, 2015 08:10:21 PM Krzysztof Kozlowski wrote:
> > 2015-07-13 20:02 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> > >
> > > Hi,
> > >
> > > On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
> > >> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
> > >> > On 23.06.2015 00:04, Michael Turquette wrote:
> > >> >> Quoting Kukjin Kim (2015-06-21 18:46:26)
> > >> >>> Krzysztof Kozlowski wrote:
> > >> >>>>
> > >> >>>> On 22.06.2015 10:38, Kukjin Kim wrote:
> > >> >>>>> Krzysztof Kozlowski wrote:
> > >> >>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
> > >> >>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
> > >> >>>>>>>> From: Thomas Abraham <[e-mail]>
> > >> >>>>>>>>
> > >> >>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
> > >> >>>>>>>> regulator supply properties for migrating from Exynos specific
> > >> >>>>>>>> cpufreq driver to using generic cpufreq driver.
> > >> >>>>>>>>
> > >> >>>>>>>> Changes by Bartlomiej:
> > >> >>>>>>>> - removed Exynos5250 and Exynos5420 support for now
> > >> >>>>>>>>
> > >> >>>>>>>> Cc: Kukjin Kim <[e-mail]>
> > >> >>>>>>>> Cc: Doug Anderson <[e-mail]>
> > >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> > >> >>>>>>>> Cc: Andreas Faerber <[e-mail]>
> > >> >>>>>>>> Cc: Sachin Kamat <[e-mail]>
> > >> >>>>>>>> Cc: Andreas Farber <[e-mail]>
> > >> >>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
> > >> >>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
> > >> >>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
> > >> >>>>>>>
> > >> >>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
> > >> >>>>>>
> > >> >>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
> > >> >>>>>> picks it by himself from LKML.
> > >> >>>>>>
> > >> >>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
> > >> >>>>> v4.2-rc1 after v4.2-rc1 release.
> > >> >>>>
> > >> >>>> You mean it is for v4.3, not v4.2?
> > >> >>>>
> > >> >>> Oops, yes v4.3.
> > >> >>>
> > >> >>> Thanks for the correction.
> > >> >>
> > >> >> Kukjin & Krzysztof,
> > >> >>
> > >> >> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
> > >> >> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
> > >> >> week).
> > >> >>
> > >> >> Is patch 4 going out for 4.2 or 4.3?
> > >> >
> > >> > It is quite late for sending pull request to arm-soc for 4.2.
> > >> > For example SoCFPGA pull request from last week was rejected:
> > >> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
> > >>
> > >> Oh, that was wrong link. Here it is:
> > >> http://www.spinics.net/lists/arm-kernel/msg425911.html
> > >>
> > >> > If you want to take it for 4.2 then I am fine with it but this will
> > >> > cause some easy but annoying conflicts. There aren't difficult - just
> > >> > most of nodes in board DTS changed their place.
> > >> >
> > >> > Example of resolution (target file after merge, with cpu nodes reordered
> > >> > alphabetically):
> > >> > https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
> > >
> > > This patch is needed for v4.2 as other changes has been already
> > > merged.
> > >
> > > Krzysztof/Kukjin, could you please take care of it?
> > 
> > Of course! It is already in my queue. I'll send it later to Kukjin for
> > 4.3 (unless he picks it also).
> 
> It is in your queue for v4.3 but the patch is needed for v4.2,
> without it cpufreq support will not work for Exynos4210 platforms.
> 
> > BTW for other patchsets you still need acks from Samsung clock
> > maintainers. Did you poke Sylwester or Tomasz about it?
> 
> Sylwester, please review/ack Samsung specific clock changes in
> Exynos5250 cpufreq and Exynos4x12 cpufreq patch series.
> 
> Patch series:
> 
> * [PATCH v3 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
>   (http://lkml.org/lkml/2015/7/1/311)
> 
> * [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
>   (http://lkml.org/lkml/2015/7/9/419)
> 
> Samsung clock specific changes:
> 
> * [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data
>   and instantiate cpu clock
>   (http://lkml.org/lkml/2015/7/1/313)
> 
> * [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data
>   and instantiate cpu clock
>   (http://lkml.org/lkml/2015/7/9/424)

BTW corresponding changes for Exynos4210 has already been merged and 2 above
patches are quite obvious so review should be very quick & simple.

[ Unfortunately Sylwester is currently very busy with a more priority work so
  it may still take some time to get his ACKs. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Krzysztof Kozlowski July 14, 2015, 12:02 a.m. UTC | #15

On 13.07.2015 23:27, Bartlomiej Zolnierkiewicz wrote:
> On Monday, July 13, 2015 01:20:41 PM Bartlomiej Zolnierkiewicz wrote:
>> On Monday, July 13, 2015 08:10:21 PM Krzysztof Kozlowski wrote:
>>> 2015-07-13 20:02 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>>>>
>>>> Hi,
>>>>
>>>> On Tuesday, June 23, 2015 09:24:40 AM Krzysztof Kozlowski wrote:
>>>>> On 23.06.2015 08:46, Krzysztof Kozlowski wrote:
>>>>>> On 23.06.2015 00:04, Michael Turquette wrote:
>>>>>>> Quoting Kukjin Kim (2015-06-21 18:46:26)
>>>>>>>> Krzysztof Kozlowski wrote:
>>>>>>>>>
>>>>>>>>> On 22.06.2015 10:38, Kukjin Kim wrote:
>>>>>>>>>> Krzysztof Kozlowski wrote:
>>>>>>>>>>> 2015-05-08 9:18 GMT+09:00 Krzysztof Kozlowski <[e-mail]>:
>>>>>>>>>>>> 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz <[e-mail]>:
>>>>>>>>>>>>> From: Thomas Abraham <[e-mail]>
>>>>>>>>>>>>>
>>>>>>>>>>>>> For Exynos4210 platforms, add CPU operating points and CPU
>>>>>>>>>>>>> regulator supply properties for migrating from Exynos specific
>>>>>>>>>>>>> cpufreq driver to using generic cpufreq driver.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Changes by Bartlomiej:
>>>>>>>>>>>>> - removed Exynos5250 and Exynos5420 support for now
>>>>>>>>>>>>>
>>>>>>>>>>>>> Cc: Kukjin Kim <[e-mail]>
>>>>>>>>>>>>> Cc: Doug Anderson <[e-mail]>
>>>>>>>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>>>>>>>> Cc: Andreas Faerber <[e-mail]>
>>>>>>>>>>>>> Cc: Sachin Kamat <[e-mail]>
>>>>>>>>>>>>> Cc: Andreas Farber <[e-mail]>
>>>>>>>>>>>>> Cc: Javier Martinez Canillas <[e-mail]>
>>>>>>>>>>>>> Signed-off-by: Thomas Abraham <[e-mail]>
>>>>>>>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <[e-mail]>
>>>>>>>>>>>>
>>>>>>>>>>>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>>>>>>>>>>>
>>>>>>>>>>> Rebased and applied to my tree, I'll sent it later to Kukjin unless he
>>>>>>>>>>> picks it by himself from LKML.
>>>>>>>>>>>
>>>>>>>>>> Hi, as far as I know, this is for v4.2 not v4.1 so it will be applied based on
>>>>>>>>>> v4.2-rc1 after v4.2-rc1 release.
>>>>>>>>>
>>>>>>>>> You mean it is for v4.3, not v4.2?
>>>>>>>>>
>>>>>>>> Oops, yes v4.3.
>>>>>>>>
>>>>>>>> Thanks for the correction.
>>>>>>>
>>>>>>> Kukjin & Krzysztof,
>>>>>>>
>>>>>>> I'm confused on this point. I was planning to take patches 1, 2, 3, 5
>>>>>>> and 6 towards 4.2 (e.g. in the pull request that I'll send out this
>>>>>>> week).
>>>>>>>
>>>>>>> Is patch 4 going out for 4.2 or 4.3?
>>>>>>
>>>>>> It is quite late for sending pull request to arm-soc for 4.2.
>>>>>> For example SoCFPGA pull request from last week was rejected:
>>>>>> http://comments.gmane.org/gmane.linux.ports.arm.kernel/417980
>>>>>
>>>>> Oh, that was wrong link. Here it is:
>>>>> http://www.spinics.net/lists/arm-kernel/msg425911.html
>>>>>
>>>>>> If you want to take it for 4.2 then I am fine with it but this will
>>>>>> cause some easy but annoying conflicts. There aren't difficult - just
>>>>>> most of nodes in board DTS changed their place.
>>>>>>
>>>>>> Example of resolution (target file after merge, with cpu nodes reordered
>>>>>> alphabetically):
>>>>>> https://github.com/krzk/linux/commit/2cec3cb48abaf44848c62f1c0836b772eb4680dd
>>>>
>>>> This patch is needed for v4.2 as other changes has been already
>>>> merged.
>>>>
>>>> Krzysztof/Kukjin, could you please take care of it?
>>>
>>> Of course! It is already in my queue. I'll send it later to Kukjin for
>>> 4.3 (unless he picks it also).
>>
>> It is in your queue for v4.3 but the patch is needed for v4.2,
>> without it cpufreq support will not work for Exynos4210 platforms.
>>
>>> BTW for other patchsets you still need acks from Samsung clock
>>> maintainers. Did you poke Sylwester or Tomasz about it?
>>
>> Sylwester, please review/ack Samsung specific clock changes in
>> Exynos5250 cpufreq and Exynos4x12 cpufreq patch series.
>>
>> Patch series:
>>
>> * [PATCH v3 0/4] cpufreq: use generic cpufreq drivers for Exynos5250 platform
>>   (http://lkml.org/lkml/2015/7/1/311)
>>
>> * [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
>>   (http://lkml.org/lkml/2015/7/9/419)
>>
>> Samsung clock specific changes:
>>
>> * [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data
>>   and instantiate cpu clock
>>   (http://lkml.org/lkml/2015/7/1/313)
>>
>> * [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data
>>   and instantiate cpu clock
>>   (http://lkml.org/lkml/2015/7/9/424)
> 
> BTW corresponding changes for Exynos4210 has already been merged and 2 above
> patches are quite obvious so review should be very quick & simple.
> 
> [ Unfortunately Sylwester is currently very busy with a more priority work so
>   it may still take some time to get his ACKs. ]

The review would be fast and already Javier or me provided such.

Anyway if you want to merge it through different tree it would be
expected to get an ack from bypassed maintainer.

Especially that the distance between you and the bypassed maintainer was
~1 meter for the most of the time :) .

It is much longer distance between you and me now!

Best regards,
Krzysztof

Patch

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index b811461..5b0941f 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -335,3 +335,7 @@ 
 		};
 	};
 };
+
+&cpu0 {
+	cpu0-supply = <&buck1_reg>;
+};
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 32c5fd8..9b5bdd0 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -483,3 +483,7 @@ 
 		};
 	};
 };
+
+&cpu0 {
+	cpu0-supply = <&varm_breg>;
+};
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index d4f2b11..5bf74da 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -567,3 +567,7 @@ 
 &mdma1 {
 	reg = <0x12840000 0x1000>;
 };
+
+&cpu0 {
+	cpu0-supply = <&vdd_arm_reg>;
+};
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index be89f83..df075e64 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -40,6 +40,18 @@ 
 			device_type = "cpu";
 			compatible = "arm,cortex-a9";
 			reg = <0x900>;
+			clocks = <&clock CLK_ARM_CLK>;
+			clock-names = "cpu";
+			clock-latency = <160000>;
+
+			operating-points = <
+				1200000 1250000
+				1000000 1150000
+				800000	1075000
+				500000	975000
+				400000	975000
+				200000	950000
+			>;
 			cooling-min-level = <4>;
 			cooling-max-level = <2>;
 			#cooling-cells = <2>; /* min followed by max */