diff mbox

brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Message ID 55828106.7060004@broadcom.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Arend van Spriel June 18, 2015, 8:27 a.m. UTC 
On 06/18/15 08:13, Jörg Krause wrote:
> Hi Arend,
>
> On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
>> On 06/16/15 11:59, Jörg Krause wrote:
>>> Hi Arend,
>>>
>>> as I wrote in my previous mail ("brcmfmac: brcmf_p2p_create_p2pdev:
>>> timeout occurred") I get a p2p0 interface when loading the brcmfmac
>>> module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
>>>
>>> Unfortunatly, if I try to use the p2p0 interface with
>>> wpa_supplicant
>>> 2.4 I get an error:
>>>
>>>       Failed to create interface p2p-dev-p2p0: -28 (No space left on
>>>       device)
>>>       nl80211: Failed to create a P2P Device interface p2p-dev-p2p0
>>>       P2P: Failed to enable P2P Device interface
>>
>> Using p2pon=1 is old-school p2p, ie. it creates a regular netdev for
>> doing p2p management stuff. Problem is that brcmfmac also indicates
>> p2p
>> device support. We can remove p2pon parameter or not indicate p2p dev
>>
>> support when p2pon=1.
>
> I used p2pon because the p2p0 interface is not created without it. It
> fails with the error message "brcmf_p2p_create_p2pdev: timeout
> occurred" as written in my previous mails. I would prefer not to use
> it, so maybe we can find a solution how to get it working without it.

43362 firmware may have issues with regular p2p dev support so let's 
stick with p2pon for now.
>>
>> Can you patch brcmfmac and give it a try. Need to start
>> wpa_supplicant
>> for two interface and if I recall correctly p2p0 must be specified
>> first.
>
> Can you give me a hint where to patch brcmfmac. Many thanks!

Attached is patch against 4.0.5 kernel.

Regards,
Arend
From 99bbbaa540fe9543156018b7f8596b46f60a723c Mon Sep 17 00:00:00 2001
From: Arend van Spriel <arend@broadcom.com>
Date: Thu, 18 Jun 2015 10:23:50 +0200
Subject: [PATCH] brcmfmac: disable p2pdev support when using p2pon=1

Avoid wpa_supplicant from creating a p2pdev interface when we
already have a p2p0 interface, ie. loaded the driver with p2pon=1.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Jörg Krause June 18, 2015, 8:07 p.m. UTC | #1 
On Do, 2015-06-18 at 10:27 +0200, Arend van Spriel wrote:
> On 06/18/15 08:13, Jörg Krause wrote:
> > Hi Arend,
> > 
> > On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
> > > On 06/16/15 11:59, Jörg Krause wrote:
> > > > Hi Arend,
> > > > 
> > > > as I wrote in my previous mail ("brcmfmac: 
> > > > brcmf_p2p_create_p2pdev:
> > > > timeout occurred") I get a p2p0 interface when loading the 
> > > > brcmfmac
> > > > module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
> > > > 
> > > > Unfortunatly, if I try to use the p2p0 interface with
> > > > wpa_supplicant
> > > > 2.4 I get an error:
> > > > 
> > > >       Failed to create interface p2p-dev-p2p0: -28 (No space 
> > > > left on
> > > >       device)
> > > >       nl80211: Failed to create a P2P Device interface p2p-dev
> > > > -p2p0
> > > >       P2P: Failed to enable P2P Device interface
> > > 
> > > Using p2pon=1 is old-school p2p, ie. it creates a regular netdev 
> > > for
> > > doing p2p management stuff. Problem is that brcmfmac also 
> > > indicates
> > > p2p
> > > device support. We can remove p2pon parameter or not indicate p2p 
> > > dev
> > > 
> > > support when p2pon=1.
> > 
> > I used p2pon because the p2p0 interface is not created without it. 
> > It
> > fails with the error message "brcmf_p2p_create_p2pdev: timeout
> > occurred" as written in my previous mails. I would prefer not to 
> > use
> > it, so maybe we can find a solution how to get it working without 
> > it.
> 
> 43362 firmware may have issues with regular p2p dev support so let's 
> stick with p2pon for now.

Okay.

> > > 
> > > Can you patch brcmfmac and give it a try. Need to start
> > > wpa_supplicant
> > > for two interface and if I recall correctly p2p0 must be 
> > > specified
> > > first.
> > 
> > Can you give me a hint where to patch brcmfmac. Many thanks!
> 
> Attached is patch against 4.0.5 kernel.

I applied the patch and if I load brcmfmac with p2pon=1 I get a kernel
warning and _no_ wlan0 and p2p0 interfaces:

    [    7.577223] ------------[ cut here ]------------
    [    7.583144] WARNING: CPU: 0 PID: 4 at net/wireless/core.c:527
    wiphy_register+0x3a4/0x67c()
    [    7.594652] Modules linked in: brcmfmac brcmutil
    [    7.601507] CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.0.5
    -LINTECH #3
    [    7.610809] Hardware name: Freescale MXS (Device Tree)
    [    7.617411] Workqueue: events request_firmware_work_func
    [    7.625110] [<c000dec8>] (unwind_backtrace) from [<c000c25c>]
    (show_stack+0x10/0x14)
    [    7.635541] [<c000c25c>] (show_stack) from [<c001613c>]
    (warn_slowpath_common+0x78/0xb0)
    [    7.645171] [<c001613c>] (warn_slowpath_common) from
    [<c0016210>] (warn_slowpath_null+0x1c/0x24)
    [    7.656635] [<c0016210>] (warn_slowpath_null) from [<c03b6f20>]
    (wiphy_register+0x3a4/0x67c)
    [    7.666657] [<c03b6f20>] (wiphy_register) from [<bf00de20>]
    (brcmf_cfg80211_attach+0x86c/0x1124 [brcmfmac])
    [    7.679412] [<bf00de20>] (brcmf_cfg80211_attach [brcmfmac]) from
    [<bf018f3c>] (brcmf_bus_start+0xac/0x29c [brcmfmac])
    [    7.690925] [<bf018f3c>] (brcmf_bus_start [brcmfmac]) from
    [<bf01dd00>] (brcmf_sdio_firmware_callback+0x3d8/0x9e8 [brcmfmac])
    [    7.705622] [<bf01dd00>] (brcmf_sdio_firmware_callback
    [brcmfmac]) from [<bf0195fc>]
    (brcmf_fw_request_nvram_done+0x134/0x1d0 [brcmfmac])
    [    7.718916] [<bf0195fc>] (brcmf_fw_request_nvram_done
    [brcmfmac]) from [<c020ab88>]
    (request_firmware_work_func+0x30/0x50)
    [    7.733292] [<c020ab88>] (request_firmware_work_func) from
    [<c0029a98>] (process_one_work+0x184/0x418)
    [    7.744112] [<c0029a98>] (process_one_work) from [<c002a694>]
    (worker_thread+0x3c/0x464)
    [    7.754977] [<c002a694>] (worker_thread) from [<c002e130>]
    (kthread+0xc0/0xdc)
    [    7.763730] [<c002e130>] (kthread) from [<c0009730>]
    (ret_from_fork+0x14/0x24)
    [    7.773568] ---[ end trace 39ec555e61fc038e ]---
    [    7.779710] brcmfmac: brcmf_cfg80211_attach: Could not register
    wiphy device (-22)
    [    7.790013] brcmfmac: brcmf_bus_start: failed: -12
    [    7.800278] brcmfmac: brcmf_sdio_firmware_callback: dongle is
    not responding

Best regards
Jörg Krause
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arend Van Spriel June 21, 2015, 9:18 p.m. UTC | #2 
On 18-06-15 22:07, Jörg Krause wrote:
> On Do, 2015-06-18 at 10:27 +0200, Arend van Spriel wrote:
>> On 06/18/15 08:13, Jörg Krause wrote:
>>> Hi Arend,
>>>
>>> On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
>>>> On 06/16/15 11:59, Jörg Krause wrote:
>>>>> Hi Arend,
>>>>>
>>>>> as I wrote in my previous mail ("brcmfmac: 
>>>>> brcmf_p2p_create_p2pdev:
>>>>> timeout occurred") I get a p2p0 interface when loading the 
>>>>> brcmfmac
>>>>> module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
>>>>>
>>>>> Unfortunatly, if I try to use the p2p0 interface with
>>>>> wpa_supplicant
>>>>> 2.4 I get an error:
>>>>>
>>>>>       Failed to create interface p2p-dev-p2p0: -28 (No space 
>>>>> left on
>>>>>       device)
>>>>>       nl80211: Failed to create a P2P Device interface p2p-dev
>>>>> -p2p0
>>>>>       P2P: Failed to enable P2P Device interface
>>>>
>>>> Using p2pon=1 is old-school p2p, ie. it creates a regular netdev 
>>>> for
>>>> doing p2p management stuff. Problem is that brcmfmac also 
>>>> indicates
>>>> p2p
>>>> device support. We can remove p2pon parameter or not indicate p2p 
>>>> dev
>>>>
>>>> support when p2pon=1.
>>>
>>> I used p2pon because the p2p0 interface is not created without it. 
>>> It
>>> fails with the error message "brcmf_p2p_create_p2pdev: timeout
>>> occurred" as written in my previous mails. I would prefer not to 
>>> use
>>> it, so maybe we can find a solution how to get it working without 
>>> it.
>>
>> 43362 firmware may have issues with regular p2p dev support so let's 
>> stick with p2pon for now.
> 
> Okay.
> 
>>>>
>>>> Can you patch brcmfmac and give it a try. Need to start
>>>> wpa_supplicant
>>>> for two interface and if I recall correctly p2p0 must be 
>>>> specified
>>>> first.
>>>
>>> Can you give me a hint where to patch brcmfmac. Many thanks!
>>
>> Attached is patch against 4.0.5 kernel.
> 
> I applied the patch and if I load brcmfmac with p2pon=1 I get a kernel
> warning and _no_ wlan0 and p2p0 interfaces:
> 
>     [    7.577223] ------------[ cut here ]------------
>     [    7.583144] WARNING: CPU: 0 PID: 4 at net/wireless/core.c:527
>     wiphy_register+0x3a4/0x67c()
>     [    7.594652] Modules linked in: brcmfmac brcmutil
>     [    7.601507] CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.0.5
>     -LINTECH #3
>     [    7.610809] Hardware name: Freescale MXS (Device Tree)
>     [    7.617411] Workqueue: events request_firmware_work_func
>     [    7.625110] [<c000dec8>] (unwind_backtrace) from [<c000c25c>]
>     (show_stack+0x10/0x14)
>     [    7.635541] [<c000c25c>] (show_stack) from [<c001613c>]
>     (warn_slowpath_common+0x78/0xb0)
>     [    7.645171] [<c001613c>] (warn_slowpath_common) from
>     [<c0016210>] (warn_slowpath_null+0x1c/0x24)
>     [    7.656635] [<c0016210>] (warn_slowpath_null) from [<c03b6f20>]
>     (wiphy_register+0x3a4/0x67c)
>     [    7.666657] [<c03b6f20>] (wiphy_register) from [<bf00de20>]
>     (brcmf_cfg80211_attach+0x86c/0x1124 [brcmfmac])
>     [    7.679412] [<bf00de20>] (brcmf_cfg80211_attach [brcmfmac]) from
>     [<bf018f3c>] (brcmf_bus_start+0xac/0x29c [brcmfmac])
>     [    7.690925] [<bf018f3c>] (brcmf_bus_start [brcmfmac]) from
>     [<bf01dd00>] (brcmf_sdio_firmware_callback+0x3d8/0x9e8 [brcmfmac])
>     [    7.705622] [<bf01dd00>] (brcmf_sdio_firmware_callback
>     [brcmfmac]) from [<bf0195fc>]
>     (brcmf_fw_request_nvram_done+0x134/0x1d0 [brcmfmac])
>     [    7.718916] [<bf0195fc>] (brcmf_fw_request_nvram_done
>     [brcmfmac]) from [<c020ab88>]
>     (request_firmware_work_func+0x30/0x50)
>     [    7.733292] [<c020ab88>] (request_firmware_work_func) from
>     [<c0029a98>] (process_one_work+0x184/0x418)
>     [    7.744112] [<c0029a98>] (process_one_work) from [<c002a694>]
>     (worker_thread+0x3c/0x464)
>     [    7.754977] [<c002a694>] (worker_thread) from [<c002e130>]
>     (kthread+0xc0/0xdc)
>     [    7.763730] [<c002e130>] (kthread) from [<c0009730>]
>     (ret_from_fork+0x14/0x24)
>     [    7.773568] ---[ end trace 39ec555e61fc038e ]---
>     [    7.779710] brcmfmac: brcmf_cfg80211_attach: Could not register
>     wiphy device (-22)
>     [    7.790013] brcmfmac: brcmf_bus_start: failed: -12
>     [    7.800278] brcmfmac: brcmf_sdio_firmware_callback: dongle is
>     not responding

My bad. The patch removes p2pdev from interface modes, but it is still
listed in the interface combinations and cfg80211 will complain about
it. Have to extend the patch. I better do that after a good nights sleep.

Regards,
Arend

> Best regards
> Jörg Krause
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
Jörg Krause June 23, 2015, 11:31 a.m. UTC | #3 
Hi Arend,

On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote:
> 
> My bad. The patch removes p2pdev from interface modes, but it is 
> still
> listed in the interface combinations and cfg80211 will complain about
> it. Have to extend the patch. I better do that after a good nights 
> sleep.

Never mind! Did you had a good night sleep already :-) ?

Best regards
Jörg Krause
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
index b59b8c6..10eaabf 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
@@ -5789,8 +5789,11 @@  static int brcmf_setup_wiphy(struct wiphy *wiphy, struct brcmf_if *ifp)
 				 BIT(NL80211_IFTYPE_ADHOC) |
 				 BIT(NL80211_IFTYPE_AP) |
 				 BIT(NL80211_IFTYPE_P2P_CLIENT) |
-				 BIT(NL80211_IFTYPE_P2P_GO) |
-				 BIT(NL80211_IFTYPE_P2P_DEVICE);
+				 BIT(NL80211_IFTYPE_P2P_GO);
+	/* only annouce p2pdev when p2pon is zero */
+	if (!ifp->drvr->iflist[1])
+		wiphy->interface_modes |= BIT(NL80211_IFTYPE_P2P_DEVICE);
+
 	/* need VSDB firmware feature for concurrent channels */
 	ifc_combo = brcmf_iface_combos[0];
 	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_MCHAN))