| Message ID | 1435114591.2082.2.camel@ingics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 24, 2015 at 10:56:31AM +0800, Axel Lin wrote: > Remove .owner field because the core will set it. > Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601 > const. This doesn't apply against current code, please check and resend.
2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>: > On Wed, Jun 24, 2015 at 10:56:31AM +0800, Axel Lin wrote: >> Remove .owner field because the core will set it. >> Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601 >> const. > > This doesn't apply against current code, please check and resend. It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601.
On Wed, Jun 24, 2015 at 07:46:49PM +0800, Axel Lin wrote: > 2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>: > > This doesn't apply against current code, please check and resend. > It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601. The main bit is but it looked like you had some other changes which are probably still worthwhile?
2015-06-24 19:50 GMT+08:00 Mark Brown <broonie@kernel.org>: > On Wed, Jun 24, 2015 at 07:46:49PM +0800, Axel Lin wrote: >> 2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>: > >> > This doesn't apply against current code, please check and resend. > >> It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601. > > The main bit is but it looked like you had some other changes which are > probably still worthwhile? The sound/soc/codecs/gtm601.c does not exist in today's linux-next tree. I'll check the code again once it appears on linux-next.
diff --git a/sound/soc/codecs/gtm601.c b/sound/soc/codecs/gtm601.c index a696e3e..a652f19 100644 --- a/sound/soc/codecs/gtm601.c +++ b/sound/soc/codecs/gtm601.c @@ -51,7 +51,7 @@ struct snd_soc_dai_driver gtm601_dai = { }, }; -static struct snd_soc_codec_driver soc_codec_dev_gtm601 = { +static const struct snd_soc_codec_driver soc_codec_dev_gtm601 = { .dapm_widgets = gtm601_dapm_widgets, .num_dapm_widgets = ARRAY_SIZE(gtm601_dapm_widgets), .dapm_routes = gtm601_dapm_routes, @@ -80,11 +80,9 @@ MODULE_DEVICE_TABLE(of, gtm601_codec_of_match); static struct platform_driver gtm601_codec_driver = { .driver = { - .name = "gtm601", - .owner = THIS_MODULE, - .of_match_table = of_match_ptr(gtm601_codec_of_match), + .name = "gtm601", + .of_match_table = of_match_ptr(gtm601_codec_of_match), }, - .probe = gtm601_platform_probe, .remove = gtm601_platform_remove, };
Remove .owner field because the core will set it. Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601 const. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/gtm601.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)