| Message ID | 1435217189-19578-4-git-send-email-vaibhav.hiremath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..f56b751 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,54 @@ > +* Marvell 88PM8xx Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm8xx chip > +- interrupts : IRQ line for the 88pm8xx chip > +- interrupt-controller: describes the 88pm8xx as an interrupt controller > +- #interrupt-cells : should be 1. > + - The cell is the 88pm8xx local IRQ number Might just be a personal thing, but I would line up the ':', it's much easier on the eyes that way. > +88pm8xx family of devices consists of varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Note: More device list will follow No real need for this. > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + };
On Thursday 25 June 2015 03:58 PM, Lee Jones wrote: > On Thu, 25 Jun 2015, Vaibhav Hiremath wrote: > >> With addition of DT support to 88pm800 mfd driver, this patch >> adds new DT binding documentation along with respective properties. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt >> new file mode 100644 >> index 0000000..f56b751 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt >> @@ -0,0 +1,54 @@ >> +* Marvell 88PM8xx Power Management IC >> + >> +Required parent device properties: >> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" >> +- reg : the I2C slave address for the 88pm8xx chip >> +- interrupts : IRQ line for the 88pm8xx chip >> +- interrupt-controller: describes the 88pm8xx as an interrupt controller >> +- #interrupt-cells : should be 1. >> + - The cell is the 88pm8xx local IRQ number > > Might just be a personal thing, but I would line up the ':', it's much > easier on the eyes that way. Ok, > >> +88pm8xx family of devices consists of varied group of sub-devices: >> + >> +Device Supply Names Description >> +------ ------------ ----------- >> +88pm80x-onkey : : On key >> +88pm80x-rtc : : RTC >> +88pm80x-regulator : : Regulators >> + >> +Note: More device list will follow > > No real need for this. > I deliberately added it, as I was sure i would get comment if I only put e devices in the list. And guess what, as expected I got comment. Anyway, I agree and Will remove it. Thanks, Vaibhav
On Thu, Jun 25, 2015 at 03:26:29PM +0800, Vaibhav Hiremath wrote: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..f56b751 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,54 @@ > +* Marvell 88PM8xx Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm8xx chip > +- interrupts : IRQ line for the 88pm8xx chip > +- interrupt-controller: describes the 88pm8xx as an interrupt controller > +- #interrupt-cells : should be 1. > + - The cell is the 88pm8xx local IRQ number > + > +88pm8xx family of devices consists of varied group of sub-devices: what about using "88pm80x family of devices..."? for we also have another series of chip, with the name of 88pm88x.. > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Note: More device list will follow > + > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + }; > -- > 1.9.1 >
On Friday 26 June 2015 11:35 AM, Yi Zhang wrote: > On Thu, Jun 25, 2015 at 03:26:29PM +0800, Vaibhav Hiremath wrote: >> With addition of DT support to 88pm800 mfd driver, this patch >> adds new DT binding documentation along with respective properties. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt >> new file mode 100644 >> index 0000000..f56b751 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt >> @@ -0,0 +1,54 @@ >> +* Marvell 88PM8xx Power Management IC >> + >> +Required parent device properties: >> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" >> +- reg : the I2C slave address for the 88pm8xx chip >> +- interrupts : IRQ line for the 88pm8xx chip >> +- interrupt-controller: describes the 88pm8xx as an interrupt controller >> +- #interrupt-cells : should be 1. >> + - The cell is the 88pm8xx local IRQ number >> + >> +88pm8xx family of devices consists of varied group of sub-devices: > what about using "88pm80x family of devices..."? > for we also have another series of chip, with the name of 88pm88x.. I renamed it after Rob's suggestion, but at that time we didn't see 88pm88x coming. But I think now, I should stick to 88pm800 only, as it doesn't make match with both 88pm822 and 88pm860. Rob, let me know if you think otherwise. Thanks, Vaibhav
diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt new file mode 100644 index 0000000..f56b751 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt @@ -0,0 +1,54 @@ +* Marvell 88PM8xx Power Management IC + +Required parent device properties: +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" +- reg : the I2C slave address for the 88pm8xx chip +- interrupts : IRQ line for the 88pm8xx chip +- interrupt-controller: describes the 88pm8xx as an interrupt controller +- #interrupt-cells : should be 1. + - The cell is the 88pm8xx local IRQ number + +88pm8xx family of devices consists of varied group of sub-devices: + +Device Supply Names Description +------ ------------ ----------- +88pm80x-onkey : : On key +88pm80x-rtc : : RTC +88pm80x-regulator : : Regulators + +Note: More device list will follow + +Example: + + pmic: 88pm800@30 { + compatible = "marvell,88pm800"; + reg = <0x30>; + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; + interrupt-parent = <&gic>; + interrupt-controller; + #interrupt-cells = <1>; + + regulators { + compatible = "marvell,88pm80x-regulator"; + + buck1a: BUCK1A { + regulator-name = "BUCK1A"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1: LDO1 { + regulator-name = "LDO1"; + regulator-min-microvolt = <1700000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; + + rtc { + compatible = "marvell,88pm80x-rtc"; + }; + };
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt