| Message ID | 1435320432-4855-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e1c75f4d3ecf127032f2511aba76927a8703c1d |
| Headers | show |
Acked-by: Ranjit Waghmode <ranjitw@xilinx.com> > -----Original Message----- > From: Geert Uytterhoeven [mailto:geert@linux-m68k.org] > Sent: Friday, June 26, 2015 5:37 PM > To: Mark Brown; Ranjit Abhimanyu Waghmode > Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Geert > Uytterhoeven > Subject: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA > > If NO_DMA=y: > > ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! > ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! > ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! > > Add a dependency on HAS_DMA to fix this. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index > 1c0b261b66fcfdcb..b787b515bd73322b 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA > > config SPI_ZYNQMP_GQSPI > tristate "Xilinx ZynqMP GQSPI controller" > - depends on SPI_MASTER > + depends on SPI_MASTER && HAS_DMA > help > Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC. > > -- > 1.9.1 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 29, 2015 at 06:00:08AM +0000, Ranjit Abhimanyu Waghmode wrote: > Acked-by: Ranjit Waghmode <ranjitw@xilinx.com> Please don't top post and... > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. ...don't include nonsensical stuff like this in mailing list postings.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 1c0b261b66fcfdcb..b787b515bd73322b 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA config SPI_ZYNQMP_GQSPI tristate "Xilinx ZynqMP GQSPI controller" - depends on SPI_MASTER + depends on SPI_MASTER && HAS_DMA help Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
If NO_DMA=y: ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined! Add a dependency on HAS_DMA to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)