| Message ID | 1434468977-25651-1-git-send-email-sprabhu@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
merged into cifs-2.6.git Let me know if any other patches that you want to review ASAP for merge window. On Tue, Jun 16, 2015 at 10:36 AM, Sachin Prabhu <sprabhu@redhat.com> wrote: > In a dfs setup where the client transitions from a server which supports > posix paths to a server which doesn't support posix paths, the flag > CIFS_MOUNT_POSIX_PATHS is not reset. This leads to the wrong directory > separator being used causing smb commands to fail. > > Consider the following case where a dfs share on a samba server points > to a share on windows smb server. > # mount -t cifs -o .. //vm140-31/dfsroot/testwin/ > # ls -l /mnt; touch /mnt/a > total 0 > touch: cannot touch ‘/mnt/a’: No such file or directory > > Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> > --- > fs/cifs/connect.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 8383d5e..a59370b 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -3461,6 +3461,8 @@ try_mount_again: > else if (ses) > cifs_put_smb_ses(ses); > > + cifs_sb->mnt_cifs_flags &= ~CIFS_MOUNT_POSIX_PATHS; > + > free_xid(xid); > } > #endif > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 16 Jun 2015 16:36:17 +0100 Sachin Prabhu <sprabhu@redhat.com> wrote: > In a dfs setup where the client transitions from a server which supports > posix paths to a server which doesn't support posix paths, the flag > CIFS_MOUNT_POSIX_PATHS is not reset. This leads to the wrong directory > separator being used causing smb commands to fail. > > Consider the following case where a dfs share on a samba server points > to a share on windows smb server. > # mount -t cifs -o .. //vm140-31/dfsroot/testwin/ > # ls -l /mnt; touch /mnt/a > total 0 > touch: cannot touch ‘/mnt/a’: No such file or directory > > Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> > --- > fs/cifs/connect.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 8383d5e..a59370b 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -3461,6 +3461,8 @@ try_mount_again: > else if (ses) > cifs_put_smb_ses(ses); > > + cifs_sb->mnt_cifs_flags &= ~CIFS_MOUNT_POSIX_PATHS; > + > free_xid(xid); > } > #endif Acked-by: Jeff Layton <jlayton@samba.org> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 8383d5e..a59370b 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -3461,6 +3461,8 @@ try_mount_again: else if (ses) cifs_put_smb_ses(ses); + cifs_sb->mnt_cifs_flags &= ~CIFS_MOUNT_POSIX_PATHS; + free_xid(xid); } #endif
In a dfs setup where the client transitions from a server which supports posix paths to a server which doesn't support posix paths, the flag CIFS_MOUNT_POSIX_PATHS is not reset. This leads to the wrong directory separator being used causing smb commands to fail. Consider the following case where a dfs share on a samba server points to a share on windows smb server. # mount -t cifs -o .. //vm140-31/dfsroot/testwin/ # ls -l /mnt; touch /mnt/a total 0 touch: cannot touch ‘/mnt/a’: No such file or directory Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> --- fs/cifs/connect.c | 2 ++ 1 file changed, 2 insertions(+)