| Message ID | 1435591877-18214-5-git-send-email-vaibhav.hiremath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Looks okay, > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..dec842f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,53 @@ > +* Marvell 88PM80x Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm80x family chip > +- interrupts : IRQ line for the 88pm80x family chip > +- interrupt-controller : describes the 88pm80x family chip as an interrupt > + controller > +- #interrupt-cells : should be 1. > + The cell is the 88pm80x local IRQ number > + > +88pm80x family of devices consists of varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + }; > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> (once again, too early hit return) Looks okay. Just a hint - put the binding at beginning of the patchset. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
On Tuesday 30 June 2015 06:01 AM, Krzysztof Kozlowski wrote: > 2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: >> With addition of DT support to 88pm800 mfd driver, this patch >> adds new DT binding documentation along with respective properties. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > > (once again, too early hit return) > > Looks okay. Just a hint - put the binding at beginning of the patchset. > OK, next time onwards will take care of it. > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Thanks for your review. Thanks, Vaibhav
On Tue, 30 Jun 2015, Krzysztof Koz?owski wrote: > 2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: > > With addition of DT support to 88pm800 mfd driver, this patch > > adds new DT binding documentation along with respective properties. > > > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > > Looks okay, You forgot to add your *-by. > > --- > > Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > > new file mode 100644 > > index 0000000..dec842f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > > @@ -0,0 +1,53 @@ > > +* Marvell 88PM80x Power Management IC > > + > > +Required parent device properties: > > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > > +- reg : the I2C slave address for the 88pm80x family chip > > +- interrupts : IRQ line for the 88pm80x family chip > > +- interrupt-controller : describes the 88pm80x family chip as an interrupt > > + controller > > +- #interrupt-cells : should be 1. > > + The cell is the 88pm80x local IRQ number > > + > > +88pm80x family of devices consists of varied group of sub-devices: > > + > > +Device Supply Names Description > > +------ ------------ ----------- > > +88pm80x-onkey : : On key > > +88pm80x-rtc : : RTC > > +88pm80x-regulator : : Regulators > > + > > +Example: > > + > > + pmic: 88pm800@30 { > > + compatible = "marvell,88pm800"; > > + reg = <0x30>; > > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-parent = <&gic>; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + > > + regulators { > > + compatible = "marvell,88pm80x-regulator"; > > + > > + buck1a: BUCK1A { > > + regulator-name = "BUCK1A"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > + ldo1: LDO1 { > > + regulator-name = "LDO1"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + }; > > + > > + rtc { > > + compatible = "marvell,88pm80x-rtc"; > > + }; > > + }; > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
2015-07-01 16:43 GMT+09:00 Lee Jones <lee.jones@linaro.org>: > On Tue, 30 Jun 2015, Krzysztof Koz?owski wrote: > >> 2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>: >> > With addition of DT support to 88pm800 mfd driver, this patch >> > adds new DT binding documentation along with respective properties. >> > >> > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> >> Looks okay, > > You forgot to add your *-by. Yeah, I hit the "enter" too early. I sent later another email. Sorry for the noise. Best regards, Krzysztof
On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> Didn't I ack this already? You should add it when you send subsequent versions. The maintainer will add it if there aren't any subsequent versions. Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..dec842f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,53 @@ > +* Marvell 88PM80x Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm80x family chip > +- interrupts : IRQ line for the 88pm80x family chip > +- interrupt-controller : describes the 88pm80x family chip as an interrupt > + controller > +- #interrupt-cells : should be 1. > + The cell is the 88pm80x local IRQ number > + > +88pm80x family of devices consists of varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + }; > -- > 1.9.1 >
On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote: > On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath > <vaibhav.hiremath@linaro.org> wrote: >> With addition of DT support to 88pm800 mfd driver, this patch >> adds new DT binding documentation along with respective properties. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > > Didn't I ack this already? You should add it when you send subsequent > versions. The maintainer will add it if there aren't any subsequent > versions. > > Acked-by: Rob Herring <robh@kernel.org> > Sorry Rob. Infact I did ask you as well. Probably you missed it. Patch got changed after your ack, I did some changes based on few review comments, from Lee and others. Anyway, thanks for ack. Can you please queue this? Thanks, Vaibhav >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt >> new file mode 100644 >> index 0000000..dec842f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt >> @@ -0,0 +1,53 @@ >> +* Marvell 88PM80x Power Management IC >> + >> +Required parent device properties: >> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" >> +- reg : the I2C slave address for the 88pm80x family chip >> +- interrupts : IRQ line for the 88pm80x family chip >> +- interrupt-controller : describes the 88pm80x family chip as an interrupt >> + controller >> +- #interrupt-cells : should be 1. >> + The cell is the 88pm80x local IRQ number >> + >> +88pm80x family of devices consists of varied group of sub-devices: >> + >> +Device Supply Names Description >> +------ ------------ ----------- >> +88pm80x-onkey : : On key >> +88pm80x-rtc : : RTC >> +88pm80x-regulator : : Regulators >> + >> +Example: >> + >> + pmic: 88pm800@30 { >> + compatible = "marvell,88pm800"; >> + reg = <0x30>; >> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-parent = <&gic>; >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + >> + regulators { >> + compatible = "marvell,88pm80x-regulator"; >> + >> + buck1a: BUCK1A { >> + regulator-name = "BUCK1A"; >> + regulator-min-microvolt = <600000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + ldo1: LDO1 { >> + regulator-name = "LDO1"; >> + regulator-min-microvolt = <1700000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + }; >> + >> + rtc { >> + compatible = "marvell,88pm80x-rtc"; >> + }; >> + }; >> -- >> 1.9.1 >>
On Wed, Jul 1, 2015 at 11:21 AM, Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote: > > > On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote: >> >> On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath >> <vaibhav.hiremath@linaro.org> wrote: >>> >>> With addition of DT support to 88pm800 mfd driver, this patch >>> adds new DT binding documentation along with respective properties. >>> >>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> >> >> Didn't I ack this already? You should add it when you send subsequent >> versions. The maintainer will add it if there aren't any subsequent >> versions. >> >> Acked-by: Rob Herring <robh@kernel.org> >> > > Sorry Rob. Infact I did ask you as well. Probably you missed it. > > Patch got changed after your ack, I did some changes based on few > review comments, from Lee and others. Ok, then it is up to your judgement whether the ack should still apply. If not, you should note that. > Anyway, thanks for ack. Can you please queue this? I'm assuming Lee is taking the whole series. Rob
On Wednesday 01 July 2015 10:47 PM, Rob Herring wrote: > On Wed, Jul 1, 2015 at 11:21 AM, Vaibhav Hiremath > <vaibhav.hiremath@linaro.org> wrote: >> >> >> On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote: >>> >>> On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath >>> <vaibhav.hiremath@linaro.org> wrote: >>>> >>>> With addition of DT support to 88pm800 mfd driver, this patch >>>> adds new DT binding documentation along with respective properties. >>>> >>>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >>> >>> >>> Didn't I ack this already? You should add it when you send subsequent >>> versions. The maintainer will add it if there aren't any subsequent >>> versions. >>> >>> Acked-by: Rob Herring <robh@kernel.org> >>> >> >> Sorry Rob. Infact I did ask you as well. Probably you missed it. >> >> Patch got changed after your ack, I did some changes based on few >> review comments, from Lee and others. > > Ok, then it is up to your judgement whether the ack should still > apply. If not, you should note that. > I did. I did mention it in my cover letter. >> Anyway, thanks for ack. Can you please queue this? > > I'm assuming Lee is taking the whole series. > Ok. Thanks, Vaibhav
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt For my own reference: Acked-by: Lee Jones <lee.jones@linaro.org> Yes, I plan to take this through the MFD tree. > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..dec842f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,53 @@ > +* Marvell 88PM80x Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm80x family chip > +- interrupts : IRQ line for the 88pm80x family chip > +- interrupt-controller : describes the 88pm80x family chip as an interrupt > + controller > +- #interrupt-cells : should be 1. > + The cell is the 88pm80x local IRQ number > + > +88pm80x family of devices consists of varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + };
diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt new file mode 100644 index 0000000..dec842f --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt @@ -0,0 +1,53 @@ +* Marvell 88PM80x Power Management IC + +Required parent device properties: +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" +- reg : the I2C slave address for the 88pm80x family chip +- interrupts : IRQ line for the 88pm80x family chip +- interrupt-controller : describes the 88pm80x family chip as an interrupt + controller +- #interrupt-cells : should be 1. + The cell is the 88pm80x local IRQ number + +88pm80x family of devices consists of varied group of sub-devices: + +Device Supply Names Description +------ ------------ ----------- +88pm80x-onkey : : On key +88pm80x-rtc : : RTC +88pm80x-regulator : : Regulators + +Example: + + pmic: 88pm800@30 { + compatible = "marvell,88pm800"; + reg = <0x30>; + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; + interrupt-parent = <&gic>; + interrupt-controller; + #interrupt-cells = <1>; + + regulators { + compatible = "marvell,88pm80x-regulator"; + + buck1a: BUCK1A { + regulator-name = "BUCK1A"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; + + ldo1: LDO1 { + regulator-name = "LDO1"; + regulator-min-microvolt = <1700000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + }; + + rtc { + compatible = "marvell,88pm80x-rtc"; + }; + };
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt