| Message ID | 1436274047-3274-1-git-send-email-k.kozlowski.k@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote: > > The platform_device_id is not modified by the driver and core uses it as > const. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Acked-by: Jingoo Han <jingoohan1@gmail.com> Best regards, Jingoo Han > --- > drivers/video/fbdev/s3c-fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c > index 7e3a05fc47aa..f72dd12456f9 100644 > --- a/drivers/video/fbdev/s3c-fb.c > +++ b/drivers/video/fbdev/s3c-fb.c > @@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = { > }, > }; > > -static struct platform_device_id s3c_fb_driver_ids[] = { > +static const struct platform_device_id s3c_fb_driver_ids[] = { > { > .name = "s3c-fb", > .driver_data = (unsigned long)&s3c_fb_data_64xx, > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>: > > On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote: >> >> The platform_device_id is not modified by the driver and core uses it as >> const. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> > > Acked-by: Jingoo Han <jingoohan1@gmail.com> > > Best regards, > Jingoo Han Seems nobody is picking it up, so I merge it through Samsung-SoC tree. If there are any objections please let me know. Best regards, Krzysztof > >> --- >> drivers/video/fbdev/s3c-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c >> index 7e3a05fc47aa..f72dd12456f9 100644 >> --- a/drivers/video/fbdev/s3c-fb.c >> +++ b/drivers/video/fbdev/s3c-fb.c >> @@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = { >> }, >> }; >> >> -static struct platform_device_id s3c_fb_driver_ids[] = { >> +static const struct platform_device_id s3c_fb_driver_ids[] = { >> { >> .name = "s3c-fb", >> .driver_data = (unsigned long)&s3c_fb_data_64xx, >> -- >> 2.1.4 >> -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24/07/15 09:12, Krzysztof Kozlowski wrote: > 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>: >> >> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote: >>> >>> The platform_device_id is not modified by the driver and core uses it as >>> const. >>> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> >> >> Acked-by: Jingoo Han <jingoohan1@gmail.com> >> >> Best regards, >> Jingoo Han > > Seems nobody is picking it up, so I merge it through Samsung-SoC tree. > If there are any objections please let me know. I can pick this up if you didn't already do that. Tomi
On 20.08.2015 18:16, Tomi Valkeinen wrote: > > > On 24/07/15 09:12, Krzysztof Kozlowski wrote: >> 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>: >>> >>> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote: >>>> >>>> The platform_device_id is not modified by the driver and core uses it as >>>> const. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> >>> >>> Acked-by: Jingoo Han <jingoohan1@gmail.com> >>> >>> Best regards, >>> Jingoo Han >> >> Seems nobody is picking it up, so I merge it through Samsung-SoC tree. >> If there are any objections please let me know. > > I can pick this up if you didn't already do that. Could you? It would be great. Kukjin did not pick it up so it is still waiting for some attention. :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21/08/15 04:46, Krzysztof Kozlowski wrote: > On 20.08.2015 18:16, Tomi Valkeinen wrote: >> >> >> On 24/07/15 09:12, Krzysztof Kozlowski wrote: >>> 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>: >>>> >>>> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote: >>>>> >>>>> The platform_device_id is not modified by the driver and core uses it as >>>>> const. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> >>>> >>>> Acked-by: Jingoo Han <jingoohan1@gmail.com> >>>> >>>> Best regards, >>>> Jingoo Han >>> >>> Seems nobody is picking it up, so I merge it through Samsung-SoC tree. >>> If there are any objections please let me know. >> >> I can pick this up if you didn't already do that. > > Could you? It would be great. > Kukjin did not pick it up so it is still waiting for some attention. :) Ok. I've queued this for 4.3. Tomi
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index 7e3a05fc47aa..f72dd12456f9 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = { }, }; -static struct platform_device_id s3c_fb_driver_ids[] = { +static const struct platform_device_id s3c_fb_driver_ids[] = { { .name = "s3c-fb", .driver_data = (unsigned long)&s3c_fb_data_64xx,
The platform_device_id is not modified by the driver and core uses it as const. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> --- drivers/video/fbdev/s3c-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)