| Message ID | 1436291591-31271-1-git-send-email-afenkart@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Andreas Fenkart <afenkart@gmail.com> [150707 10:55]: > Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to > be active low. The generic pm wakeirq does not override the active > high/low parameter, hence it must be specified correctly in the > device tree. > Mind that SDIO IRQ is active low as defined in the SDIO specification > > Signed-off-by: Andreas Fenkart <afenkart@gmail.com> > --- > Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > index 76bf087..74166a0 100644 > --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards. > pinctrl-1 = <&mmc1_idle>; > pinctrl-2 = <&mmc1_sleep>; > ... > - interrupts-extended = <&intc 64 &gpio2 28 0>; > + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>; > }; > > mmc1_idle : pinmux_cirq_pin { Looks good to me: Acked-by: Tony Lindgren <tony@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7 July 2015 at 19:53, Andreas Fenkart <afenkart@gmail.com> wrote: > Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to > be active low. The generic pm wakeirq does not override the active > high/low parameter, hence it must be specified correctly in the > device tree. > Mind that SDIO IRQ is active low as defined in the SDIO specification > > Signed-off-by: Andreas Fenkart <afenkart@gmail.com> Thanks, applied! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > index 76bf087..74166a0 100644 > --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards. > pinctrl-1 = <&mmc1_idle>; > pinctrl-2 = <&mmc1_sleep>; > ... > - interrupts-extended = <&intc 64 &gpio2 28 0>; > + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>; > }; > > mmc1_idle : pinmux_cirq_pin { > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 76bf087..74166a0 100644 --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt @@ -102,7 +102,7 @@ not every application needs SDIO irq, e.g. MMC cards. pinctrl-1 = <&mmc1_idle>; pinctrl-2 = <&mmc1_sleep>; ... - interrupts-extended = <&intc 64 &gpio2 28 0>; + interrupts-extended = <&intc 64 &gpio2 28 GPIO_ACTIVE_LOW>; }; mmc1_idle : pinmux_cirq_pin {
Before 5b83b2234be6733cf the driver was hard coding the wakeup irq to be active low. The generic pm wakeirq does not override the active high/low parameter, hence it must be specified correctly in the device tree. Mind that SDIO IRQ is active low as defined in the SDIO specification Signed-off-by: Andreas Fenkart <afenkart@gmail.com> --- Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)