diff mbox

tools/lib: improve clean target

Message ID 1434631938-12681-1-git-send-email-riku.voipio@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Riku Voipio June 18, 2015, 12:52 p.m. UTC 
From: Riku Voipio <riku.voipio@linaro.org>

The clean targets miss some .cmd and .d files.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 tools/lib/api/Makefile        | 2 +-
 tools/lib/traceevent/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Riku Voipio July 8, 2015, 6:22 p.m. UTC | #1 
On 18 June 2015 at 15:52,  <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> The clean targets miss some .cmd and .d files.

Is this patch slipping through cracks?

> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
>  tools/lib/api/Makefile        | 2 +-
>  tools/lib/traceevent/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
> index 8bd9606..fe1b02c 100644
> --- a/tools/lib/api/Makefile
> +++ b/tools/lib/api/Makefile
> @@ -36,7 +36,7 @@ $(LIBFILE): $(API_IN)
>
>  clean:
>         $(call QUIET_CLEAN, libapi) $(RM) $(LIBFILE); \
> -       find $(if $(OUTPUT),$(OUTPUT),.) -name \*.o | xargs $(RM)
> +       find $(if $(OUTPUT),$(OUTPUT),.) -name \*.o -or -name \*.o.cmd -or -name \*.o.d | xargs $(RM)
>
>  FORCE:
>
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 6daaff6..7851df1 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -268,7 +268,7 @@ install: install_lib
>
>  clean:
>         $(call QUIET_CLEAN, libtraceevent) \
> -               $(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d \
> +               $(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d .*.cmd \
>                 $(RM) TRACEEVENT-CFLAGS tags TAGS
>
>  PHONY += force plugins
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnaldo Carvalho de Melo July 8, 2015, 8:57 p.m. UTC | #2 
Em Wed, Jul 08, 2015 at 09:22:23PM +0300, Riku Voipio escreveu:
> On 18 June 2015 at 15:52,  <riku.voipio@linaro.org> wrote:
> > From: Riku Voipio <riku.voipio@linaro.org>
> >
> > The clean targets miss some .cmd and .d files.
> 
> Is this patch slipping through cracks?

Not anymore, applied to my perf/urgent branch, will go soon to Ingo,
piggybacking on some more urgent stuff.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
index 8bd9606..fe1b02c 100644
--- a/tools/lib/api/Makefile
+++ b/tools/lib/api/Makefile
@@ -36,7 +36,7 @@  $(LIBFILE): $(API_IN)
 
 clean:
 	$(call QUIET_CLEAN, libapi) $(RM) $(LIBFILE); \
-	find $(if $(OUTPUT),$(OUTPUT),.) -name \*.o | xargs $(RM)
+	find $(if $(OUTPUT),$(OUTPUT),.) -name \*.o -or -name \*.o.cmd -or -name \*.o.d | xargs $(RM)
 
 FORCE:
 
diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index 6daaff6..7851df1 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -268,7 +268,7 @@  install: install_lib
 
 clean:
 	$(call QUIET_CLEAN, libtraceevent) \
-		$(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d \
+		$(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d .*.cmd \
 		$(RM) TRACEEVENT-CFLAGS tags TAGS
 
 PHONY += force plugins