| Message ID | 1436935343-4437-4-git-send-email-rjui@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/15/2015 06:42 AM, Ray Jui wrote: > This patch adds support to Broadcom's iProc family of arm64 based SoCs > in the arm64 Kconfig and defconfig files > > Signed-off-by: Ray Jui <rjui@broadcom.com> > Reviewed-by: Scott Branden <sbranden@broadcom.com> > --- > arch/arm64/Kconfig | 5 +++++ > arch/arm64/configs/defconfig | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 318175f..969ef4a 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -162,6 +162,11 @@ source "kernel/Kconfig.freezer" > > menu "Platform selection" > > +config ARCH_BCM_IPROC > + bool "Broadcom iProc SoC Family" > + help > + This enables support for Broadcom iProc based SoCs > + Is this working correctly if we have ARCH_BCM_IPROC under ARM and ARM64? They are guarding the same SoC line, which now uses ARM64 CPUS. > config ARCH_EXYNOS > bool > help > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 4e17e7e..c83d51f 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -31,6 +31,7 @@ CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > # CONFIG_BLK_DEV_BSG is not set > # CONFIG_IOSCHED_DEADLINE is not set > +CONFIG_ARCH_BCM_IPROC=y > CONFIG_ARCH_EXYNOS7=y > CONFIG_ARCH_FSL_LS2085A=y > CONFIG_ARCH_HISI=y > @@ -102,6 +103,7 @@ CONFIG_SERIO_AMBAKMI=y > CONFIG_LEGACY_PTY_COUNT=16 > CONFIG_SERIAL_8250=y > CONFIG_SERIAL_8250_CONSOLE=y > +CONFIG_SERIAL_8250_DW=y > CONFIG_SERIAL_8250_MT6577=y > CONFIG_SERIAL_AMBA_PL011=y > CONFIG_SERIAL_AMBA_PL011_CONSOLE=y >
On 7/15/2015 2:53 PM, Hauke Mehrtens wrote: > On 07/15/2015 06:42 AM, Ray Jui wrote: >> This patch adds support to Broadcom's iProc family of arm64 based SoCs >> in the arm64 Kconfig and defconfig files >> >> Signed-off-by: Ray Jui <rjui@broadcom.com> >> Reviewed-by: Scott Branden <sbranden@broadcom.com> >> --- >> arch/arm64/Kconfig | 5 +++++ >> arch/arm64/configs/defconfig | 2 ++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 318175f..969ef4a 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -162,6 +162,11 @@ source "kernel/Kconfig.freezer" >> >> menu "Platform selection" >> >> +config ARCH_BCM_IPROC >> + bool "Broadcom iProc SoC Family" >> + help >> + This enables support for Broadcom iProc based SoCs >> + > > Is this working correctly if we have ARCH_BCM_IPROC under ARM and ARM64? > They are guarding the same SoC line, which now uses ARM64 CPUS. > Yes, since the "ARCH=" parameter from the compiler helps to route it to the right directory, arch/arm or arch/arm64, and you cannot compile both in a single image. Same case for other SoCs, e.g., tegra (ARCH_TEGRA), exynos (ARCH_EXYNOS), and etc. The benefit of sharing the same arch flag is that the device driver that exists in iProc family of SoCs (both arm32 and arm64) can be guarded or enabled properly. Thanks, Ray
On 15/07/15 15:03, Ray Jui wrote: > > > On 7/15/2015 2:53 PM, Hauke Mehrtens wrote: >> On 07/15/2015 06:42 AM, Ray Jui wrote: >>> This patch adds support to Broadcom's iProc family of arm64 based SoCs >>> in the arm64 Kconfig and defconfig files >>> >>> Signed-off-by: Ray Jui <rjui@broadcom.com> >>> Reviewed-by: Scott Branden <sbranden@broadcom.com> >>> --- >>> arch/arm64/Kconfig | 5 +++++ >>> arch/arm64/configs/defconfig | 2 ++ >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index 318175f..969ef4a 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -162,6 +162,11 @@ source "kernel/Kconfig.freezer" >>> >>> menu "Platform selection" >>> >>> +config ARCH_BCM_IPROC >>> + bool "Broadcom iProc SoC Family" >>> + help >>> + This enables support for Broadcom iProc based SoCs >>> + >> >> Is this working correctly if we have ARCH_BCM_IPROC under ARM and ARM64? >> They are guarding the same SoC line, which now uses ARM64 CPUS. >> > > Yes, since the "ARCH=" parameter from the compiler helps to route it to > the right directory, arch/arm or arch/arm64, and you cannot compile both > in a single image. Same case for other SoCs, e.g., tegra (ARCH_TEGRA), > exynos (ARCH_EXYNOS), and etc. > > The benefit of sharing the same arch flag is that the device driver that > exists in iProc family of SoCs (both arm32 and arm64) can be guarded or > enabled properly. Yes, I like that as well, better maintain a single symbol across two architectures than multiple across multiple architectures.
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 318175f..969ef4a 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -162,6 +162,11 @@ source "kernel/Kconfig.freezer" menu "Platform selection" +config ARCH_BCM_IPROC + bool "Broadcom iProc SoC Family" + help + This enables support for Broadcom iProc based SoCs + config ARCH_EXYNOS bool help diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 4e17e7e..c83d51f 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -31,6 +31,7 @@ CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y # CONFIG_BLK_DEV_BSG is not set # CONFIG_IOSCHED_DEADLINE is not set +CONFIG_ARCH_BCM_IPROC=y CONFIG_ARCH_EXYNOS7=y CONFIG_ARCH_FSL_LS2085A=y CONFIG_ARCH_HISI=y @@ -102,6 +103,7 @@ CONFIG_SERIO_AMBAKMI=y CONFIG_LEGACY_PTY_COUNT=16 CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y +CONFIG_SERIAL_8250_DW=y CONFIG_SERIAL_8250_MT6577=y CONFIG_SERIAL_AMBA_PL011=y CONFIG_SERIAL_AMBA_PL011_CONSOLE=y