| Message ID | 1436977965-7078-2-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16.07.2015 01:32, Javier Martinez Canillas wrote: > The Maxim max77802 Power Management IC has besides other devices, a set of > regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 > regulator, rtc and clock drivers") was supposed to enable the config option > for the regulator driver as a module but the final version that landed did > not include this. So this patch enables the needed Kconfig option. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Please describe why do you want to enable it (IOW who will benefit from enabling it?). This symbol was removed by Kukjin from your commit: [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] so justification would be welcomed. Beside the commit description I agree with the patch. Best regards, Krzysztof > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 4b93761d58d2..b07493997993 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -402,6 +402,7 @@ CONFIG_REGULATOR_MAX14577=m > CONFIG_REGULATOR_MAX8907=y > CONFIG_REGULATOR_MAX8973=y > CONFIG_REGULATOR_MAX77686=y > +CONFIG_REGULATOR_MAX77802=m > CONFIG_REGULATOR_MAX77693=m > CONFIG_REGULATOR_PALMAS=y > CONFIG_REGULATOR_S2MPS11=y >
Hello Krzysztof, Thanks for the feedback. On 07/16/2015 02:45 AM, Krzysztof Kozlowski wrote: > On 16.07.2015 01:32, Javier Martinez Canillas wrote: >> The Maxim max77802 Power Management IC has besides other devices, a set of >> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 >> regulator, rtc and clock drivers") was supposed to enable the config option >> for the regulator driver as a module but the final version that landed did >> not include this. So this patch enables the needed Kconfig option. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Please describe why do you want to enable it (IOW who will benefit from > enabling it?). This symbol was removed by Kukjin from your commit: > [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] > so justification would be welcomed. > You are right, sorry for not making the commit message clear. This PMIC is used by a couple of Exynos5 based boars such as the Peach Pit and Pi Chromebooks. I expect it to be found in other designs too just like the max77686 is found in many Exynos5 based boards. I'll add this to the commit message on v2. > Beside the commit description I agree with the patch. > Does this mean I can add your Reviewed-by to this patch as well? > Best regards, > Krzysztof > Best regards,
On 16.07.2015 14:44, Javier Martinez Canillas wrote: > Hello Krzysztof, > > Thanks for the feedback. > > On 07/16/2015 02:45 AM, Krzysztof Kozlowski wrote: >> On 16.07.2015 01:32, Javier Martinez Canillas wrote: >>> The Maxim max77802 Power Management IC has besides other devices, a set of >>> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 >>> regulator, rtc and clock drivers") was supposed to enable the config option >>> for the regulator driver as a module but the final version that landed did >>> not include this. So this patch enables the needed Kconfig option. >>> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> Please describe why do you want to enable it (IOW who will benefit from >> enabling it?). This symbol was removed by Kukjin from your commit: >> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] >> so justification would be welcomed. >> > > You are right, sorry for not making the commit message clear. This PMIC > is used by a couple of Exynos5 based boars such as the Peach Pit and Pi > Chromebooks. I expect it to be found in other designs too just like the > max77686 is found in many Exynos5 based boards. > > I'll add this to the commit message on v2. > >> Beside the commit description I agree with the patch. >> > > Does this mean I can add your Reviewed-by to this patch as well? With extended description (something similar to explanation in your other patches) yes, go ahead: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 4b93761d58d2..b07493997993 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -402,6 +402,7 @@ CONFIG_REGULATOR_MAX14577=m CONFIG_REGULATOR_MAX8907=y CONFIG_REGULATOR_MAX8973=y CONFIG_REGULATOR_MAX77686=y +CONFIG_REGULATOR_MAX77802=m CONFIG_REGULATOR_MAX77693=m CONFIG_REGULATOR_PALMAS=y CONFIG_REGULATOR_S2MPS11=y
The Maxim max77802 Power Management IC has besides other devices, a set of regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers") was supposed to enable the config option for the regulator driver as a module but the final version that landed did not include this. So this patch enables the needed Kconfig option. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)