| Message ID | 1437114567-17629-5-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: > The Maxim MAX77686 PMIC is a multi-function device with regulators, > clocks and a RTC. The DT bindings for the clocks are in a separate > file but the bindings for the regulators are inside the mfd part. > > To make it consistent with the clocks portion of the binding and > because is more natural to look for regulator bindings under the > bindings/regulator sub-directory, split the regulator portion of > the DT binding and add it as a separate file. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v2: > - Use a generic name for the max77686 node in the regulator example. > > Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- > .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ > 2 files changed, 74 insertions(+), 55 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt Putting regulator bindings under regulator directory seems logical so I am fine with it. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
Hello Krzysztof, On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: > 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >> The Maxim MAX77686 PMIC is a multi-function device with regulators, >> clocks and a RTC. The DT bindings for the clocks are in a separate >> file but the bindings for the regulators are inside the mfd part. >> >> To make it consistent with the clocks portion of the binding and >> because is more natural to look for regulator bindings under the >> bindings/regulator sub-directory, split the regulator portion of >> the DT binding and add it as a separate file. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> Changes in v2: >> - Use a generic name for the max77686 node in the regulator example. >> >> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >> 2 files changed, 74 insertions(+), 55 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt > > Putting regulator bindings under regulator directory seems logical so > I am fine with it. > > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Thanks a lot for your review. For completeness, I talked with Lee Jones over IRC yesterday asking him his opinion on whether MFD DT binding doc should contain all the info or if it should be split across different subsystems and he prefers the later. That's why I re-spun this series. > Best regards, > Krzysztof > -- Best regards,
2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: > Hello Krzysztof, > > On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: >> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>> The Maxim MAX77686 PMIC is a multi-function device with regulators, >>> clocks and a RTC. The DT bindings for the clocks are in a separate >>> file but the bindings for the regulators are inside the mfd part. >>> >>> To make it consistent with the clocks portion of the binding and >>> because is more natural to look for regulator bindings under the >>> bindings/regulator sub-directory, split the regulator portion of >>> the DT binding and add it as a separate file. >>> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>> >>> --- >>> >>> Changes in v2: >>> - Use a generic name for the max77686 node in the regulator example. >>> >>> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >>> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >>> 2 files changed, 74 insertions(+), 55 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt >> >> Putting regulator bindings under regulator directory seems logical so >> I am fine with it. >> >> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> > > Thanks a lot for your review. For completeness, I talked with Lee Jones > over IRC yesterday asking him his opinion on whether MFD DT binding doc > should contain all the info or if it should be split across different > subsystems and he prefers the later. That's why I re-spun this series. Okay, this sounds good. One more thing - can you update the maintainers file? The bindings documentation is mentioned there for max77686. Best regards, Krzysztof
Hello Krzysztof, On 07/17/2015 08:49 AM, Krzysztof Kozlowski wrote: > 2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >> Hello Krzysztof, >> >> On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: >>> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>>> The Maxim MAX77686 PMIC is a multi-function device with regulators, >>>> clocks and a RTC. The DT bindings for the clocks are in a separate >>>> file but the bindings for the regulators are inside the mfd part. >>>> >>>> To make it consistent with the clocks portion of the binding and >>>> because is more natural to look for regulator bindings under the >>>> bindings/regulator sub-directory, split the regulator portion of >>>> the DT binding and add it as a separate file. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>>> >>>> --- >>>> >>>> Changes in v2: >>>> - Use a generic name for the max77686 node in the regulator example. >>>> >>>> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >>>> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >>>> 2 files changed, 74 insertions(+), 55 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt >>> >>> Putting regulator bindings under regulator directory seems logical so >>> I am fine with it. >>> >>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> >> >> Thanks a lot for your review. For completeness, I talked with Lee Jones >> over IRC yesterday asking him his opinion on whether MFD DT binding doc >> should contain all the info or if it should be split across different >> subsystems and he prefers the later. That's why I re-spun this series. > > Okay, this sounds good. > > One more thing - can you update the maintainers file? The bindings > documentation is mentioned there for max77686. > Sure, I see that also the max77802 files are missing in that section. I'll included that as well. But I'll wait to see if Lee pick this series before posting the patch for MAINTAINERS. > Best regards, > Krzysztof > Best regards,
2015-07-17 15:59 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: > Hello Krzysztof, > > On 07/17/2015 08:49 AM, Krzysztof Kozlowski wrote: >> 2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>> Hello Krzysztof, >>> >>> On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: >>>> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>>>> The Maxim MAX77686 PMIC is a multi-function device with regulators, >>>>> clocks and a RTC. The DT bindings for the clocks are in a separate >>>>> file but the bindings for the regulators are inside the mfd part. >>>>> >>>>> To make it consistent with the clocks portion of the binding and >>>>> because is more natural to look for regulator bindings under the >>>>> bindings/regulator sub-directory, split the regulator portion of >>>>> the DT binding and add it as a separate file. >>>>> >>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>>>> >>>>> --- >>>>> >>>>> Changes in v2: >>>>> - Use a generic name for the max77686 node in the regulator example. >>>>> >>>>> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >>>>> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >>>>> 2 files changed, 74 insertions(+), 55 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt >>>> >>>> Putting regulator bindings under regulator directory seems logical so >>>> I am fine with it. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>>> >>> >>> Thanks a lot for your review. For completeness, I talked with Lee Jones >>> over IRC yesterday asking him his opinion on whether MFD DT binding doc >>> should contain all the info or if it should be split across different >>> subsystems and he prefers the later. That's why I re-spun this series. >> >> Okay, this sounds good. >> >> One more thing - can you update the maintainers file? The bindings >> documentation is mentioned there for max77686. >> > > Sure, I see that also the max77802 files are missing in that section. > I'll included that as well. The max717802 are not there because they are not part of this maintainership :) . I wasn't involved in development of them (except reviewing) so I did not put myself as their maintainer. > But I'll wait to see if Lee pick this > series before posting the patch for MAINTAINERS. I think the maintainers should be updated in the same patchset (or even patch) to keep the state consistent. Best regards, Krzysztof
Hello Krzysztof, On 07/17/2015 09:11 AM, Krzysztof Kozlowski wrote: > 2015-07-17 15:59 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >> Hello Krzysztof, >> >> On 07/17/2015 08:49 AM, Krzysztof Kozlowski wrote: >>> 2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>>> Hello Krzysztof, >>>> >>>> On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote: >>>>> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: >>>>>> The Maxim MAX77686 PMIC is a multi-function device with regulators, >>>>>> clocks and a RTC. The DT bindings for the clocks are in a separate >>>>>> file but the bindings for the regulators are inside the mfd part. >>>>>> >>>>>> To make it consistent with the clocks portion of the binding and >>>>>> because is more natural to look for regulator bindings under the >>>>>> bindings/regulator sub-directory, split the regulator portion of >>>>>> the DT binding and add it as a separate file. >>>>>> >>>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>>>>> >>>>>> --- >>>>>> >>>>>> Changes in v2: >>>>>> - Use a generic name for the max77686 node in the regulator example. >>>>>> >>>>>> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- >>>>>> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ >>>>>> 2 files changed, 74 insertions(+), 55 deletions(-) >>>>>> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt >>>>> >>>>> Putting regulator bindings under regulator directory seems logical so >>>>> I am fine with it. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>>>> >>>> >>>> Thanks a lot for your review. For completeness, I talked with Lee Jones >>>> over IRC yesterday asking him his opinion on whether MFD DT binding doc >>>> should contain all the info or if it should be split across different >>>> subsystems and he prefers the later. That's why I re-spun this series. >>> >>> Okay, this sounds good. >>> >>> One more thing - can you update the maintainers file? The bindings >>> documentation is mentioned there for max77686. >>> >> >> Sure, I see that also the max77802 files are missing in that section. >> I'll included that as well. > > The max717802 are not there because they are not part of this > maintainership :) . I wasn't involved in development of them (except > reviewing) so I did not put myself as their maintainer. > Fair enough, I guess I should add an entry for max77802 then and volunteer myself as maintainer since after all I added the driver. >> But I'll wait to see if Lee pick this >> series before posting the patch for MAINTAINERS. > > I think the maintainers should be updated in the same patchset (or > even patch) to keep the state consistent. > Ok, I'll post a patch then to be applied on top of this series. I could re-spin the whole series and add it to $subject but I'm not sure if is worth it since it's only documentation and I prefer to avoid spaming Lee and Mark with yet another revision. > Best regards, > Krzysztof > Best regards,
On Fri, 17 Jul 2015, Javier Martinez Canillas wrote: > The Maxim MAX77686 PMIC is a multi-function device with regulators, > clocks and a RTC. The DT bindings for the clocks are in a separate > file but the bindings for the regulators are inside the mfd part. > > To make it consistent with the clocks portion of the binding and > because is more natural to look for regulator bindings under the > bindings/regulator sub-directory, split the regulator portion of > the DT binding and add it as a separate file. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v2: > - Use a generic name for the max77686 node in the regulator example. > > Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- > .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ > 2 files changed, 74 insertions(+), 55 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt I'm fine with this, but still needs Marks Ack before I can do anything with it. Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt > index d2ed3c20a5c3..c5aeca609b1f 100644 > --- a/Documentation/devicetree/bindings/mfd/max77686.txt > +++ b/Documentation/devicetree/bindings/mfd/max77686.txt > @@ -8,7 +8,8 @@ client while probing.This document describes the binding for mfd device and > PMIC submodule. > > Binding for the built-in 32k clock generator block is defined separately > -in bindings/clk/maxim,max77686.txt file. > +in the bindings/clk/maxim,max77686.txt file and binding for the regulators > +is defined in the bindings/regulator/max77686.txt file. > > Required properties: > - compatible : Must be "maxim,max77686"; > @@ -16,36 +17,6 @@ Required properties: > - interrupts : This i2c device has an IRQ line connected to the main SoC. > - interrupt-parent : The parent interrupt controller. > > -Optional node: > -- voltage-regulators : The regulators of max77686 have to be instantiated > - under subnode named "voltage-regulators" using the following format. > - > - regulator_name { > - regulator-compatible = LDOn/BUCKn > - standard regulator constraints.... > - }; > - refer Documentation/devicetree/bindings/regulator/regulator.txt > - > - The regulator node's name should be initialized with a string > -to get matched with their hardware counterparts as follow: > - > - -LDOn : for LDOs, where n can lie in range 1 to 26. > - example: LDO1, LDO2, LDO26. > - -BUCKn : for BUCKs, where n can lie in range 1 to 9. > - example: BUCK1, BUCK5, BUCK9. > - > - Regulators which can be turned off during system suspend: > - -LDOn : 2, 6-8, 10-12, 14-16, > - -BUCKn : 1-4. > - Use standard regulator bindings for it ('regulator-off-in-suspend'). > - > - LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable > - control. To turn this feature on this property must be added to the regulator > - sub-node: > - - maxim,ena-gpios : one GPIO specifier enable control (the gpio > - flags are actually ignored and always > - ACTIVE_HIGH is used) > - > Example: > > max77686: pmic@09 { > @@ -53,27 +24,4 @@ Example: > interrupt-parent = <&wakeup_eint>; > interrupts = <26 0>; > reg = <0x09>; > - > - voltage-regulators { > - ldo11_reg: LDO11 { > - regulator-name = "vdd_ldo11"; > - regulator-min-microvolt = <1900000>; > - regulator-max-microvolt = <1900000>; > - regulator-always-on; > - }; > - > - buck1_reg: BUCK1 { > - regulator-name = "vdd_mif"; > - regulator-min-microvolt = <950000>; > - regulator-max-microvolt = <1300000>; > - regulator-always-on; > - regulator-boot-on; > - }; > - > - buck9_reg: BUCK9 { > - regulator-name = "CAM_ISP_CORE_1.2V"; > - regulator-min-microvolt = <1000000>; > - regulator-max-microvolt = <1200000>; > - maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>; > - }; > - } > + }; > diff --git a/Documentation/devicetree/bindings/regulator/max77686.txt b/Documentation/devicetree/bindings/regulator/max77686.txt > new file mode 100644 > index 000000000000..831cbd3cd965 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/max77686.txt > @@ -0,0 +1,71 @@ > +Binding for Maxim MAX77686 regulators > + > +This is a part of the device tree bindings of MAX77686 multi-function device. > +More information can be found in bindings/mfd/max77686.txt file. > + > +The MAX77686 PMIC has 9 high-efficiency Buck and 26 Low-dropout (LDO) > +regulators that can be controlled over I2C. > + > +Following properties should be present in main device node of the MFD chip. > + > +Optional node: > +- voltage-regulators : The regulators of max77686 have to be instantiated > + under subnode named "voltage-regulators" using the following format. > + > + regulator_name { > + regulator-compatible = LDOn/BUCKn > + standard regulator constraints.... > + }; > + refer Documentation/devicetree/bindings/regulator/regulator.txt > + > + The regulator node's name should be initialized with a string > +to get matched with their hardware counterparts as follow: > + > + -LDOn : for LDOs, where n can lie in range 1 to 26. > + example: LDO1, LDO2, LDO26. > + -BUCKn : for BUCKs, where n can lie in range 1 to 9. > + example: BUCK1, BUCK5, BUCK9. > + > + Regulators which can be turned off during system suspend: > + -LDOn : 2, 6-8, 10-12, 14-16, > + -BUCKn : 1-4. > + Use standard regulator bindings for it ('regulator-off-in-suspend'). > + > + LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable > + control. To turn this feature on this property must be added to the regulator > + sub-node: > + - maxim,ena-gpios : one GPIO specifier enable control (the gpio > + flags are actually ignored and always > + ACTIVE_HIGH is used) > + > +Example: > + > + max77686: pmic@09 { > + compatible = "maxim,max77686"; > + interrupt-parent = <&wakeup_eint>; > + interrupts = <26 0>; > + reg = <0x09>; > + > + voltage-regulators { > + ldo11_reg: LDO11 { > + regulator-name = "vdd_ldo11"; > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <1900000>; > + regulator-always-on; > + }; > + > + buck1_reg: BUCK1 { > + regulator-name = "vdd_mif"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <1300000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + buck9_reg: BUCK9 { > + regulator-name = "CAM_ISP_CORE_1.2V"; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1200000>; > + maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>; > + }; > + };
diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt index d2ed3c20a5c3..c5aeca609b1f 100644 --- a/Documentation/devicetree/bindings/mfd/max77686.txt +++ b/Documentation/devicetree/bindings/mfd/max77686.txt @@ -8,7 +8,8 @@ client while probing.This document describes the binding for mfd device and PMIC submodule. Binding for the built-in 32k clock generator block is defined separately -in bindings/clk/maxim,max77686.txt file. +in the bindings/clk/maxim,max77686.txt file and binding for the regulators +is defined in the bindings/regulator/max77686.txt file. Required properties: - compatible : Must be "maxim,max77686"; @@ -16,36 +17,6 @@ Required properties: - interrupts : This i2c device has an IRQ line connected to the main SoC. - interrupt-parent : The parent interrupt controller. -Optional node: -- voltage-regulators : The regulators of max77686 have to be instantiated - under subnode named "voltage-regulators" using the following format. - - regulator_name { - regulator-compatible = LDOn/BUCKn - standard regulator constraints.... - }; - refer Documentation/devicetree/bindings/regulator/regulator.txt - - The regulator node's name should be initialized with a string -to get matched with their hardware counterparts as follow: - - -LDOn : for LDOs, where n can lie in range 1 to 26. - example: LDO1, LDO2, LDO26. - -BUCKn : for BUCKs, where n can lie in range 1 to 9. - example: BUCK1, BUCK5, BUCK9. - - Regulators which can be turned off during system suspend: - -LDOn : 2, 6-8, 10-12, 14-16, - -BUCKn : 1-4. - Use standard regulator bindings for it ('regulator-off-in-suspend'). - - LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable - control. To turn this feature on this property must be added to the regulator - sub-node: - - maxim,ena-gpios : one GPIO specifier enable control (the gpio - flags are actually ignored and always - ACTIVE_HIGH is used) - Example: max77686: pmic@09 { @@ -53,27 +24,4 @@ Example: interrupt-parent = <&wakeup_eint>; interrupts = <26 0>; reg = <0x09>; - - voltage-regulators { - ldo11_reg: LDO11 { - regulator-name = "vdd_ldo11"; - regulator-min-microvolt = <1900000>; - regulator-max-microvolt = <1900000>; - regulator-always-on; - }; - - buck1_reg: BUCK1 { - regulator-name = "vdd_mif"; - regulator-min-microvolt = <950000>; - regulator-max-microvolt = <1300000>; - regulator-always-on; - regulator-boot-on; - }; - - buck9_reg: BUCK9 { - regulator-name = "CAM_ISP_CORE_1.2V"; - regulator-min-microvolt = <1000000>; - regulator-max-microvolt = <1200000>; - maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>; - }; - } + }; diff --git a/Documentation/devicetree/bindings/regulator/max77686.txt b/Documentation/devicetree/bindings/regulator/max77686.txt new file mode 100644 index 000000000000..831cbd3cd965 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/max77686.txt @@ -0,0 +1,71 @@ +Binding for Maxim MAX77686 regulators + +This is a part of the device tree bindings of MAX77686 multi-function device. +More information can be found in bindings/mfd/max77686.txt file. + +The MAX77686 PMIC has 9 high-efficiency Buck and 26 Low-dropout (LDO) +regulators that can be controlled over I2C. + +Following properties should be present in main device node of the MFD chip. + +Optional node: +- voltage-regulators : The regulators of max77686 have to be instantiated + under subnode named "voltage-regulators" using the following format. + + regulator_name { + regulator-compatible = LDOn/BUCKn + standard regulator constraints.... + }; + refer Documentation/devicetree/bindings/regulator/regulator.txt + + The regulator node's name should be initialized with a string +to get matched with their hardware counterparts as follow: + + -LDOn : for LDOs, where n can lie in range 1 to 26. + example: LDO1, LDO2, LDO26. + -BUCKn : for BUCKs, where n can lie in range 1 to 9. + example: BUCK1, BUCK5, BUCK9. + + Regulators which can be turned off during system suspend: + -LDOn : 2, 6-8, 10-12, 14-16, + -BUCKn : 1-4. + Use standard regulator bindings for it ('regulator-off-in-suspend'). + + LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable + control. To turn this feature on this property must be added to the regulator + sub-node: + - maxim,ena-gpios : one GPIO specifier enable control (the gpio + flags are actually ignored and always + ACTIVE_HIGH is used) + +Example: + + max77686: pmic@09 { + compatible = "maxim,max77686"; + interrupt-parent = <&wakeup_eint>; + interrupts = <26 0>; + reg = <0x09>; + + voltage-regulators { + ldo11_reg: LDO11 { + regulator-name = "vdd_ldo11"; + regulator-min-microvolt = <1900000>; + regulator-max-microvolt = <1900000>; + regulator-always-on; + }; + + buck1_reg: BUCK1 { + regulator-name = "vdd_mif"; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <1300000>; + regulator-always-on; + regulator-boot-on; + }; + + buck9_reg: BUCK9 { + regulator-name = "CAM_ISP_CORE_1.2V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1200000>; + maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>; + }; + };
The Maxim MAX77686 PMIC is a multi-function device with regulators, clocks and a RTC. The DT bindings for the clocks are in a separate file but the bindings for the regulators are inside the mfd part. To make it consistent with the clocks portion of the binding and because is more natural to look for regulator bindings under the bindings/regulator sub-directory, split the regulator portion of the DT binding and add it as a separate file. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: - Use a generic name for the max77686 node in the regulator example. Documentation/devicetree/bindings/mfd/max77686.txt | 58 +----------------- .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++ 2 files changed, 74 insertions(+), 55 deletions(-) create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt