| Message ID | 1434552997-3562-1-git-send-email-ap420073@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Taehee Yoo <ap420073@gmail.com> writes: > The variable "fw_version" is used in the _ResetDigitalProcedure1(). > but It is not initialized. so I add init codes for "fw_version" and > "fw_subversion". > > Signed-off-by: Taehee Yoo <ap420073@gmail.com> > --- > V3 - Fix sparse warning. > V2 - Moved new statements into location where header is known to exist. I have already applied v2 and v3 won't apply anymore. What you need to do is to create a new patch against wireless-drivers-next (on top of v2) which fixes the sparse warning.
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c index 29983bc..0142070 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c +++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c @@ -240,6 +240,8 @@ int rtl92c_download_fw(struct ieee80211_hw *hw) pfwheader->version, pfwheader->signature, (int)sizeof(struct rtl92c_firmware_header)); + rtlhal->fw_version = le16_to_cpu(pfwheader->version); + rtlhal->fw_subversion = pfwheader->subversion; pfwdata = pfwdata + sizeof(struct rtl92c_firmware_header); fwsize = fwsize - sizeof(struct rtl92c_firmware_header); }
The variable "fw_version" is used in the _ResetDigitalProcedure1(). but It is not initialized. so I add init codes for "fw_version" and "fw_subversion". Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- V3 - Fix sparse warning. V2 - Moved new statements into location where header is known to exist. drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 2 ++ 1 file changed, 2 insertions(+)