[1/2] dt-bindings: Add document for MT6311 regulator

Commit Message

Henry Chen July 20, 2015, 7:36 a.m. UTC

This patch adds a list of supported regulator names to the devicetree
binding documentation for Mediatek MT6311 PMIC.

Signed-off-by: Henry Chen <[e-mail]>
---
 .../bindings/regulator/mt6311-regulator.txt        | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/mt6311-regulator.txt

Comments

Mark Brown July 20, 2015, 5:28 p.m. UTC | #1

On Mon, Jul 20, 2015 at 03:36:32PM +0800, Henry Chen wrote:

> +Required properties:
> +- compatible: "mediatek,mt6311-regulator"
> +- mt6311regulator: List of regulators provided by this controller. It is named
> +  to VDVFS and VBIASN.

Why this weird property name?  It looks like it might just be a typo and
should just be "regulator"?

Please use subject lines reflecting the style for the subsystem, it
helps people find patches that are relevant to them.

Henry Chen July 21, 2015, 9:46 a.m. UTC | #2

On Mon, 2015-07-20 at 18:28 +0100, Mark Brown wrote:
> On Mon, Jul 20, 2015 at 03:36:32PM +0800, Henry Chen wrote:
> 
> > +Required properties:
> > +- compatible: "mediatek,mt6311-regulator"
> > +- mt6311regulator: List of regulators provided by this controller. It is named
> > +  to VDVFS and VBIASN.
> 
> Why this weird property name?  It looks like it might just be a typo and
> should just be "regulator"?
Yes, it should be "regulators".

> 
> Please use subject lines reflecting the style for the subsystem, it
> helps people find patches that are relevant to them.

Ok.

Thanks,
Henry

Patch

diff --git a/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt
new file mode 100644
index 0000000..c607029
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt
@@ -0,0 +1,34 @@ 
+Mediatek MT6311 Regulator Driver
+
+Required properties:
+- compatible: "mediatek,mt6311-regulator"
+- mt6311regulator: List of regulators provided by this controller. It is named
+  to VDVFS and VBIASN.
+  The definition for each of these nodes is defined using the standard binding
+  for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
+
+The valid names for regulators are:
+BUCK:
+  VDVFS
+LDO:
+  VBIASN
+
+Example:
+	pmic: mt6311@6B {
+		compatible = "mediatek,mt6311-regulator";
+		reg = <0x6B>;
+
+		regulators {
+			mt6311_vcpu_reg: VDVFS {
+				regulator-name = "VDVFS";
+				regulator-min-microvolt = < 600000>;
+				regulator-max-microvolt = <1400000>;
+				regulator-ramp-delay = <10000>;
+			};
+			mt6311_ldo_reg: VBIASN {
+				regulator-name = "VBIASN";
+				regulator-min-microvolt = <200000>;
+				regulator-max-microvolt = <800000>;
+			};
+		};
+	};