| Message ID | 1436520352-10404-1-git-send-email-james.chen@emc.com.tw (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi James, On Fri, Jul 10, 2015 at 05:25:52PM +0800, james.chen wrote: > From: "james.chen" <james.chen@emc.com.tw> > > This patch is disable idle mode before firmware upgrade procedure. > > BUG=chrome-os-partner:39373 > TEST= Test Elan touchscreen on cyan project(kernel 3.18) without problems. Please add your "signed-off-by" to the patch so that I can apply it. Thank you! > --- > drivers/input/touchscreen/elants_i2c.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 0efd766..6d3570e 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -605,6 +605,7 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, > const u8 enter_iap[] = { 0x45, 0x49, 0x41, 0x50 }; > const u8 enter_iap2[] = { 0x54, 0x00, 0x12, 0x34 }; > const u8 iap_ack[] = { 0x55, 0xaa, 0x33, 0xcc }; > + const u8 close_idle[] = {0x54, 0x2c, 0x01, 0x01}; > u8 buf[HEADER_SIZE]; > u16 send_id; > int page, n_fw_pages; > @@ -617,8 +618,13 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, > } else { > /* Start IAP Procedure */ > dev_dbg(&client->dev, "Normal IAP procedure\n"); > + /* Close idle mode */ > + error = elants_i2c_send(client, close_idle, sizeof(close_idle)); > + if (error) > + dev_err(&client->dev, "Failed close idle: %d\n", error); > + msleep(60); > elants_i2c_sw_reset(client); > - > + msleep(20); > error = elants_i2c_send(client, enter_iap, sizeof(enter_iap)); > } > > -- > 1.8.3.2 >
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 0efd766..6d3570e 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -605,6 +605,7 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, const u8 enter_iap[] = { 0x45, 0x49, 0x41, 0x50 }; const u8 enter_iap2[] = { 0x54, 0x00, 0x12, 0x34 }; const u8 iap_ack[] = { 0x55, 0xaa, 0x33, 0xcc }; + const u8 close_idle[] = {0x54, 0x2c, 0x01, 0x01}; u8 buf[HEADER_SIZE]; u16 send_id; int page, n_fw_pages; @@ -617,8 +618,13 @@ static int elants_i2c_do_update_firmware(struct i2c_client *client, } else { /* Start IAP Procedure */ dev_dbg(&client->dev, "Normal IAP procedure\n"); + /* Close idle mode */ + error = elants_i2c_send(client, close_idle, sizeof(close_idle)); + if (error) + dev_err(&client->dev, "Failed close idle: %d\n", error); + msleep(60); elants_i2c_sw_reset(client); - + msleep(20); error = elants_i2c_send(client, enter_iap, sizeof(enter_iap)); }
From: "james.chen" <james.chen@emc.com.tw> This patch is disable idle mode before firmware upgrade procedure. BUG=chrome-os-partner:39373 TEST= Test Elan touchscreen on cyan project(kernel 3.18) without problems. --- drivers/input/touchscreen/elants_i2c.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)