| Message ID | b47f52abd6a574e5f95760a07a59f445031baefc.1436427954.git.stwiss.opensource@diasemi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > From: S Twiss <stwiss.opensource@diasemi.com> > > Add device tree bindings for the DA9062 RTC driver component > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > > --- > Checks performed with linux-next/next-20150708/scripts/checkpatch.pl > da9062.txt total: 0 errors, 0 warnings, 88 lines checked > This patch applies against linux-next and next-20150708 > > > Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt > index 5765ed9..38802b5 100644 > --- a/Documentation/devicetree/bindings/mfd/da9062.txt > +++ b/Documentation/devicetree/bindings/mfd/da9062.txt > @@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices: > Device Supply Names Description > ------ ------------ ----------- > da9062-regulator : : LDOs & BUCKs > +da9062-rtc : : Real-Time Clock > da9062-watchdog : : Watchdog Timer > > ====== > @@ -41,6 +42,10 @@ Sub-nodes: > Documentation/devicetree/bindings/regulator/regulator.txt > > > +- rtc : This node defines settings required for the Real-Time Clock associated > + with the DA9062. There are currently no entries in this binding, however > + compatible = "dlg,da9062-rtc" should be added if a node is created. > + > - watchdog: This node defines the settings for the watchdog driver associated > with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added > if a node is created. > @@ -55,6 +60,10 @@ Example: > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > > + rtc { > + compatible = "dlg,da9062-rtc"; > + }; > + Are those subnodes even parsed? As the parent node is not compatible with "simple-bus" or "simple-mfd", I guess not. You driver is probed from the mfd_cells in da9063-core.c > watchdog { > compatible = "dlg,da9062-watchdog"; > }; > -- > end-of-patch for PATCH RFC V1 >
On 18 July 2015 00:48, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > > From: S Twiss <stwiss.opensource@diasemi.com> > > > > Add device tree bindings for the DA9062 RTC driver component > > > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> [...] > > +- rtc : This node defines settings required for the Real-Time Clock associated > > + with the DA9062. There are currently no entries in this binding, however > > + compatible = "dlg,da9062-rtc" should be added if a node is created. [...] > > @@ -55,6 +60,10 @@ Example: > > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > > interrupt-controller; > > > > + rtc { > > + compatible = "dlg,da9062-rtc"; > > + }; > > + > > Are those subnodes even parsed? As the parent node is not compatible > with "simple-bus" or "simple-mfd", I guess not. You driver is probed > from the mfd_cells in da9063-core.c Hi Alexandre, If I miss out the compatible line for the RTC in the DTSI for DA9062, or is I alter it so it does not match the string specified in the DA9063 RTC driver, the DA9063 RTC driver will not be probed for the DA9062 compatibility. The RTC compatible = "dlg,da9062-rtc" is essential in this case. [...] Regards, Stephen -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 20/07/2015 at 17:08:00 +0000, Opensource [Steve Twiss] wrote : > If I miss out the compatible line for the RTC in the DTSI for DA9062, or is I alter it > so it does not match the string specified in the DA9063 RTC driver, the DA9063 RTC > driver will not be probed for the DA9062 compatibility. > The RTC compatible = "dlg,da9062-rtc" is essential in this case. > You are right. Disregard my comment.
diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt index 5765ed9..38802b5 100644 --- a/Documentation/devicetree/bindings/mfd/da9062.txt +++ b/Documentation/devicetree/bindings/mfd/da9062.txt @@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices: Device Supply Names Description ------ ------------ ----------- da9062-regulator : : LDOs & BUCKs +da9062-rtc : : Real-Time Clock da9062-watchdog : : Watchdog Timer ====== @@ -41,6 +42,10 @@ Sub-nodes: Documentation/devicetree/bindings/regulator/regulator.txt +- rtc : This node defines settings required for the Real-Time Clock associated + with the DA9062. There are currently no entries in this binding, however + compatible = "dlg,da9062-rtc" should be added if a node is created. + - watchdog: This node defines the settings for the watchdog driver associated with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added if a node is created. @@ -55,6 +60,10 @@ Example: interrupts = <11 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; + rtc { + compatible = "dlg,da9062-rtc"; + }; + watchdog { compatible = "dlg,da9062-watchdog"; };