diff mbox

mwifiex: do not short circuit exit from mwifiex_set_mgmt_ies

Message ID 1435086243-10433-1-git-send-email-linville@tuxdriver.com (mailing list archive)
State Accepted
Delegated to: Kalle Valo
Headers show

Commit Message

John W. Linville June 23, 2015, 7:04 p.m. UTC
Without this change, the code simply exits after calling
mwifiex_uap_set_head_tail_ies, leving the call to
mwifiex_set_mgmt_beacon_data_ies as dead code.

Coverity CID #1271292

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/mwifiex/ie.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Amitkumar Karwar June 24, 2015, 1:07 p.m. UTC | #1
Hi John,

> From: John W. Linville [mailto:linville@tuxdriver.com]
> Sent: Wednesday, June 24, 2015 12:34 AM
> To: linux-wireless@vger.kernel.org
> Cc: Amitkumar Karwar; Avinash Patil; Kalle Valo; John W. Linville
> Subject: [PATCH] mwifiex: do not short circuit exit from
> mwifiex_set_mgmt_ies
> 
> Without this change, the code simply exits after calling
> mwifiex_uap_set_head_tail_ies, leving the call to
> mwifiex_set_mgmt_beacon_data_ies as dead code.
> 
> Coverity CID #1271292
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

Acked-by: Amitkumar Karwar <akarwar@marvell.com>

Thanks,
Amitkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kalle Valo July 21, 2015, 1:47 p.m. UTC | #2
> Without this change, the code simply exits after calling
> mwifiex_uap_set_head_tail_ies, leving the call to
> mwifiex_set_mgmt_beacon_data_ies as dead code.
> 
> Coverity CID #1271292
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Acked-by: Amitkumar Karwar <akarwar@marvell.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/mwifiex/ie.c b/drivers/net/wireless/mwifiex/ie.c
index 0ba894509413..23e368c77c08 100644
--- a/drivers/net/wireless/mwifiex/ie.c
+++ b/drivers/net/wireless/mwifiex/ie.c
@@ -409,6 +409,8 @@  int mwifiex_set_mgmt_ies(struct mwifiex_private *priv,
 	int ret;
 
 	ret = mwifiex_uap_parse_tail_ies(priv, info);
+
+	if (ret)
 		return ret;
 
 	return mwifiex_set_mgmt_beacon_data_ies(priv, info);