| Message ID | 1437553249-25400-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wednesday, July 22, 2015 01:50:49 PM Shilpasri G Bhat wrote: > Check if the cpu is online before changing the frequency/governor of > the cpu. > > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> > --- > tools/power/cpupower/utils/cpufreq-set.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/power/cpupower/utils/cpufreq-set.c > b/tools/power/cpupower/utils/cpufreq-set.c index f656e58..4e21357 100644 > --- a/tools/power/cpupower/utils/cpufreq-set.c > +++ b/tools/power/cpupower/utils/cpufreq-set.c > @@ -17,6 +17,7 @@ > > #include "cpufreq.h" > #include "helpers/helpers.h" > +#include "helpers/sysfs.h" > > #define NORM_FREQ_LEN 32 > > @@ -318,6 +319,9 @@ int cmd_freq_set(int argc, char **argv) > cpufreq_cpu_exists(cpu)) > continue; > > + if (sysfs_is_cpu_online(cpu) != 1) > + continue; > + > printf(_("Setting cpu: %d\n"), cpu); > ret = do_one_cpu(cpu, &new_pol, freq, policychange); > if (ret) { Thanks for catching this one and sending a patch! Acked-by: Thomas Renninger <trenn@suse.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shilpa, This looks good. Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> On Wed, Jul 22, 2015 at 01:50:49PM +0530, Shilpasri G Bhat wrote: > Check if the cpu is online before changing the frequency/governor of > the cpu. > > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> > --- > tools/power/cpupower/utils/cpufreq-set.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c > index f656e58..4e21357 100644 > --- a/tools/power/cpupower/utils/cpufreq-set.c > +++ b/tools/power/cpupower/utils/cpufreq-set.c > @@ -17,6 +17,7 @@ > > #include "cpufreq.h" > #include "helpers/helpers.h" > +#include "helpers/sysfs.h" > > #define NORM_FREQ_LEN 32 > > @@ -318,6 +319,9 @@ int cmd_freq_set(int argc, char **argv) > cpufreq_cpu_exists(cpu)) > continue; > > + if (sysfs_is_cpu_online(cpu) != 1) > + continue; > + > printf(_("Setting cpu: %d\n"), cpu); > ret = do_one_cpu(cpu, &new_pol, freq, policychange); > if (ret) { > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c index f656e58..4e21357 100644 --- a/tools/power/cpupower/utils/cpufreq-set.c +++ b/tools/power/cpupower/utils/cpufreq-set.c @@ -17,6 +17,7 @@ #include "cpufreq.h" #include "helpers/helpers.h" +#include "helpers/sysfs.h" #define NORM_FREQ_LEN 32 @@ -318,6 +319,9 @@ int cmd_freq_set(int argc, char **argv) cpufreq_cpu_exists(cpu)) continue; + if (sysfs_is_cpu_online(cpu) != 1) + continue; + printf(_("Setting cpu: %d\n"), cpu); ret = do_one_cpu(cpu, &new_pol, freq, policychange); if (ret) {
Check if the cpu is online before changing the frequency/governor of the cpu. Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> --- tools/power/cpupower/utils/cpufreq-set.c | 4 ++++ 1 file changed, 4 insertions(+)