| Message ID | 1437535665.17780.1.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b101acfabc9377469af3abfb7cb63112da367284 |
| Headers | show |
On Wednesday 22 July 2015 11:27:45, Axel Lin wrote: > Currently, below code actually does not update any bit because > SGTL5000_SMALL_POP is 0. > > snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1); > > The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> I can not test this right now, but it seems appropriate. Acked-By: Alexander Stein <alexander.stein@systec-electronic.com> > Hi, > I don't have h/w and datasheet, but the code looks obvious does not make > sense. Can someone help to confirm and test if this patch? The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab Best regards, Alexander
2015-07-22 16:58 GMT+08:00 Alexander Stein <alexander.stein@systec-electronic.com>: > On Wednesday 22 July 2015 11:27:45, Axel Lin wrote: >> Currently, below code actually does not update any bit because >> SGTL5000_SMALL_POP is 0. >> >> snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1); >> >> The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it. >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> > > I can not test this right now, but it seems appropriate. > Acked-By: Alexander Stein <alexander.stein@systec-electronic.com> > >> Hi, >> I don't have h/w and datasheet, but the code looks obvious does not make >> sense. Can someone help to confirm and test if this patch? > > The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab I just checked the datasheet and confirm the SMALL_POP is BIT(0). Thanks, Axel
On Wed, Jul 22, 2015 at 11:27 AM, Axel Lin <axel.lin@ingics.com> wrote: > Currently, below code actually does not update any bit because > SGTL5000_SMALL_POP is 0. > > snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1); > > The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Hi, > I don't have h/w and datasheet, but the code looks obvious does not make > sense. Can someone help to confirm and test if this patch? > Thanks, > Axel > sound/soc/codecs/sgtl5000.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h > index bd7a344..1c317de 100644 > --- a/sound/soc/codecs/sgtl5000.h > +++ b/sound/soc/codecs/sgtl5000.h > @@ -275,7 +275,7 @@ > #define SGTL5000_BIAS_CTRL_MASK 0x000e > #define SGTL5000_BIAS_CTRL_SHIFT 1 > #define SGTL5000_BIAS_CTRL_WIDTH 3 > -#define SGTL5000_SMALL_POP 0 > +#define SGTL5000_SMALL_POP 1 > > /* > * SGTL5000_CHIP_MIC_CTRL > -- > 2.1.0 > > > Thanks for your report, seems your are right. I have no board to test it. The code introduced by c251ea7bd7a04f1f2575467e0de76e803cf59149. Fabio, can you verify it on mx28evk? Thanks
On Wed, Jul 22, 2015 at 6:45 AM, Axel Lin <axel.lin@ingics.com> wrote: > I just checked the datasheet and confirm the SMALL_POP is BIT(0). Yes, this is correct: Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index bd7a344..1c317de 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -275,7 +275,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 0 +#define SGTL5000_SMALL_POP 1 /* * SGTL5000_CHIP_MIC_CTRL
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0. snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1); The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks, Axel sound/soc/codecs/sgtl5000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)