| Message ID | 1437664416.20606.3.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9425e9d8c77dd9f40c5f199127a63be2e2b7c1f4 |
| Headers | show |
On 07/23/2015 05:13 PM, Axel Lin wrote: > Slightly improve the logic for de-emphasis sampling rate selection by break > out the loop if the rate is matched. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Daniel Mack <daniel@zonque.org> Thanks, Daniel > --- > sound/soc/codecs/tas5086.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c > index 0a49fc8..d49d25d 100644 > --- a/sound/soc/codecs/tas5086.c > +++ b/sound/soc/codecs/tas5086.c > @@ -266,10 +266,14 @@ static int tas5086_set_deemph(struct snd_soc_codec *codec) > struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec); > int i, val = 0; > > - if (priv->deemph) > - for (i = 0; i < ARRAY_SIZE(tas5086_deemph); i++) > - if (tas5086_deemph[i] == priv->rate) > + if (priv->deemph) { > + for (i = 0; i < ARRAY_SIZE(tas5086_deemph); i++) { > + if (tas5086_deemph[i] == priv->rate) { > val = i; > + break; > + } > + } > + } > > return regmap_update_bits(priv->regmap, TAS5086_SYS_CONTROL_1, > TAS5086_DEEMPH_MASK, val); >
diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c index 0a49fc8..d49d25d 100644 --- a/sound/soc/codecs/tas5086.c +++ b/sound/soc/codecs/tas5086.c @@ -266,10 +266,14 @@ static int tas5086_set_deemph(struct snd_soc_codec *codec) struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec); int i, val = 0; - if (priv->deemph) - for (i = 0; i < ARRAY_SIZE(tas5086_deemph); i++) - if (tas5086_deemph[i] == priv->rate) + if (priv->deemph) { + for (i = 0; i < ARRAY_SIZE(tas5086_deemph); i++) { + if (tas5086_deemph[i] == priv->rate) { val = i; + break; + } + } + } return regmap_update_bits(priv->regmap, TAS5086_SYS_CONTROL_1, TAS5086_DEEMPH_MASK, val);
Slightly improve the logic for de-emphasis sampling rate selection by break out the loop if the rate is matched. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/tas5086.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)