| Message ID | 1438011701-18423-1-git-send-email-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Le 27/07/2015 17:41, Rob Herring a écrit : > A const on a return value is meaningless and generates a warning on some > versions of gcc: > > drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type > > This was found on 0-day with avr32 builds with CONFIG_OF enabled, but > it doesn't seem to generate warnings for other arches. > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Sure: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks Rob! > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > index abadc49..66f4b70 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { > [ATMEL_LCDC_WIRING_RGB] = "RGB", > }; > > -const int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) > +int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) > { > const char *mode; > int err, i; >
On Mon, Jul 27, 2015 at 10:41:41AM -0500, Rob Herring wrote: > A const on a return value is meaningless and generates a warning on some > versions of gcc: > > drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type maybe this one should have been static instead of const. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index abadc49..66f4b70 100644 --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { [ATMEL_LCDC_WIRING_RGB] = "RGB", }; -const int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) +int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) { const char *mode; int err, i;
A const on a return value is meaningless and generates a warning on some versions of gcc: drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type This was found on 0-day with avr32 builds with CONFIG_OF enabled, but it doesn't seem to generate warnings for other arches. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Rob Herring <robh@kernel.org> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/video/fbdev/atmel_lcdfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)