| Message ID | 1438109533-28694-1-git-send-email-rjui@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 28 July 2015 11:52:13 Ray Jui wrote: > config PCIE_IPROC_BCMA > bool "Broadcom iProc PCIe BCMA bus driver" > - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST) > + depends on ARCH_BCM_IPROC && ARM > select PCIE_IPROC > select BCMA > select PCI_DOMAINS > How about this: depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST) That would leave the compile test present for non-iproc ARM platforms while preventing ARM64 and MIPS builds with ARCH_BCM_IPROC set. Arnd
On 7/29/2015 7:30 AM, Arnd Bergmann wrote: > On Tuesday 28 July 2015 11:52:13 Ray Jui wrote: >> config PCIE_IPROC_BCMA >> bool "Broadcom iProc PCIe BCMA bus driver" >> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST) >> + depends on ARCH_BCM_IPROC && ARM >> select PCIE_IPROC >> select BCMA >> select PCI_DOMAINS >> > > How about this: > > depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST) > > That would leave the compile test present for non-iproc > ARM platforms while preventing ARM64 and MIPS builds with > ARCH_BCM_IPROC set. > > Arnd > That is indeed better. Broader compile test coverage is always good. I'll submit another patch with the above suggested change. Thanks, Ray
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index d2c6144..2cc9afe 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -136,7 +136,7 @@ config PCIE_IPROC_PLATFORM config PCIE_IPROC_BCMA bool "Broadcom iProc PCIe BCMA bus driver" - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST) + depends on ARCH_BCM_IPROC && ARM select PCIE_IPROC select BCMA select PCI_DOMAINS
The current iProc BCMA front-end driver can only work on ARM32 based platforms; therefore its config option in Kconfig should be changed to reflect that. This fixes arm64 allmodconfig build failure when compiling the the iProc BCMA driver that contains struct pci_sys_data that is arm32 specific Signed-off-by: Ray Jui <rjui@broadcom.com> --- drivers/pci/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)