| Message ID | 1437913255-7524-3-git-send-email-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks fine, with the same caveat as the previous patch:
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in index 3e059af..bfab7cc 100644 --- a/include/platform_defs.h.in +++ b/include/platform_defs.h.in @@ -35,6 +35,7 @@ #include <sys/types.h> #include <limits.h> #include <stdbool.h> +#include <libgen.h> #undef HAVE___U32 #ifdef HAVE___U32
The function prototype for basename() is in <libgen.h>, per Posix. Without the the function prototype, the build will throw errors due to the missing prototype. On glibc, using libgen.h will force the use of Poxis's basename(), instead of glibc's basename() with GNU extensions. However, xfsprogs doesn't depend on any of the GNU extensions, so this is fine. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- include/platform_defs.h.in | 1 + 1 file changed, 1 insertion(+)