| Message ID | 1438547113.29569.5.camel@perches.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Joe Perches <joe@perches.com> writes: > Correct misuse of 0x%d in logging messages. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/block/DAC960.c | 4 ++-- > drivers/block/cciss.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c > index 811e11c..d9b32f2 100644 > --- a/drivers/block/DAC960.c > +++ b/drivers/block/DAC960.c > @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, > case DAC960_PD_Controller: > if (!request_region(Controller->IO_Address, 0x80, > Controller->FullModelName)) { > - DAC960_Error("IO port 0x%d busy for Controller at\n", > + DAC960_Error("IO port 0x%x busy for Controller at\n", > Controller, Controller->IO_Address); > goto Failure; > } > @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, > case DAC960_P_Controller: > if (!request_region(Controller->IO_Address, 0x80, > Controller->FullModelName)){ > - DAC960_Error("IO port 0x%d busy for Controller at\n", > + DAC960_Error("IO port 0x%x busy for Controller at\n", > Controller, Controller->IO_Address); > goto Failure; > } > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index 0422c47..2758982 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h) > readl(&(tb->HostWrite.CoalIntDelay))); > dev_dbg(&h->pdev->dev, " Coalesce Interrupt Count = 0x%x\n", > readl(&(tb->HostWrite.CoalIntCount))); > - dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n", > + dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%x\n", > readl(&(tb->CmdsOutMax))); > dev_dbg(&h->pdev->dev, " Bus Types = 0x%x\n", > readl(&(tb->BusTypes))); > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: > > Correct misuse of 0x%d in logging messages. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/block/DAC960.c | 4 ++-- > drivers/block/cciss.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c > index 811e11c..d9b32f2 100644 > --- a/drivers/block/DAC960.c > +++ b/drivers/block/DAC960.c > @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, > case DAC960_PD_Controller: > if (!request_region(Controller->IO_Address, 0x80, > Controller->FullModelName)) { > - DAC960_Error("IO port 0x%d busy for Controller at\n", > + DAC960_Error("IO port 0x%x busy for Controller at\n", > Controller, Controller->IO_Address); > goto Failure; > } > @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, > case DAC960_P_Controller: > if (!request_region(Controller->IO_Address, 0x80, > Controller->FullModelName)){ > - DAC960_Error("IO port 0x%d busy for Controller at\n", > + DAC960_Error("IO port 0x%x busy for Controller at\n", > Controller, Controller->IO_Address); > goto Failure; > } > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index 0422c47..2758982 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h) > readl(&(tb->HostWrite.CoalIntDelay))); > dev_dbg(&h->pdev->dev, " Coalesce Interrupt Count = 0x%x\n", > readl(&(tb->HostWrite.CoalIntCount))); > - dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n", > + dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%x\n", > readl(&(tb->CmdsOutMax))); > dev_dbg(&h->pdev->dev, " Bus Types = 0x%x\n", > readl(&(tb->BusTypes))); > — why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding commands = %#x\n” ? %#x will add 0x prefix automatically . Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: > > On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: > > > > Correct misuse of 0x%d in logging messages. > > [] > why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding > commands = %#x\n” ? > %#x will add 0x prefix automatically . It's generally a consistency thing. A 0 value would be emitted as 0 and not 0x0. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote: > > On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: >>> >>> Correct misuse of 0x%d in logging messages. >>> > [] >> why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding >> commands = %#x\n” ? >> %#x will add 0x prefix automatically . > > It's generally a consistency thing. > A 0 value would be emitted as 0 and not 0x0. > i try on my ubuntu , static int __init throtl_init(void) { printk("module init test: %#x %p\n", 0, (void *)0x123); return 0; } module_init(throtl_init); #uname -a Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux #dmesg [259356.375586] module init test: 0x0 0000000000000123 it seems don’t need 0x%x for 0, just need %#x for all numbers. there are lots of use like this, i can change them if needed: # egrep -r -i '0x%\d*x' . | wc -l 11776 Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ping ? > On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@gmail.com> wrote: > > >> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote: >> >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: >>>> >>>> Correct misuse of 0x%d in logging messages. >>>> >> [] >>> why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding >>> commands = %#x\n” ? >>> %#x will add 0x prefix automatically . >> >> It's generally a consistency thing. >> A 0 value would be emitted as 0 and not 0x0. >> > i try on my ubuntu , > > static int __init throtl_init(void) > { > printk("module init test: %#x %p\n", 0, (void *)0x123); > return 0; > > } > > module_init(throtl_init); > > #uname -a > Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux > > #dmesg > [259356.375586] module init test: 0x0 0000000000000123 > > it seems don’t need 0x%x for 0, just need %#x for all numbers. > there are lots of use like this, i can change them if needed: > > # egrep -r -i '0x%\d*x' . | wc -l > 11776 > > > Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: > Ping ? > > On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@gmail.com> wrote: > > > > > >> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote: > >> > >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: > >>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: > >>>> > >>>> Correct misuse of 0x%d in logging messages. > >>>> > >> [] > >>> why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding > >>> commands = %#x\n” ? > >>> %#x will add 0x prefix automatically . > >> > >> It's generally a consistency thing. > >> A 0 value would be emitted as 0 and not 0x0. > >> > > i try on my ubuntu , > > > > static int __init throtl_init(void) > > { > > printk("module init test: %#x %p\n", 0, (void *)0x123); > > return 0; > > > > } > > > > module_init(throtl_init); > > > > #uname -a > > Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux > > > > #dmesg > > [259356.375586] module init test: 0x0 0000000000000123 > > > > it seems don’t need 0x%x for 0, just need %#x for all numbers. > > there are lots of use like this, i can change them if needed: > > > > # egrep -r -i '0x%\d*x' . | wc -l > > 11776 I suggest not, it's not a standard usage and the 0 may be unexpected. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On Aug 4, 2015, at 10:27, Joe Perches <joe@perches.com> wrote: > > On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: >> Ping ? >>> On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@gmail.com> wrote: >>> >>> >>>> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote: >>>> >>>> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >>>>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote: >>>>>> >>>>>> Correct misuse of 0x%d in logging messages. >>>>>> >>>> [] >>>>> why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding >>>>> commands = %#x\n” ? >>>>> %#x will add 0x prefix automatically . >>>> >>>> It's generally a consistency thing. >>>> A 0 value would be emitted as 0 and not 0x0. >>>> >>> i try on my ubuntu , >>> >>> static int __init throtl_init(void) >>> { >>> printk("module init test: %#x %p\n", 0, (void *)0x123); >>> return 0; >>> >>> } >>> >>> module_init(throtl_init); >>> >>> #uname -a >>> Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux >>> >>> #dmesg >>> [259356.375586] module init test: 0x0 0000000000000123 >>> >>> it seems don’t need 0x%x for 0, just need %#x for all numbers. >>> there are lots of use like this, i can change them if needed: >>> >>> # egrep -r -i '0x%\d*x' . | wc -l >>> 11776 > > I suggest not, it's not a standard usage and the 0 > may be unexpected. > ok, printk for %x is really not compatible with glibc printf behavior, another is %p, printk print %p as hex but not with 0x prefix, while printf print %p as 0x…. with prefix, is this need change ? so we don’t need lots of 0x%p printk . -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 811e11c..d9b32f2 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, case DAC960_PD_Controller: if (!request_region(Controller->IO_Address, 0x80, Controller->FullModelName)) { - DAC960_Error("IO port 0x%d busy for Controller at\n", + DAC960_Error("IO port 0x%x busy for Controller at\n", Controller, Controller->IO_Address); goto Failure; } @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, case DAC960_P_Controller: if (!request_region(Controller->IO_Address, 0x80, Controller->FullModelName)){ - DAC960_Error("IO port 0x%d busy for Controller at\n", + DAC960_Error("IO port 0x%x busy for Controller at\n", Controller, Controller->IO_Address); goto Failure; } diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 0422c47..2758982 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h) readl(&(tb->HostWrite.CoalIntDelay))); dev_dbg(&h->pdev->dev, " Coalesce Interrupt Count = 0x%x\n", readl(&(tb->HostWrite.CoalIntCount))); - dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n", + dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%x\n", readl(&(tb->CmdsOutMax))); dev_dbg(&h->pdev->dev, " Bus Types = 0x%x\n", readl(&(tb->BusTypes)));
Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html