| Message ID | 1438641357-25588-1-git-send-email-barletz@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ok, it has cost me quite some time to figure out what "!length > 0" is actually doing, but looks ok to me. Tomer Barletz <barletz@gmail.com> writes: > This fixes the following warning seen with GCC v5.1: > warning: logical not is only applied to the left hand side of > comparison [-Wlogical-not-parentheses]. > > Signed-off-by: Tomer Barletz <barletz@gmail.com> > --- > drivers/scsi/be2iscsi/be_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index 7a6dbfb..ff8d40e 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address, > { > WARN_ON(!virtual_address); > WARN_ON(!physical_address); > - WARN_ON(!length > 0); > + WARN_ON(0 == length); Please write WARN_ON(length == 0); > WARN_ON(!sgl); > > sgl->va = virtual_address; Given the above is swapped: Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 7a6dbfb..ff8d40e 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address, { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length > 0); + WARN_ON(0 == length); WARN_ON(!sgl); sgl->va = virtual_address;
This fixes the following warning seen with GCC v5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz <barletz@gmail.com> --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)